New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867451 link

Starred by 1 user
Status: Fixed
Owner:
li...@yandex-team.ru
Closed: Jul 27
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

SetFirstSetupComplete could not be called before engine initialization

Project Member Reported by li...@yandex-team.ru, Jul 25 
Now SetFirstSetupComplete expect to be called before engine initialization.
But some points in code exist that do not expect that.

We find this because in some user stories, do not have to use first setup step.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/913997b0e0c5f1a2c5e62c9ea8276184f0737629

commit 913997b0e0c5f1a2c5e62c9ea8276184f0737629
Author: Aleksei Loshkarev <lixan@yandex-team.ru>
Date: Thu Jul 26 16:20:25 2018

Enables SetFirstSetupComplete before init

If SetFirstSetupComplete was called before engine initialization,
we'd record wrong UMA histograms and called DataTypeManager::Configure
with wrong configure reason.

The Yandex Browser wants to able to do this because in some signin scripts,
for example corporate browser, user do not need to change sync channels.
In this scenario RequestStart and SetFirstSetupComplete calls happpens
simultaneously.

Bug:  867451 
Change-Id: Iec326c542476adf42c291cf2e002fc52e0a7b99d
Reviewed-on: https://chromium-review.googlesource.com/1150175
Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578328}
[modify] https://crrev.com/913997b0e0c5f1a2c5e62c9ea8276184f0737629/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/913997b0e0c5f1a2c5e62c9ea8276184f0737629/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/913997b0e0c5f1a2c5e62c9ea8276184f0737629/components/browser_sync/profile_sync_service_unittest.cc

Comment 2 by li...@yandex-team.ru, Jul 27

Status: Fixed (was: Untriaged)
►

Sign in to add a comment