New issue
Advanced search Search tips

Issue 867450 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Rebaseline and check new exposed Android WebView interfaces

Project Member Reported by timvolod...@chromium.org, Jul 25

Issue description

A number of new interfaces have been exposed in Chrome and WebView (see below) since the last check/rebaseline. Some of the newly exposed interfaces in Chrome have been explicitly excluded in WebView, others have just been exposed by default.

This bug to address:
1. rebaseline the expected interfaces file for WebView (which is stale),
2. double-check that the exposed interfaces should indeed be exposed.

--

From https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8940027067764360400%2F%2B%2Flogcat_logcat_org.chromium.webview_shell.test.WebViewLayoutTest.testNoUnexpectedInterfaces_20180725T131129-UTC_01e0d05fa22db28f


07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: Unexpected WebView interfaces found: interface CSSSupportsRule : CSSConditionRule
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSTransformValue : CSSStyleValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CountQueuingStrategy
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface KeyboardLayoutMap
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface OffscreenCanvasRenderingContext2D
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface StaticRange
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSSkew : CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface TaskAttributionTiming : PerformanceEntry
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface WebGL2RenderingContext
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSScale : CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface ImageBitmapRenderingContext
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCRtpTransceiver
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface BroadcastChannel : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCPeerConnectionIceEvent : Event
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCDTMFSender : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface DOMPoint : DOMPointReadOnly
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface VisualViewport : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface OrientationSensor : Sensor
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface ReportingObserver
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface AudioWorkletNode : AudioNode
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaStream : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CustomElementRegistry
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface ResizeObserverEntry
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface PointerEvent : MouseEvent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface OffscreenCanvas : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface HTMLSlotElement : HTMLElement
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface AbortSignal : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface ImageCapture
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCPeerConnection : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface AudioWorklet : Worklet
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCRtpSender
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaElementAudioSourceNode : AudioNode
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBIsochronousOutTransferPacket
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface WritableStream
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCRtpReceiver
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface OverconstrainedError
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSNumericArray
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface Lock
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface DOMRect : DOMRectReadOnly
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBAlternateInterface
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface PerformanceLongTaskTiming : PerformanceEntry
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface FederatedCredential : Credential
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSPerspective : CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface DOMMatrix : DOMMatrixReadOnly
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBIsochronousOutTransferResult
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBInterface
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface OscillatorNode : AudioScheduledSourceNode
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface IntersectionObserverEntry
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSVariableReferenceValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface WebGLSync
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSRotate : CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBInTransferResult
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSConditionRule : CSSGroupingRule
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface NavigationPreloadManager
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBConfiguration
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSUnparsedValue : CSSStyleValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface DOMRectReadOnly
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaSettingsRange
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBEndpoint
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface TransformStream
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface Credential
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaDeviceInfo
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface WebGLQuery
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface LockManager
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSImageValue : CSSStyleValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface DOMMatrixReadOnly
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface PasswordCredential : Credential
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface PerformanceObserver
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaDevices : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSSkewX : CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCRtpContributingSource
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface DOMQuad
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface Accelerometer : Sensor
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface PerformancePaintTiming : PerformanceEntry
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CanvasCaptureMediaStreamTrack : MediaStreamTrack
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface PerformanceNavigationTiming : PerformanceResourceTiming
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface PannerNode : AudioNode
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBDevice
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface BudgetService
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface WebGLVertexArrayObject
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface StereoPannerNode : AudioNode
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCDataChannelEvent : Event
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaCapabilities
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaCapabilitiesInfo
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface Worklet
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSPositionValue : CSSStyleValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaStreamAudioSourceNode : AudioNode
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSMathSum : CSSMathValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USB : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RTCStatsReport
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface OfflineAudioContext : BaseAudioContext
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface InputEvent : UIEvent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSTranslate : CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface ByteLengthQueuingStrategy
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface BaseAudioContext : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface AudioBufferSourceNode : AudioScheduledSourceNode
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface GamepadHapticActuator
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSMatrixComponent : CSSTransformComponent
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface Gyroscope : Sensor
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface AudioContext : BaseAudioContext
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface SensorErrorEvent : Event
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface USBConnectionEvent : Event
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface RelativeOrientationSensor : OrientationSensor
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface MediaStreamTrackEvent : Event
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface InputDeviceInfo : MediaDeviceInfo
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSNumericValue : CSSStyleValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface Sensor : EventTarget
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSMathMax : CSSMathValue
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface AudioParamMap
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface Keyboard
07-25 13:11:33.359  5652  5667 W cr_WebViewLayoutTest: interface CSSMathInvert : CSSMathValue
[...]

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331047f3f9968374107d7ead13584bb15d25ddf2

commit 331047f3f9968374107d7ead13584bb15d25ddf2
Author: Tim Volodine <timvolodine@chromium.org>
Date: Fri Jul 27 11:51:33 2018

[Android WebView Layout Tests] Rebaseline expected interfaces/properties [1]

Rebaseline some interfaces/properties that have been exposed in Chrome and
should also be exposed in Android WebView. In particular:
- attribute @@toStringTag
- method @@iterator
- attribute @@unscopables
- CSS* related interfaces/attributes

BUG=867450

Change-Id: Iee23c9f75fb3031826dfe388920a1ae6b3a9722e
Reviewed-on: https://chromium-review.googlesource.com/1150177
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578600}
[modify] https://crrev.com/331047f3f9968374107d7ead13584bb15d25ddf2/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c81a95677e4973c1eba2831f558665650a41017

commit 2c81a95677e4973c1eba2831f558665650a41017
Author: Tim Volodine <timvolodine@chromium.org>
Date: Fri Sep 21 19:07:58 2018

[Android WebView Layout Tests] Rebaseline expected interfaces/properties [2]

Rebaseline some interfaces/properties that have been exposed in Chrome and
should also be exposed in Android WebView. In particular:
- AbortController, AbortSignal
- Sensor API related interfaces:
  -- e.g. Sensor, Accelerometer, Gyroscope, OrientationSensor, ...
- Web Audio related interfaces modifications:
  -- e.g. BaseAudioContext, AudioParamMap, AudioContext.baseLatency,
  -- e.g. AudioListener.position*, AudioParam.automationRate, ...
- Canvas interface related modifications:
  -- e.g. CanvasRenderingContext2D.filter, ...
- New DOM geometry primitives:
  -- e.g. DOMMatrix, DOMPoint, ..
- New Document/Element/Event related methods/attr:
  -- e.g. Document.linkColor, Document.onpointermove, Document.onvisibilitychange
  -- e.g. DocumentType.replaceWith
  -- e.g. Element.slot, Element.computedStyleMap
  -- e.g. Event.composed
- FontFace related modifications:
  -- e.g. FontFace.display
- FormData modifications:
  -- e.g. FormData.values..
- Gamepad API related:
  -- e.g. Gamepad.vibrationActuator, GamepadHapticActuator
- HTML element related modifications:
  -- e.g. HTMLAnchorElement.referrerPolicy, HTMLAreaElement.download,
  -- e.g. HTMLBodyElement.onafterprint, HTMLCanvasElement.captureStream
  -- e.g. HTMLElement.autocapitalize, HTMLFrameSetElement.onmessageerror
  -- e.g. HTMLImageElement.decoding, HTMLSlotElement
- IndexedDB API related modifications:
  -- e.g. IDBCursor.continuePrimaryKey,
  -- e.g. IDBKeyRange.includes, IDBObjectStore.name
- new Image interface attrbiutes/methods:
  -- e.g. Image.align, Image.decode, ImageData.data,..
- KeyboardEvent modifications:
  -- e.g. KeyboardEvent.isComposing, KeyboardLayoutMap
- Media* related modifications:
  -- e.g. MediaSource.onsourceclose, MediaStreamTrack.getCapabilities,
  -- e.g. MediaStreamTRackEvent
- Network Information API modifications:
  -- e.g. NetworkInformation.downlink, NetworkInformation.rtt
- Node and NodeList modifications
- Option interface modifications
- Performance Timeline API related e.g.:
  -- e.g. PerformanceLongTaskTiming, PerformanceNavigationTiming,
  -- e.g. PerformanceObserver, PerformancePaintTiming, PerformanceServerTiming, ...
- Streams API modifications:
  -- e.g. ReadableStream.pipeTo
- Fetch API modifications:
  -- e.g. Request.cache, Request.destination, Response.redirected
- SVG DOM interface modifications:
  -- e.g. SVGElement.dataset, SVGElement.onpointermove
  -- e.g. SVGImageElement.decoding
- ServiceWorker updates:
  -- e.g. ServiceWorkerContainer.controller, ServiceWorkerRegistration.active
- Other modifications:
  -- SourceBuffer and SourceBufferList changes
  -- URL.searchParams, URL.sort
  -- webkitRTCPeerConnection modifications.
  -- e.g. Path2D.addPath
  -- SecurityPolicyViolationEvent.sample, Selection.removeRange
  -- AnimationEvent.pseudoElement

This patch also removes some deleted interfaces/attributes:
  -- e.g. Attr.nodeValue, ClientRect, DataView, FileError,
  -- e.g. HTMLKeygenElement, NodeFilter, ReadableByteStream,
  -- e.g. webkitAudioContext, webkitOfflineAudioContext,
  -- e.g. webkitIDB* interfaces
  -- e.g. global Bluetooth* attributes

Also replace previously 'attribute' properties which have been replaced
by getters/setters:
  -- e.g. applicationCache, navigator, ondevicemotion,
  -- e.g. document, isSecureContext, onload, ...

BUG=867450

Change-Id: I509b6744a6206a57543ff858a4fd4cbf7754f91a
Reviewed-on: https://chromium-review.googlesource.com/1154910
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593286}
[modify] https://crrev.com/2c81a95677e4973c1eba2831f558665650a41017/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt

Sign in to add a comment