New issue
Advanced search Search tips

Issue 867426 link

Starred by 4 users
Status: Fixed
Owner: ----
Closed: Aug 9
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox: continually prompts user about non-wifi alerts

Project Member Reported by leberly@chromium.org, Jul 25 
Google Chrome	69.0.3494.0 (Official Build) dev (64-bit)
Google Eve
Google Chrome	69.0.3497.21 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

Steps to reproduce:
# Turn on ChromeVox via ctrl + alt + z
# Connect a low-power charger. I used the USB-C charger designed for my phone on the Chromebook.
# Notification alert appears visually "Low-power charger connected Your Chromebook may not charge while it is turned on." 
# Note that focus is not on the notification
# Let computer sit, listen to ChromeVox
Expected: ChromeVox reads notification once
Actual: ChromeVox reads notification every few seconds

This also happens when using an incorrect keyboard shortcut. To further repro the bug, press "shift + alt + k" to generate this alert:
"Alert! Change shortcut, the shortcut to show the inbox option menu in the shelf has changed, use search + shift + k instead of shift + alt + k."

This also repeats every few seconds.

Comment 1 by leberly@chromium.org, Aug 6 

Updating this bug to be more general since this is happening in multiple alert dialogs. The wifi alert specifically was corrected in this bug https://bugs.chromium.org/p/chromium/issues/detail?id=775566

Comment 2 by leberly@chromium.org, Aug 6

Description: Show this description

Comment 3 by leberly@chromium.org, Aug 6

Summary: ChromeVox: continually prompts user about non-wifi alerts (was: ChromeVox: continually prompts user about low-power charger connected )

Comment 4 by leberly@chromium.org, Aug 7

Labels: M69A11yTests

Comment 5 by leberly@chromium.org, Aug 7 

This also applies to alerts around adding extensions. 


Google Chrome	69.0.3497.21 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

Steps: 
# Turn on ChromeVox
# Add any extension, here's an example: https://chrome.google.com/webstore/detail/acapela-tts-engine/hfpbgbaepoblbkbmpojjnpkeikgoadil/related
# Listen
Expected: alert read once
Actual: alert repeated many times

Comment 6 by leberly@chromium.org, Aug 7

Labels: -Pri-2 Pri-1
Bumping to p1 since this is pretty pervasive.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feb758c3648069733c99f2d48a88982879acfcc0

commit feb758c3648069733c99f2d48a88982879acfcc0
Author: David Tseng <dtseng@chromium.org>
Date: Wed Aug 08 04:50:01 2018

Only alert accessibility when a notification's text changes

Bug:  867426 
Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208
Reviewed-on: https://chromium-review.googlesource.com/1166231
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581474}
[modify] https://crrev.com/feb758c3648069733c99f2d48a88982879acfcc0/ui/message_center/views/message_popup_view.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad61824174cc5f047a110365246d1db5e47dee39

commit ad61824174cc5f047a110365246d1db5e47dee39
Author: David Tseng <dtseng@chromium.org>
Date: Wed Aug 08 17:14:34 2018

Revert "Only alert accessibility when a notification's text changes"

This reverts commit feb758c3648069733c99f2d48a88982879acfcc0.

Reason for revert: <INSERT REASONING HERE>
SpokenFeedbackTests failing on chromeos dbg
Original change's description:
> Only alert accessibility when a notification's text changes
> 
> Bug:  867426 
> Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208
> Reviewed-on: https://chromium-review.googlesource.com/1166231
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581474}

TBR=stevenjb@chromium.org,dtseng@chromium.org

Change-Id: I8b23c03e08642caa7b05d2ce88e6f330dd056c37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  867426 
Reviewed-on: https://chromium-review.googlesource.com/1167603
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581607}
[modify] https://crrev.com/ad61824174cc5f047a110365246d1db5e47dee39/ui/message_center/views/message_popup_view.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e465430d751b901cf1265e9128cbb7ccae358b7f

commit e465430d751b901cf1265e9128cbb7ccae358b7f
Author: David Tseng <dtseng@chromium.org>
Date: Thu Aug 09 12:36:00 2018

Reland "Only alert accessibility when a notification's text changes"

This reverts commit ad61824174cc5f047a110365246d1db5e47dee39.

Reason for revert: <INSERT REASONING HERE>
Chromeos-dbg bots are now green (for chromevox); this change was unlikely to be at fault.

Original change's description:
> Revert "Only alert accessibility when a notification's text changes"
> 
> This reverts commit feb758c3648069733c99f2d48a88982879acfcc0.
> 
> Reason for revert: <INSERT REASONING HERE>
> SpokenFeedbackTests failing on chromeos dbg
> Original change's description:
> > Only alert accessibility when a notification's text changes
> > 
> > Bug:  867426 
> > Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208
> > Reviewed-on: https://chromium-review.googlesource.com/1166231
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581474}
> 
> TBR=stevenjb@chromium.org,dtseng@chromium.org
> 
> Change-Id: I8b23c03e08642caa7b05d2ce88e6f330dd056c37
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  867426 
> Reviewed-on: https://chromium-review.googlesource.com/1167603
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581607}

TBR=stevenjb@chromium.org,dtseng@chromium.org

Change-Id: I0b1270e0ebdbfbca89baefe9a9f676062862479e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  867426 
Reviewed-on: https://chromium-review.googlesource.com/1168329
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581875}
[modify] https://crrev.com/e465430d751b901cf1265e9128cbb7ccae358b7f/ui/message_center/views/message_popup_view.cc

Comment 10 by dtseng@chromium.org, Aug 9

Status: fixed (was: Available)

Comment 11 by leberly@chromium.org, Sep 1 

 Issue 807389  has been merged into this issue.
►

Sign in to add a comment