New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867421 link

Starred by 2 users
Status: Fixed
Owner:
eseckler@chromium.org
Closed: Oct 1
Cc:
skyos...@chromium.org
altimin@chromium.org
gab@chromium.org
█ alexclarke@chromium.org
█ kraynov@chromium.org
robliao@chromium.org
fdoray@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature

Blocking:
issue 878356



Sign in to add a comment

Adapt TaskTraits for use with BrowserThreads

Project Member Reported by eseckler@chromium.org, Jul 25 
We'd like to make base::PostTaskWithTraits extensible by //content, so that we can use it to post tasks to browser threads and annotate them with traits that influence task scheduling on sequences. For example:

// Post a network task associated with a specific frame to the browser's UI thread.
base::PostTaskWithTraits(FROM_HERE, {
    content::BrowserThread::UI,
    content::TaskType::kNetwork,
    content::FrameToken(render_frame_host->GetDevToolsFrameToken()),
    content::BlocksLoad()}, base::Bind(...));

See design doc: https://docs.google.com/document/d/1SGy9VTXUwyXEX_yBZ0ukFAnS8B0hDeMUJD-1iALaE-Q/edit?usp=sharing
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c

commit ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Aug 03 19:20:47 2018

[TaskScheduler] Forward all public TaskScheduler headers to forwarding headers in preparation for source move

Core move CL : https://chromium-review.googlesource.com/c/chromium/src/+/1161088

Move strategy :
 1) Rebase this CL on ToT and mass migrate all callers of public base/task_scheduler
    headers to their matching *_forward.h header.
 2) Land core move CL
 3) Mass migrate away from *_forward.h headers in
    https://chromium-review.googlesource.com/c/chromium/src/+/1161116

This move strategy was chosen to keep as much git history as possible
in (2). See code comments on forward headers for details.

Once this CL and its follow-ups are approved, I will sync it to
top-of-tree, mass migrate all existing users of these headers to
their *_forward.h version in this CL (TBR'ed) and follow-up with
the other two swiftly back-to-back.

TBR=robliao@chromium.org (for mass migration of existing callers)

Bug:  867421 
Change-Id: Iea684e022181c0611abe7f92629599afc369822b
Reviewed-on: https://chromium-review.googlesource.com/1161179
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580622}
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/aw_browser_terminator.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/aw_contents_io_thread_client.h
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/aw_form_database_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/net/android_stream_reader_url_request_job.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/android_webview/browser/tracing/aw_tracing_controller.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/apps/launcher.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/ash/assistant/assistant_screen_context_controller.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/ash/components/cursor/cursor_view.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/ash/display/display_color_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/ash/display/display_color_manager_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/BUILD.gn
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/debug/task_annotator_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/i18n/streaming_utf8_validator_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/observer_list_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/process/kill.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/process/kill_fuchsia.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/process/kill_posix.cc
[add] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/task/lazy_task_runner_forward.h
[add] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/task/post_task_forward.h
[add] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/task/single_thread_task_runner_thread_mode_forward.h
[add] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/task/task_scheduler/initialization_util_forward.h
[add] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/task/task_scheduler/task_scheduler_forward.h
[add] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/task/task_traits_forward.h
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/test/scoped_task_environment.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/test/scoped_task_environment.h
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/test/scoped_task_environment_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/threading/sequenced_task_runner_handle_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/timer/hi_res_timer_manager_win.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/timer/timer_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/base/trace_event/trace_log.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/cc/tiles/image_controller.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/after_startup_task_utils_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/download/download_media_parser_bridge.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/history_report/delta_file_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/history_report/usage_reports_buffer_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/password_ui_view_android.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/thumbnail/thumbnail_cache.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/vr/mailbox_to_surface_bridge.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/background/background_mode_manager_mac.mm
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/background/background_mode_manager_win.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/bookmarks/bookmark_html_writer.h
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/browser_process_impl_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/browsing_data/site_data_size_collector.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/budget_service/budget_database.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chrome_browser_main_linux.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/app_mode/kiosk_app_data_base.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/app_mode/kiosk_app_icon_loader.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/fileapi/file_stream_forwarder.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/process/arc_process_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/base/file_flusher.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/base/locale_util.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/boot_times_recorder.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/camera_detector.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/crostini/crostini_registry_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/crostini/crostini_util.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/customization/customization_document.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/customization/customization_wallpaper_util.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/drive/fileapi/async_file_util.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/drive/write_on_cache_file.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/default_app_order.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/echo_private_api.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/external_cache_impl_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/install_limiter.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/external_metrics.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/file_manager/file_watcher.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/file_manager/file_watcher_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/file_manager/open_with_browser.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/file_manager/snapshot_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/first_run/goodies_displayer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/hats/hats_dialog.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/input_method/input_method_syncer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/logging.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/demo_mode/demo_extensions_external_loader.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/oobe_configuration.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/screens/reset_screen.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/startup_utils.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/mobile_config.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/net/client_cert_store_chromeos.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/platform_keys/platform_keys.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/app_install_event_log_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/app_install_event_logger.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/dm_token_storage.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/power/cpu_data_collector.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/power/process_data_collector.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/power/process_data_collector_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/printing/external_printers.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/printing/printer_info_cups.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/printing/printer_info_stub.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/printing/printers_sync_bridge.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/settings/session_manager_operation.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system/automatic_reboot_manager.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system_logs/command_line_log_source.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system_logs/debug_log_writer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system_logs/iwlwifi_dump_log_source.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/system_logs/touch_log_source.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/chromeos/tpm_firmware_update.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/component_patcher_operation_browsertest.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/crl_set_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/cros_component_installer_chromeos.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/mei_preload_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/optimization_hints_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/pnacl_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc
[modify] https://crrev.com/ffaaf85f21e2dd32f6fba8391cee9dc7eab50f6c/chrome/browser/component_updater/sth_set_component_installer.cc
[modify] https://crrev.com/ffaaf85f2
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43215b1ff484a9b0619375344fe8612b95bfb872

commit 43215b1ff484a9b0619375344fe8612b95bfb872
Author: Gabriel Charette <gab@chromium.org>
Date: Sun Aug 05 21:53:43 2018

[TaskScheduler] Migrate a few more headers missed in //third_party

This is the //third_party equivalent to
https://chromium-review.googlesource.com/c/chromium/src/+/1161179
(DEPS tweak will soon be recovered to moved header in
https://chromium-review.googlesource.com/c/chromium/src/+/1161116)

TBR=skyostil@chromium.org

Bug:  867421 
Change-Id: I607bf6caa71dda52e3290d59daaac568c2cba626
Reviewed-on: https://chromium-review.googlesource.com/1162639
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580784}
[modify] https://crrev.com/43215b1ff484a9b0619375344fe8612b95bfb872/third_party/blink/renderer/DEPS
[modify] https://crrev.com/43215b1ff484a9b0619375344fe8612b95bfb872/third_party/blink/renderer/platform/blob/blob_bytes_provider.cc
[modify] https://crrev.com/43215b1ff484a9b0619375344fe8612b95bfb872/third_party/blink/renderer/platform/scheduler/DEPS
[modify] https://crrev.com/43215b1ff484a9b0619375344fe8612b95bfb872/third_party/blink/renderer/platform/scheduler/common/background_scheduler.cc
[modify] https://crrev.com/43215b1ff484a9b0619375344fe8612b95bfb872/third_party/blink/renderer/platform/scheduler/public/background_scheduler.h
[modify] https://crrev.com/43215b1ff484a9b0619375344fe8612b95bfb872/third_party/webrtc_overrides/rtc_base/task_queue.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135

commit dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135
Author: Gabriel Charette <gab@chromium.org>
Date: Sun Aug 05 21:54:13 2018

[TaskScheduler] Also add temporary forward headers for scheduler_worker_(pool_)?params.h

And fix one more missing migration.

TBR=skyostil@chromium.org

Bug:  867421 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0e7ff198c8fef8ac223025c93df08cdaedc79164
Reviewed-on: https://chromium-review.googlesource.com/1163282
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580785}
[modify] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/base/BUILD.gn
[add] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/base/task/task_scheduler/scheduler_worker_params_forward.h
[add] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/base/task/task_scheduler/scheduler_worker_pool_params_forward.h
[modify] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/chrome/service/service_process.cc
[modify] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/components/task_scheduler_util/variations_util_unittest.cc
[modify] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/ios/web/app/web_main_loop.mm
[modify] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/net/third_party/quic/tools/quic_client_bin.cc
[modify] https://crrev.com/dcdd5935ac09bf2a7f3ba5c0905c3ba8427b6135/net/third_party/quic/tools/quic_server_bin.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d832c4d4182a51329c13aff4a97edb4933a6385

commit 5d832c4d4182a51329c13aff4a97edb4933a6385
Author: Gabriel Charette <gab@chromium.org>
Date: Sun Aug 05 21:54:26 2018

[TaskScheduler] Migrate one more include committed after mass migration

This is https://crrev.com/c/1161179 applied further up the tree
while trying to land https://crrev.com/c/1161088

TBR=skyostil@chromium.org

Bug:  867421 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I3d9830332e9c7331faa2576e92677274bfa06273
Reviewed-on: https://chromium-review.googlesource.com/1163285
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580786}
[modify] https://crrev.com/5d832c4d4182a51329c13aff4a97edb4933a6385/services/network/p2p/socket_manager.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04b138f9ce8567e0f2615f29f8c6252a5af77257

commit 04b138f9ce8567e0f2615f29f8c6252a5af77257
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Aug 06 00:03:22 2018

[TaskScheduler] Move impl to base/task/task_scheduler and public API to base/task

(and a few minor git-cl-formats-du-jour + spot fixes to make new
presubmit checks happy)

(and make thread_restrictions.h presubmits only warnings -- I've been
realizing that making migration presubmits error is a bit too aggressive
specifically because it hinders migrations like these and have been
dialing them down, this one was left behind)

This finalizes the structure for base/task as planned @
https://docs.google.com/document/d/1h-FlOeO-27g__JnuRvdJ8KG9G-bmG_zn6zuw7GerFkc/edit
which makes even more sense in a world where post_task.h and
task_traits.h may be used outside the TaskScheduler (ref.
 crbug.com/867421 ).

There is a low-activity time this week in base/task_scheduler per OOOs
so this is as good a time as ever to make this move (and it must happen
before eseckler's work to use TaskTraits outside TaskScheduler).

The move strategy outlined @
https://chromium-review.googlesource.com/c/chromium/src/+/1161179
makes this CL a simple file move from git's point of view without
requiring all users of public headers to be updated in the same large
CL

Also removed a per-file *task_scheduler* rule from base/test/OWNERS as
there are no such files anymore.

Bug:  867421 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I48b219b9f781deab606e2c6349bc03a0c5b701d8
Reviewed-on: https://chromium-review.googlesource.com/1161088
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580788}
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/PRESUBMIT.py
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/BUILD.gn
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/README.md
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/lazy_task_runner.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/lazy_task_runner.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/lazy_task_runner_forward.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/lazy_task_runner_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/post_task.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/post_task.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/post_task_forward.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/scoped_set_task_priority_for_current_thread.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/scoped_set_task_priority_for_current_thread.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/scoped_set_task_priority_for_current_thread_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/single_thread_task_runner_thread_mode.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/single_thread_task_runner_thread_mode_forward.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/can_schedule_sequence_observer.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/delayed_task_manager.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/delayed_task_manager.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/delayed_task_manager_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/environment_config.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/environment_config.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/initialization_util.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/initialization_util.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/initialization_util_forward.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/platform_native_worker_pool_win.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/platform_native_worker_pool_win.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/priority_queue.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/priority_queue.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/priority_queue_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_lock.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_lock_impl.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_lock_impl.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_lock_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_single_thread_task_runner_manager.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_observer.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_params.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool_impl.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool_impl.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool_impl_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool_params.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool_params.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_pool_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_stack.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_stack.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_stack_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/scheduler_worker_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/sequence.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/sequence.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/sequence_sort_key.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/sequence_sort_key.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/sequence_sort_key_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/sequence_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/service_thread.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/service_thread.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/service_thread_unittest.cc
[copy] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/single_thread_task_runner_thread_mode.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_scheduler.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_scheduler.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_scheduler_forward.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_scheduler_impl.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_scheduler_impl.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_scheduler_impl_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_tracker.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_tracker.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_tracker_posix.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_tracker_posix.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_tracker_posix_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_tracker_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/task_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/test_task_factory.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/test_task_factory.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/test_utils.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/test_utils.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/tracked_ref.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_scheduler/tracked_ref_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_traits.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_traits.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_traits_details.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_traits_forward.h
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_traits_unittest.cc
[rename] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task/task_traits_unittest.nc
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/task_scheduler/OWNERS
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/test/OWNERS
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/test/scoped_task_environment.cc
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/test/scoped_task_environment.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/threading/post_task_and_reply_impl.h
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/base/win/com_init_check_hook.cc
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/chrome/browser/resources/task_scheduler_internals/OWNERS
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/chrome/browser/ui/webui/task_scheduler_internals/OWNERS
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/docs/task_scheduler_migration.md
[modify] https://crrev.com/04b138f9ce8567e0f2615f29f8c6252a5af77257/docs/threading_and_tasks.md
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44db142be5a625609dc30805cb6eb24a985f05d3

commit 44db142be5a625609dc30805cb6eb24a985f05d3
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Aug 06 11:19:33 2018

[TaskScheduler] Remove temporary forwarding headers and mass migrate users

When this CL is approved I will rebase it on top of tree and mass
migrate all callers in a new patch set (TBR'ed change).

TBR=robliao@chromium.org (for mass migration of existing callers)

Bug:  867421 
Change-Id: I41092bbc4824964ee047e0bf53e972c8f6e896a4
Reviewed-on: https://chromium-review.googlesource.com/1161116
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580845}
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/aw_browser_terminator.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/aw_contents_io_thread_client.h
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/aw_form_database_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/net/android_stream_reader_url_request_job.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/android_webview/browser/tracing/aw_tracing_controller.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/apps/launcher.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/ash/assistant/assistant_screen_context_controller.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/ash/components/cursor/cursor_view.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/ash/display/display_color_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/ash/display/display_color_manager_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/BUILD.gn
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/debug/task_annotator_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/i18n/streaming_utf8_validator_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/observer_list_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/process/kill.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/process/kill_fuchsia.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/process/kill_posix.cc
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/lazy_task_runner_forward.h
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/post_task_forward.h
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/single_thread_task_runner_thread_mode_forward.h
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/task_scheduler/initialization_util_forward.h
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/task_scheduler/scheduler_worker_params_forward.h
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/task_scheduler/scheduler_worker_pool_params_forward.h
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/task_scheduler/task_scheduler_forward.h
[delete] https://crrev.com/ed784533f2ef5495f5c07892687412e5fbfb3001/base/task/task_traits_forward.h
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/test/scoped_task_environment.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/test/scoped_task_environment.h
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/test/scoped_task_environment_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/threading/sequenced_task_runner_handle_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/timer/hi_res_timer_manager_win.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/timer/timer_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/base/trace_event/trace_log.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/cc/tiles/image_controller.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/after_startup_task_utils_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/download/download_media_parser_bridge.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/history_report/delta_file_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/history_report/usage_reports_buffer_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/password_ui_view_android.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/thumbnail/thumbnail_cache.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/vr/mailbox_to_surface_bridge.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/background/background_mode_manager_mac.mm
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/background/background_mode_manager_win.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/bookmarks/bookmark_html_writer.h
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/browser_process_impl_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/browsing_data/site_data_size_collector.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/budget_service/budget_database.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chrome_browser_main_linux.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/app_mode/kiosk_app_data_base.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/app_mode/kiosk_app_icon_loader.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/fileapi/file_stream_forwarder.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/process/arc_process_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/base/file_flusher.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/base/locale_util.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/boot_times_recorder.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/camera_detector.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/crostini/crostini_registry_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/crostini/crostini_util.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/customization/customization_document.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/customization/customization_wallpaper_util.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/drive/fileapi/async_file_util.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/drive/write_on_cache_file.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/default_app_order.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/echo_private_api.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/external_cache_impl_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/install_limiter.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/external_metrics.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/file_manager/file_watcher.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/file_manager/file_watcher_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/file_manager/open_with_browser.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/file_manager/snapshot_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/first_run/goodies_displayer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/hats/hats_dialog.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/input_method/input_method_syncer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/logging.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/demo_mode/demo_extensions_external_loader.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/oobe_configuration.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/screens/reset_screen.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/startup_utils.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/mobile_config.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/net/client_cert_store_chromeos.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/platform_keys/platform_keys.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/app_install_event_log_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/app_install_event_logger.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/dm_token_storage.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/power/cpu_data_collector.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/power/process_data_collector.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/power/process_data_collector_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/printing/external_printers.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/printing/printer_info_cups.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/printing/printer_info_stub.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/printing/printers_sync_bridge.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/settings/session_manager_operation.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system/automatic_reboot_manager.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system_logs/command_line_log_source.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system_logs/debug_log_writer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system_logs/iwlwifi_dump_log_source.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/system_logs/touch_log_source.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/chromeos/tpm_firmware_update.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/component_patcher_operation_browsertest.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/crl_set_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/cros_component_installer_chromeos.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/mei_preload_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/optimization_hints_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/pnacl_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/sth_set_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/44db142be5a625609dc30805cb6eb24a985f05d3/chrome/browser/component_updater/widevine_cdm_component_installer
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f22e8b377c6260f032230a903e85bd5c96df4e

commit 97f22e8b377c6260f032230a903e85bd5c96df4e
Author: Eric Seckler <eseckler@chromium.org>
Date: Thu Aug 16 09:03:05 2018

[base] Make TaskTraits extensible by embedders.

Adds a fixed-size storage for extension data to base::TaskTraits.

By including extensions directly in this storage in TaskTraits, we support:
(1) constexpr-compatible construction of TaskTraits with or without extensions.
(2) opaquely passing extension traits for tasks to the TaskScheduler.

Base embedders such as content can provide implementations of the
MakeTaskTraitsExtension() function to support initializing their extension
traits through the base::TaskTraits() constructor.

Because of (2), the TaskScheduler may support prioritization or reprioritization
based on extension traits in the future. For example, content may want to tag
tasks executed by the TaskScheduler with different associated frame IDs and
prioritize those belonging to foreground tabs over those belonging to
background tabs.

This change adds about 4kB to the chrome binary's size on x64 linux when using
8 byte extension storage and about 12kB when using 32 byte storage.

Design doc:
https://docs.google.com/document/d/1SGy9VTXUwyXEX_yBZ0ukFAnS8B0hDeMUJD-1iALaE-Q/edit?usp=sharing

Bug:  867421 
Change-Id: I62c585d61590455f25ed7c817f818369a9a2f95c
Reviewed-on: https://chromium-review.googlesource.com/1169179
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583584}
[modify] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/BUILD.gn
[modify] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/task_traits.h
[modify] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/task_traits_details.h
[add] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/task_traits_extension.h
[add] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/task_traits_extension_unittest.cc
[add] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/task_traits_extension_unittest.nc
[modify] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/task_traits_unittest.nc
[add] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/test_task_traits_extension.cc
[add] https://crrev.com/97f22e8b377c6260f032230a903e85bd5c96df4e/base/task/test_task_traits_extension.h
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdd866d624b2aad6c0224eeb6b99183657458128

commit cdd866d624b2aad6c0224eeb6b99183657458128
Author: Eric Seckler <eseckler@chromium.org>
Date: Tue Aug 21 10:49:54 2018

base: Add TaskExecutors to support extension traits in post_task.h

Embedders can register a TaskExecutor to handle execution of Tasks
posted via the post_task.h API with specific extension TaskTraits.

The TaskScheduler becomes the default TaskExecutor.

Related patch introducing TaskTraits extensions:
https://chromium-review.googlesource.com/c/chromium/src/+/1169179
Design doc:
https://docs.google.com/document/d/1SGy9VTXUwyXEX_yBZ0ukFAnS8B0hDeMUJD-1iALaE-Q/edit?usp=sharing

TBR=pasko@chromium.org,primiano@chromium.org,imcheng@chromium.org,dominickn@chromium.org

Bug:  867421 
Change-Id: I4083848431cca17aab3b6a411170ea32e5503776
Reviewed-on: https://chromium-review.googlesource.com/1175829
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584709}
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/BUILD.gn
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/post_task.cc
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/post_task.h
[add] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/post_task_unittest.cc
[add] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/task_executor.cc
[add] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/task_executor.h
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/task_scheduler/task_scheduler.h
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/task_scheduler/task_scheduler_impl.cc
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/task_scheduler/task_scheduler_impl.h
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/task_traits.h
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/base/task/task_traits_extension.h
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/chrome/browser/ui/media_router/media_router_file_dialog.cc
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/chrome/browser/web_applications/components/web_app_shortcut.cc
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/content/browser/tracing/cast_tracing_agent.cc
[modify] https://crrev.com/cdd866d624b2aad6c0224eeb6b99183657458128/net/disk_cache/simple/simple_backend_impl.cc

Comment 9 by eseckler@chromium.org, Aug 28

Blocking: 878356
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e329cb9df7aa3132c0687d46db3a3ffb2c065aed

commit e329cb9df7aa3132c0687d46db3a3ffb2c065aed
Author: Eric Seckler <eseckler@chromium.org>
Date: Tue Aug 28 16:09:40 2018

content: Add a TaskTraits extension and TaskExecutor for BrowserThreads.

This allows using //base/task/post_task.h for posting tasks to a
BrowserThread by specifying a BrowserThread::ID as a task trait.

Also adds a content::NonNestable task trait to support non-nestable
tasks in base::PostTaskWithTraits.

In the future, we will add further traits to facilitate scheduling
tasks onto different SequenceManager queues on the UI thread, see:
https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit?usp=sharing

Bug:  867421 , 863341,  878356 
Change-Id: Id8b7bc2e374917ceb421c7f6139790e6f1457511
Reviewed-on: https://chromium-review.googlesource.com/1181364
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586728}
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/base/task/post_task_unittest.cc
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/base/task/task_traits_details.h
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/app/content_main_runner_impl.cc
[add] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/browser/browser_thread_browsertest.cc
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/browser/browser_thread_impl.h
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/browser/browser_thread_unittest.cc
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/public/browser/BUILD.gn
[add] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/public/browser/browser_task_traits.cc
[add] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/public/browser/browser_task_traits.h
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/public/browser/browser_thread.h
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/public/test/browser_test_base.cc
[modify] https://crrev.com/e329cb9df7aa3132c0687d46db3a3ffb2c065aed/content/test/BUILD.gn
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/315c5d821c90d430db1c4e1ab3212d7fd49f4eff

commit 315c5d821c90d430db1c4e1ab3212d7fd49f4eff
Author: Eric Seckler <eseckler@chromium.org>
Date: Wed Aug 29 10:15:59 2018

base/content: fix comments in browser_thread_impl.cc and task_traits_details.h

TBR=gab@chromium.org

Bug:  878356 ,  867421 
Change-Id: I6e79125e93207696a6df3165e4c5bc968b364e14
Reviewed-on: https://chromium-review.googlesource.com/1193931
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587060}
[modify] https://crrev.com/315c5d821c90d430db1c4e1ab3212d7fd49f4eff/base/task/task_traits_details.h
[modify] https://crrev.com/315c5d821c90d430db1c4e1ab3212d7fd49f4eff/content/browser/browser_thread_impl.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbfb6a1b7313a0987976f5db401a8bcaab27785f

commit dbfb6a1b7313a0987976f5db401a8bcaab27785f
Author: Eric Seckler <eseckler@chromium.org>
Date: Wed Aug 29 13:05:47 2018

ios: Add a TaskTraits extension and TaskExecutor for WebThreads.

This allows using //base/task/post_task.h for posting tasks to a
WebThread by specifying a WebThread::ID as a task trait.

Related patch for BrowserThreads: https://crrev.com/c/1181364

Bug:  867421 ,  878356 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic4a539eadc1fda199376c42afa44ba95e39e7041
Reviewed-on: https://chromium-review.googlesource.com/1188283
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587089}
[modify] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/BUILD.gn
[modify] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/app/web_main_runner.mm
[modify] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/public/BUILD.gn
[add] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/public/web_task_traits.cc
[add] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/public/web_task_traits.h
[modify] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/public/web_thread.h
[modify] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/test/test_web_thread_bundle.cc
[modify] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/web_thread_impl.cc
[modify] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/web_thread_impl.h
[add] https://crrev.com/dbfb6a1b7313a0987976f5db401a8bcaab27785f/ios/web/web_thread_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03d0d427b4f1713bcaf975d1586f4ad4be53bec5

commit 03d0d427b4f1713bcaf975d1586f4ad4be53bec5
Author: Eric Seckler <eseckler@chromium.org>
Date: Wed Aug 29 20:06:36 2018

content: Add a nocompile test for browser TaskTraits.

Also adds the generated output file directory as include directory to
nocompile build targets.

Bug:  878356 ,  867421 
Change-Id: I51a8433a1e5295949f67aaea188444f81c394100
Reviewed-on: https://chromium-review.googlesource.com/1194224
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587265}
[modify] https://crrev.com/03d0d427b4f1713bcaf975d1586f4ad4be53bec5/build/nocompile.gni
[add] https://crrev.com/03d0d427b4f1713bcaf975d1586f4ad4be53bec5/content/public/browser/browser_task_traits_unittest.nc
[modify] https://crrev.com/03d0d427b4f1713bcaf975d1586f4ad4be53bec5/content/test/BUILD.gn
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cf08db894b3d0360dc64e3c8e8156379f8a8f3f

commit 6cf08db894b3d0360dc64e3c8e8156379f8a8f3f
Author: Eric Seckler <eseckler@chromium.org>
Date: Thu Aug 30 12:01:55 2018

docs: Update threading_and_tasks.md for BrowserThread task traits.

Bug:  878356 ,  867421 
Change-Id: I0991a840a0787b6863bea79ee4079e5db7fdfe0b
Reviewed-on: https://chromium-review.googlesource.com/1194074
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587525}
[modify] https://crrev.com/6cf08db894b3d0360dc64e3c8e8156379f8a8f3f/docs/threading_and_tasks.md

Comment 15 by battre@chromium.org, Sep 11 

Eric, the nocompile test closed the tree twice recently for linux-jumbo-rel. Any idea?

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935703690365589744/+/steps/compile/0/stdout

[2088/2192] STAMP obj/chrome/installer/linux/calculate_deb_dependencies.stamp
[2089/2192] ACTION //chrome/installer/linux:merge_deb_dependencies(//build/toolchain/linux:clang_x64)
[2090/2192] STAMP obj/chrome/installer/linux/merge_deb_dependencies.stamp
[2091/2192] ACTION //content/test:content_nocompile_tests_run_nocompile(//build/toolchain/linux:clang_x64)
FAILED: gen/content/test/browser_task_traits_unittest_nc.cc 
python ../../tools/nocompile_driver.py 4 ../../content/public/browser/browser_task_traits_unittest.nc gen/content/test/browser_task_traits_unittest_nc.cc -- -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ -Igen --sysroot ../../build/linux/debian_sid_amd64-sysroot
[2092/2192] LINK ./sync_integration_tests
[2093/2192] ACTION //chrome/installer/linux:beta_rpm(//build/toolchain/linux:clang_x64)
[2094/2192] ACTION //chrome/installer/linux:stable_rpm(//build/toolchain/linux:clang_x64)
[2095/2192] ACTION //chrome/installer/linux:unstable_rpm(//build/toolchain/linux:clang_x64)
[2096/2192] LINK ./interactive_ui_tests
[2097/2192] ACTION //chrome/installer/linux:stable_deb(//build/toolchain/linux:clang_x64)
[2098/2192] ACTION //chrome/installer/linux:unstable_deb(//build/toolchain/linux:clang_x64)
[2099/2192] ACTION //chrome/installer/linux:beta_deb(//build/toolchain/linux:clang_x64)
[2100/2192] LINK ./browser_tests
ninja: build stopped: subcommand failed.
step returned non-zero exit code: 1
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/458f348d254d9ef92134566d04711a2c8167fa5e

commit 458f348d254d9ef92134566d04711a2c8167fa5e
Author: Eric Seckler <eseckler@chromium.org>
Date: Tue Sep 11 12:03:38 2018

ios: Add NonNestable TaskTrait

Turns out we'll need it afterall since some ios code
uses NonNestable tasks, e.g. indirectly via DeleteSoon.

Bug:  867421 ,  878356 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I77c0161b083c987f48b0f3270490e8feee241b18
Reviewed-on: https://chromium-review.googlesource.com/1216564
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590269}
[modify] https://crrev.com/458f348d254d9ef92134566d04711a2c8167fa5e/ios/web/public/web_task_traits.h
[modify] https://crrev.com/458f348d254d9ef92134566d04711a2c8167fa5e/ios/web/web_thread_impl.cc

Comment 17 by eseckler@chromium.org, Sep 11 

#15: I can't seem to repro this locally. Filed bug 882852 to ask for trooper help.
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/501f9a1d94bcee5d5339d8d89a977d41ae16fdea

commit 501f9a1d94bcee5d5339d8d89a977d41ae16fdea
Author: Eric Seckler <eseckler@chromium.org>
Date: Fri Sep 14 18:09:44 2018

content: Respect Nestable task trait in BrowserTaskExecutor

This accidentally disappeared in crrev.com/c/1224115 :)

Bug:  867421 
Change-Id: Ib77fc096ffd4bd98f134107180a020d9f829db7f
Reviewed-on: https://chromium-review.googlesource.com/1225763
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591395}
[modify] https://crrev.com/501f9a1d94bcee5d5339d8d89a977d41ae16fdea/content/browser/scheduler/browser_task_executor.cc
[modify] https://crrev.com/501f9a1d94bcee5d5339d8d89a977d41ae16fdea/content/browser/scheduler/browser_task_executor.h

Comment 19 by eseckler@chromium.org, Oct 1

Status: Fixed (was: Started)
►

Sign in to add a comment