New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867410 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CrSettingsPersonalizationOptionsTest.OfficialBuild is failing in official builds

Project Member Reported by thakis@chromium.org, Jul 25

Issue description

e.g. on https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1866

Several other tests have been broken in official builds for a while too, so we didn't notice when this test started failing. I see if I can find out.
 
Oh, stack:

[ RUN      ] CrSettingsPersonalizationOptionsTest.OfficialBuild
[5192:5348:0723/183706.896:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[5192:7120:0723/183706.911:WARNING:chrome_browser_main_win.cc(653)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=CrSettingsPersonalizationOptionsTest.OfficialBuild --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5760_30274\results5760_11054\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iorxaeq4\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5760_30274\d5760_9567" --disable-offline-auto-reload --enable-blink-features=MojoJSTest --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5192:7120:0723/183708.278:INFO:CONSOLE(1236)] "Running TestCase CrSettingsPersonalizationOptionsTest.OfficialBuild", source: file:///E:/b/s/w/ir/chrome/test/data/webui/test_api.js (1236)
[5192:7120:0723/183708.671:ERROR:CONSOLE(48)] "Mocha test failed: SafeBrowsingExtendedReportingOfficialBuild displaying toggles depending on unified consent
AssertionError: expected 7 to equal 8
    at Function.assert.strictEqual (file:///E:/b/s/w/ir/third_party/chaijs/chai.js:2277:32)
    at assertEquals (file:///E:/b/s/w/ir/chrome/test/data/webui/test_api.js:903:15)
    at Context.<anonymous> (file:///E:/b/s/w/ir/chrome/test/data/webui/settings/personalization_options_test.js:91:9)
", source: file:///E:/b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
[5192:7120:0723/183708.674:ERROR:web_ui_test_handler.cc(100)] Test Errors: 1/1 tests had failed assertions.
[5192:7120:0723/183708.674:ERROR:web_ui_browser_test.cc(481)] CONDITION FAILURE: encountered javascript console error(s):
[5192:7120:0723/183708.674:ERROR:web_ui_browser_test.cc(483)] JS ERROR: '[5192:7120:0723/183708.671:ERROR:CONSOLE(48)] "Mocha test failed: SafeBrowsingExtendedReportingOfficialBuild displaying toggles depending on unified consent
AssertionError: expected 7 to equal 8
    at Function.assert.strictEqual (file:///E:/b/s/w/ir/third_party/chaijs/chai.js:2277:32)
    at assertEquals (file:///E:/b/s/w/ir/chrome/test/data/webui/test_api.js:903:15)
    at Context.<anonymous> (file:///E:/b/s/w/ir/chrome/test/data/webui/settings/personalization_options_test.js:91:9)
", source: file:///E:/b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
'
[5192:7120:0723/183708.674:ERROR:web_ui_browser_test.cc(485)] JS call assumed failed, because JS console error(s) found.
Cc: tangltom@chromium.org
https://chromium.googlesource.com/chromium/src/+/bdcd67a824088e0230dfb5df3013568c2b8bd5f5 touched a file on the stack recently(ish)
Labels: -OS-Mac
Owner: tangltom@chromium.org
https://crrev.com/576434..577059 ...hmm that's not great UI for looking at 600 changes. `git log bfa99da25f790cd1deabebdb0694a199f5c8579d..691e33b194c53a46cc69b961efe24b8e8a66c479` -- my guess is that it's probably one of tangltom's changes in there:

$ git log --author=tangltom bfa99da25f790cd1deabebdb0694a199f5c8579d..691e33b194c53a46cc69b961efe24b8e8a66c479
commit 5ec4b213df2511faecb23e2983d55e56b05d4368
Author: Thomas Tangl <tangltom@chromium.org>
Date:   Fri Jul 20 12:46:12 2018 +0000

    [unified-consent] Enable spell-check when user opts into unified consent
    
    - When the user opts into unified consent, spell-check is enabled.
    - When the user signs out of Chrome, spell-check is disabled.
    
    Bug: 865370
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I436a90e1008fcef08168115256237179d6c6d14c
    Reviewed-on: https://chromium-review.googlesource.com/1143275
    Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
    Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#576838}

commit 7f3dd1cd0e36faee8eeb970d2fb2cd174411abed
Author: Thomas Tangl <tangltom@chromium.org>
Date:   Thu Jul 19 13:28:23 2018 +0000

    [unified-consent] Add missing settings strings
    
     - strings for the spell check hint are added
     - the autocomplete-searches description is updated
    
    Bug: 855945, 864793
    Change-Id: I33b520fbef30122e6add794d71d8f48053fc253c
    Reviewed-on: https://chromium-review.googlesource.com/1143304
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#576469}

commit 2f15bf14b06d724e789806ea40a7811859572bd3
Author: Thomas Tangl <tangltom@chromium.org>
Date:   Thu Jul 19 13:06:15 2018 +0000

    [unified-consent] Hide sync section when sync is paused
    
    When sync is paused, i.e. the user has an auth error,
    the sync section on the syncSetup page will be hidden.
    
    Bug: 864754
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ic72c9c02f0479feff27b73199a80702bfa7a5514
    Reviewed-on: https://chromium-review.googlesource.com/1141577
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#576460}

Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Status: Started (was: Untriaged)
I think it was this one: https://chromium-review.googlesource.com/c/chromium/src/+/1145315

Not from me, but I know how to fix it, so I'm working on it.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f10092d4c9c0108ec04e351871a468770883046e

commit f10092d4c9c0108ec04e351871a468770883046e
Author: Thomas Tangl <tangltom@chromium.org>
Date: Wed Jul 25 14:19:10 2018

Fix CrSettingsPersonalizationOptionsTest.OfficialBuild tests

The number of settings-toggle-button elements on the
personalization_options.html page changed with
https://chromium-review.googlesource.com/c/chromium/src/+/1145315.

This CL updates the test that checks this number.

Bug:  867410 
Change-Id: Ie4cca8a3305b1c8677a4e9a599ec531ff6fcab78
Reviewed-on: https://chromium-review.googlesource.com/1150157
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577879}
[modify] https://crrev.com/f10092d4c9c0108ec04e351871a468770883046e/chrome/test/data/webui/settings/personalization_options_test.js

Status: Fixed (was: Started)
Cc: gov...@chromium.org ajha@chromium.org
Labels: M-69
Status: Assigned (was: Fixed)
CrSettingsPersonalizationOptionsTest.OfficialBuild tests are still failing on official desktop continuous builder on Win and Linux.

Link to the builder:
====================
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/4526
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/4902

tangltom@: Would it be safe to merge the CL from C#7 to M-69 branch as well?

Labels: Merge-Request-69
Yes, this is a tiny change and should be safe to merge back to M69.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 16

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Approving mere to M69 branch 3497 based on comment #10. Please merge. Thank you.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 16

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ecef5598d6deece7ecc054b8205e96fe6cf6f42

commit 6ecef5598d6deece7ecc054b8205e96fe6cf6f42
Author: Thomas Tangl <tangltom@chromium.org>
Date: Thu Aug 16 14:43:25 2018

Fix CrSettingsPersonalizationOptionsTest.OfficialBuild tests

The number of settings-toggle-button elements on the
personalization_options.html page changed with
https://chromium-review.googlesource.com/c/chromium/src/+/1145315.

This CL updates the test that checks this number.

Bug:  867410 
Change-Id: Ie4cca8a3305b1c8677a4e9a599ec531ff6fcab78
Reviewed-on: https://chromium-review.googlesource.com/1150157
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577879}(cherry picked from commit f10092d4c9c0108ec04e351871a468770883046e)
Reviewed-on: https://chromium-review.googlesource.com/1177821
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#673}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/6ecef5598d6deece7ecc054b8205e96fe6cf6f42/chrome/test/data/webui/settings/personalization_options_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment