New issue
Advanced search Search tips

Issue 867409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make translate sites blacklist deletable by Clear Browsing Data deletion

Project Member Reported by dullweber@chromium.org, Jul 25

Issue description

Clear Browsing Data has an option to remove site settings, which deletes content settings, zoom settings, protocol handlers and webusb settings.

The translate sites blacklist is very similar, so it should be included as well.


 
Cc: yyushkina@chromium.org anthonyvd@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c009a39ec527359950360b4f04dd13ced3928131

commit c009a39ec527359950360b4f04dd13ced3928131
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Aug 31 12:41:43 2018

Allow deletion of entries from the translate site blacklist

The translate site blacklist contains urls that currently can't be
deleted with Clear Browsing Data. This blacklist is similar to a
content setting so it should be deleted with the Content Settings
option.
To allow deletion of blacklist entries by time, the List is migrated
to a Dictionary that maps sites to timestamps. To keep compatibility
with older syncing Chrome instances, the old list is kept for a few
releases.

Bug:  867409 

Change-Id: I046af82ba133d209c119f9d44423d02b3a1c499c
Reviewed-on: https://chromium-review.googlesource.com/1150141
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588000}
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/browsing_data/counters/site_settings_counter.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/browsing_data/counters/site_settings_counter.h
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/browsing_data/counters/site_settings_counter_unittest.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/c009a39ec527359950360b4f04dd13ced3928131/components/translate/core/browser/translate_prefs_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment