Issue metadata
Sign in to add a comment
|
Blend Rendering Issue in Chrome
Reported by
kvaishak...@gmail.com,
Jul 25
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36 Steps to reproduce the problem: 1. Create an svg shape. 2. change its blend type to something using DOM. 3. Change the blend type once again. What is the expected behavior? The blend should have been rendered properly. What went wrong? The blend is getting rendered in the first change, but after that the blend is not getting rendered. Only after the blend type is again changed to NORMAL, it can be changed. Did this work before? Yes Does this work in other browsers? Yes Chrome version: 67.0.3396.99 Channel: n/a OS Version: OS X 10.13.6 Flash Version: Checked it with the beta build number -> [Version 68.0.3440.68 (Official Build) beta (64-bit)] NOT WORKING
,
Jul 25
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec6c21fbfe8bcf7824984b5076ec1d8b95188102 commit ec6c21fbfe8bcf7824984b5076ec1d8b95188102 Author: Vladimir Levin <vmpstr@chromium.org> Date: Wed Jul 25 23:53:01 2018 Make sure to rebuild prop tree state in blend mode change. This patch ensures that if we've changed mix-blend-mode property, then we call SetNeedsPropertyTreeUpdate. R=pdr@chromium.org Bug: 867403 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idcd6e54c1d6ca3db0d0e088038cc144def2789b8 Reviewed-on: https://chromium-review.googlesource.com/1150687 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578133} [modify] https://crrev.com/ec6c21fbfe8bcf7824984b5076ec1d8b95188102/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/ec6c21fbfe8bcf7824984b5076ec1d8b95188102/third_party/blink/renderer/core/paint/paint_property_tree_update_tests.cc [modify] https://crrev.com/ec6c21fbfe8bcf7824984b5076ec1d8b95188102/third_party/blink/renderer/core/style/computed_style.cc [modify] https://crrev.com/ec6c21fbfe8bcf7824984b5076ec1d8b95188102/third_party/blink/renderer/core/style/style_difference.cc [modify] https://crrev.com/ec6c21fbfe8bcf7824984b5076ec1d8b95188102/third_party/blink/renderer/core/style/style_difference.h [modify] https://crrev.com/ec6c21fbfe8bcf7824984b5076ec1d8b95188102/third_party/blink/renderer/core/style/style_difference_test.cc
,
Jul 26
,
Jul 26
I'm going to wait a few days to ensure this doesn't regress anything in Canary and then request a merge.
,
Jul 26
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 27
The NextAction date has arrived: 2018-07-27
,
Jul 27
How is the change looking in canary?
,
Jul 27
,
Jul 27
Looking good. Requesting merge.
,
Jul 28
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 29
Please merge your change to M69 branch 3497 by 2:00 PM PT Monday, 07/30, so we can pick it up for next week last M69 Dev release. Thank you.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6 commit 1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6 Author: Vladimir Levin <vmpstr@chromium.org> Date: Mon Jul 30 19:53:22 2018 Make sure to rebuild prop tree state in blend mode change. This patch ensures that if we've changed mix-blend-mode property, then we call SetNeedsPropertyTreeUpdate. R=pdr@chromium.org TBR=vmpstr@chromium.org (cherry picked from commit ec6c21fbfe8bcf7824984b5076ec1d8b95188102) Bug: 867403 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idcd6e54c1d6ca3db0d0e088038cc144def2789b8 Reviewed-on: https://chromium-review.googlesource.com/1150687 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578133} Reviewed-on: https://chromium-review.googlesource.com/1155635 Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#236} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6/third_party/blink/renderer/core/paint/paint_property_tree_update_tests.cc [modify] https://crrev.com/1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6/third_party/blink/renderer/core/style/computed_style.cc [modify] https://crrev.com/1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6/third_party/blink/renderer/core/style/style_difference.cc [modify] https://crrev.com/1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6/third_party/blink/renderer/core/style/style_difference.h [modify] https://crrev.com/1ffacf542e2d1a4e14f38d2f36bbd27ffed22db6/third_party/blink/renderer/core/style/style_difference_test.cc
,
Jul 30
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by schenney@chromium.org
, Jul 25Owner: vmp...@chromium.org
Status: Assigned (was: Unconfirmed)