New issue
Advanced search Search tips

Issue 867388 link

Starred by 1 user
Status: WontFix
Owner:
msarda@chromium.org
Closed: Jul 27
Cc:
bcwh...@chromium.org
ew...@chromium.org
msarda@chromium.org
tangltom@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 849831



Sign in to add a comment

[Unity] Adapt URL-keyed data collection consent helper fro UKM usage

Project Member Reported by msarda@chromium.org, Jul 25 
In order for this API to be used by the UKM implementation, we need to add the following to the API:
* add information about the underlying sync service being shut down.
* allow client of the API to pass a client-side state as a void pointer
* expose a reason why URL-keyed data collection consent helper is disabled
* enhanced the API to support extensions (desired API would be IsEnabled() + IsEnabledWithExtensions() or IsEnabledWithOption(Helper::kExtensionOption)).
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfc33b7c48a995c13ddd3bc56a2c146abb773226

commit bfc33b7c48a995c13ddd3bc56a2c146abb773226
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Thu Jul 26 08:47:00 2018

[unified-consent] Add shutdown information for the UrlKeyedDataCollectionConsentHelper.

This CL adds methods that handle the shutdown state for the
UrlKeyedDataCollectionConsentHelper. This is set when the dependent sync
service is shut down.

Bug:  867388 

Change-Id: Id6f948bc0aa1a55ec2943590a5f77cd179b65e3f
Reviewed-on: https://chromium-review.googlesource.com/1148564
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578242}
[modify] https://crrev.com/bfc33b7c48a995c13ddd3bc56a2c146abb773226/components/unified_consent/url_keyed_data_collection_consent_helper.cc
[modify] https://crrev.com/bfc33b7c48a995c13ddd3bc56a2c146abb773226/components/unified_consent/url_keyed_data_collection_consent_helper.h
[modify] https://crrev.com/bfc33b7c48a995c13ddd3bc56a2c146abb773226/components/unified_consent/url_keyed_data_collection_consent_helper_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ed9cbbece4e8c5f94201e13f81d8ce351744110

commit 6ed9cbbece4e8c5f94201e13f81d8ce351744110
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Fri Jul 27 11:33:33 2018

Revert "[unified-consent] Add shutdown information for the UrlKeyedDataCollectionConsentHelper."

This reverts commit bfc33b7c48a995c13ddd3bc56a2c146abb773226.

Reason for revert: The work for UKM is done in a separate CL, so this is no longer needed.

Original change's description:
> [unified-consent] Add shutdown information for the UrlKeyedDataCollectionConsentHelper.
> 
> This CL adds methods that handle the shutdown state for the
> UrlKeyedDataCollectionConsentHelper. This is set when the dependent sync
> service is shut down.
> 
> Bug:  867388 
> 
> Change-Id: Id6f948bc0aa1a55ec2943590a5f77cd179b65e3f
> Reviewed-on: https://chromium-review.googlesource.com/1148564
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578242}

TBR=msarda@chromium.org,bcwhite@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  867388 
Change-Id: If3978f977afcb9ea1997bdde1b7220f56a271bbb
Reviewed-on: https://chromium-review.googlesource.com/1152847
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578598}
[modify] https://crrev.com/6ed9cbbece4e8c5f94201e13f81d8ce351744110/components/unified_consent/url_keyed_data_collection_consent_helper.cc
[modify] https://crrev.com/6ed9cbbece4e8c5f94201e13f81d8ce351744110/components/unified_consent/url_keyed_data_collection_consent_helper.h
[modify] https://crrev.com/6ed9cbbece4e8c5f94201e13f81d8ce351744110/components/unified_consent/url_keyed_data_collection_consent_helper_unittest.cc

Comment 3 by msarda@chromium.org, Jul 27

Status: WontFix (was: Assigned)
►

Sign in to add a comment