New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867383 link

Starred by 1 user
Status: Verified
Owner:
coconutruben@chromium.org
Closed: Dec 25
Cc:
█ ravisadineni@chromium.org
mqg@chromium.org
█ seankao@google.com
tbroch@chromium.org
puthik@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 806146



Sign in to add a comment

[servo] expand measure_power to support avg_ppvar if available

Project Member Reported by coconutruben@chromium.org, Jul 25 
The measure_power module introduced at crrev.com/c/1131034 would strongly benefit from supporting the avg_ppvar ec vbat command if it is available.

This is not as simple as swapping out the command, because avg_ppvar keeps a one minute running average. So the first sample includes a lot of data from before the first sample is taken. If a user for instance puts the device into suspend & shortly thereafter collects data, the mean will be elevated and the first data-point from the EC misleading.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/db4e48142be7498a812a8ffc23654ff1566d5fb1

commit db4e48142be7498a812a8ffc23654ff1566d5fb1
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Mon Oct 29 18:21:37 2018

servod: use avg_ppvar in measure_power.py

This change leverages avg_ppvar in the measure_power script.
It does so by ensuring that the ECPowerTracker always runs the first
sample with normal ppvar_vbat_mw (to not get the baggage of the previous
minute) and then switches to avg_ppvar_vbat_mw if that is available on
the DUT's EC image.

BUG=chromium:806146,  chromium:867383 
TEST=manual testing
dut-control -t 130 on a dut with avg_ppvar enabled.

Change-Id: I6abf4aebd0eea236fc42878c89c852990e939281
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1229535
Reviewed-by: Mengqi Guo <mqg@chromium.org>

[modify] https://crrev.com/db4e48142be7498a812a8ffc23654ff1566d5fb1/servo/measure_power.py

Comment 2 by tbroch@google.com, Dec 21

Owner: coconutruben@chromium.org
Status: Started (was: Available)
Anything else you wanted to add here Ruben?

Comment 3 by coconutruben@chromium.org, Dec 25

Status: Verified (was: Started)
Nope, you're right this should work now :)
►

Sign in to add a comment