New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867377 link

Starred by 1 user
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jul 27
Cc:
xiaoche...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Red Underline is seen for entered text in 'chrome://settings/autofill'.

Reported by pranjali...@etouch.net, Jul 25 
Chrome version :69.0.3497.12 (Official Build)  e8e14b69c41a5a461c15fa5d1065ec28c49890ac-refs/branch-heads/3497@{#54}(32/64-bit) 

OS: Windows (7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.6,10.14) and Linux(14.04  LTS)OS

What steps will reproduce the problem?
1.Launch chrome and navigate to 'chrome://settings/autofill'.
2. Now click on 'Add' button and enter text(eg. india) in 'Street address' textbox.
3. Observe.

Actual  : Red Underline is seen for entered text in 'chrome://settings/autofill'.
Expected: Red Underline should not be seen for entered text in 'chrome://settings/autofill'.

This is a regression issue broken in ‘M-68’ and below is bisect info.
Good build: 68.0.3401.0 
Bad build: 68.0.3402.0 

You are probably looking for a change made after 552269 (known good), but no later than 552270 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/527433a7047fd56a0db0189a80a422087a1ab951..8712023f7d10238966ed56d02d27f10e02c8c394

Suspect: https://chromium.googlesource.com/chromium/src/+/8712023f7d10238966ed56d02d27f10e02c8c394

@xiaochengh: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You
Actual Result.mp4
221 KB View Download
Expected Result.mp4
230 KB View Download

Comment 1 by xiaoche...@chromium.org, Jul 25

Cc: xiaoche...@chromium.org
Owner: dpa...@chromium.org
This is expected, since "india" is a misspelling. We fixed some spellcheck completeness issue in M68, so we'll see more spellchecking done.

Unless we don't want the street address to be spellchecked?

dpapad@: Could you check if we want spellchecking on those <input> elements, and add spellcheck="false" if not? Thanks!

Comment 2 by dpa...@chromium.org, Jul 25

Owner: scottchen@chromium.org
Redirecting to scottchen@. I don't think we should be spellchecking street addresses, WDYT?

Comment 3 Deleted

Comment 4 by scottchen@chromium.org, Jul 25

Status: Started (was: stra)
dpapad@ That's fair
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5266def5ec61784711a47d135a0d67a15c6bb41c

commit 5266def5ec61784711a47d135a0d67a15c6bb41c
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Jul 25 21:52:06 2018

Settings: turn off spellcheck for addresses and names

Bug:  867377 
Change-Id: If20d80c069a4eb28769adce9e13731fbc8bb65af
Reviewed-on: https://chromium-review.googlesource.com/1150500
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578083}
[modify] https://crrev.com/5266def5ec61784711a47d135a0d67a15c6bb41c/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/5266def5ec61784711a47d135a0d67a15c6bb41c/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html

Comment 6 by pranjali...@etouch.net, Jul 26

Labels: TE-Verified-M70 TE-Verified-70.0.3503.0
Update:

Rechecked the above issue on Windows (7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.6,10.14) and Linux(14.04  LTS)OS using latest canary build #70.0.3503.0 and issue is fixed.

Please refer attached screencast for reference.

Thank You...
Canary Behaviour.mp4
247 KB View Download

Comment 7 by scottchen@chromium.org, Jul 27

Status: Fixed (was: Started)
►

Sign in to add a comment