New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867373 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3: The filter output is not correctly computed when the AGC gain changes are compensated

Project Member Reported by peah@chromium.org, Jul 25

Issue description

When the AGC analog gain changes, the echo is incorrectly estimated. In some cases, this could lead to hugely overestimated echoes and to avoid that the filter is adjusted to handle that.

The current implementation of that adjustment incorrectly scales the output of the echo subtractor which may lead to echo leakage when the analog gain changes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/7f5175a4552db9af5cb5f15d307c5c0c690cf8f9

commit 7f5175a4552db9af5cb5f15d307c5c0c690cf8f9
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Jul 25 15:00:33 2018

AEC3: Corrected the filter adjustment during analog gain changes

This CL corrects the way that the echo subtractor output is
adjusted during the adjustment of the adaptive filter when the
analog AGC gain changes.

The CL also ensures that the main adaptive filter is not updated
when this occurs.

Bug:  webrtc:9561 , chromium:867373 
Change-Id: I636f936128f7d9f0d82ca4140b59f148eb35d6a4
Reviewed-on: https://webrtc-review.googlesource.com/90401
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24101}
[modify] https://crrev.com/7f5175a4552db9af5cb5f15d307c5c0c690cf8f9/modules/audio_processing/aec3/subtractor.cc
[modify] https://crrev.com/7f5175a4552db9af5cb5f15d307c5c0c690cf8f9/modules/audio_processing/aec3/subtractor_output.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e5e6c679092ab16f7753b5c98056cd1bd4e97b

commit 81e5e6c679092ab16f7753b5c98056cd1bd4e97b
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 25 17:51:46 2018

Roll src/third_party/webrtc e71d1bb7fc22..7f5175a4552d (4 commits)

https://webrtc.googlesource.com/src.git/+log/e71d1bb7fc22..7f5175a4552d


git log e71d1bb7fc22..7f5175a4552d --date=short --no-merges --format='%ad %ae %s'
2018-07-25 peah@webrtc.org AEC3: Corrected the filter adjustment during analog gain changes
2018-07-25 nisse@webrtc.org Delete root header file typedef.h.
2018-07-25 titovartem@webrtc.org Move sigslot to proper third_party directory
2018-07-25 buildbot@webrtc.org Roll chromium_revision deb63e97f1..f2569c5796 (577752:577860)


Created with:
  gclient setdep -r src/third_party/webrtc@7f5175a4552d

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG= chromium:867373 ,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic9e3aaf5ed93f9a14cea51a76a0a6658e859d3a2
Reviewed-on: https://chromium-review.googlesource.com/1150300
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577970}
[modify] https://crrev.com/81e5e6c679092ab16f7753b5c98056cd1bd4e97b/DEPS

Cc: gustaf@chromium.org hlundin@chromium.org
Labels: Merge-Request-69
We would like to merge this issue into M69, as two other issues (listed below) for which we have asked for merge requests rely on this issue.

It has been tested in Chrome Canary and both the manual testing results and the metrics look good.
The merge is considered to be very safe, as the feature is only active beneath an experiment flag, and also has a specific kill-switch.

The CL that would be part of the merge is
-https://webrtc-review.googlesource.com/90401

The two other issues that are dependent on this merge are
-https://bugs.chromium.org/p/chromium/issues/detail?id=867873
-https://bugs.chromium.org/p/chromium/issues/detail?id=869329
and we have also asked for merges of those.

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 30

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #3. Please merge ASAP. Thank you.
This issue has been merged to M69.

The merging CL was
-https://webrtc-review.googlesource.com/c/src/+/91260
Labels: Merge-Merged
Labels: -Merge-Merged -Merge-Approved-69 Merge-Merged-69
Removing "Merge-Approved-69" label per comment #6.
Labels: M-69
Status: Fixed (was: Started)

Sign in to add a comment