New issue
Advanced search Search tips

Issue 867361 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Support out-fences for asynchronous swap buffer operations

Reported by alexandr...@collabora.com, Jul 25

Issue description

We currently support in-fences when scheduling overlays for display, but we don't have a mechanism to create and wire back out-fences on systems that support them. Utilizing out-fences could improve efficiency and potentially reduce the number of buffers we need to allocate.
 
Components: Internals>GPU
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11

commit bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11
Author: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Wed Jul 25 20:50:06 2018

gl: Add out-fence to GLSurface swap completion callback

Add an out-fence parameter to the swap completion callback used by the
the GLSurface async methods. If present, the fence will be signaled when
the swap has completed.

This commit doesn't implement the actual mechanism for the callback in
any Ozone backend, it just updates the GLSurface API.

Bug: 867361
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1a853e8e21cd636802e978ca6cdcb429b39e8141
Reviewed-on: https://chromium-review.googlesource.com/1127953
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578051}
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/gpu/ipc/service/pass_through_image_transport_surface.cc
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/gpu/ipc/service/pass_through_image_transport_surface.h
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/gl/gl_surface.h
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/gl_renderer.cc
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/gl_renderer.h
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/skia/skia_gl_renderer.cc
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/skia/skia_gl_renderer.h
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/skia/skia_surfaceless_gl_renderer.h
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/surfaceless_gl_renderer.cc
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/demo/surfaceless_gl_renderer.h
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/platform/drm/gpu/gbm_surface.cc
[modify] https://crrev.com/bd6ad56b4f186dc9db574c3d4ef3bd572ea3cd11/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc

Owner: dcasta...@chromium.org
Status: Assigned (was: Unconfirmed)
dcastagna: is this fixed?
It is not fixed yet, we're still working on this.

Sign in to add a comment