New issue
Advanced search Search tips

Issue 867347 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 812168



Sign in to add a comment

Create a mojo interface for code cache instead of going through render message filter.

Project Member Reported by mythria@chromium.org, Jul 25

Issue description

Currently code cache requests go through RenderMessageFilter. It is better to have its own Mojo interface and register with RenderProcessHost directly. This way we could also avoid RenderMessageFilter directly holding on to a raw pointer.
 
Blocking: 812168
Cc: kinuko@chromium.org mythria@chromium.org
Owner: bbudge@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c1dc1adac822876737560433c50233d58d005f

commit 24c1dc1adac822876737560433c50233d58d005f
Author: Bill Budge <bbudge@chromium.org>
Date: Tue Sep 25 18:51:32 2018

[caching] Add Mojo API for caching metadata on resources

- Moves metadata caching messages from RenderMessageFilter to a new
  Mojo API.
- Adds CodeCacheHostImpl to implement the messages in the browser
  process.

Bug:  chromium:867347 
Change-Id: If8b0181a501ead11a5e0adbeef162b263b3f6ac0
Reviewed-on: https://chromium-review.googlesource.com/1217885
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594027}
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/browser/BUILD.gn
[add] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/browser/renderer_host/code_cache_host_impl.cc
[add] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/browser/renderer_host/code_cache_host_impl.h
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/common/render_message_filter.mojom
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/public/test/mock_render_thread.cc
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/24c1dc1adac822876737560433c50233d58d005f/third_party/blink/public/mojom/loader/code_cache.mojom

Status: Fixed (was: Started)

Sign in to add a comment