tast.graphics.Screenshot fails on samus because color difference is large |
|||
Issue descriptiontast.graphics.Screenshot shows a page filled with #cc8844 (orange) in a maximized window, takes a screenshot as a PNG image, and ensures the screenshot contains right pixels. It is failing consistently on samus. https://stainless.corp.google.com/search?exclude_cts=true&exclude_non_release=true&board=%5Esamus%24&test=%5Etast%5C.graphics%5C.Screenshot%24&view=matrix&col=build&row=board_model&first_date=2018-07-19&last_date=2018-07-25 I inspected a saved screenshot and found that the pixels are #d49354. We need to update the test to allow this difference.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/dbcc2e955937d6f09eb86c0a97d06bf0ae041596 commit dbcc2e955937d6f09eb86c0a97d06bf0ae041596 Author: Shuhei Takahashi <nya@chromium.org> Date: Thu Jul 26 11:07:32 2018 graphics: Increase color difference threshold. On samus, #cc8844 pixels are shown as #d49354. BUG= chromium:867345 TEST=tast run samus-DUT graphics.Screenshot Change-Id: Id61e6acb0cea6bcb274cc967e36231c6c185886e Reviewed-on: https://chromium-review.googlesource.com/1149766 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/dbcc2e955937d6f09eb86c0a97d06bf0ae041596/src/chromiumos/tast/local/bundles/cros/graphics/screenshot.go
,
Jul 27
Marking as fixed, but graphics folks may want to file another bug to investigate the cause of large difference.
,
Jul 27
So you made the test passing, but at the same time there is still a failure? I am not sure what good that is.
,
Jul 27
IIUC, remaining failures are: 1. crbug.com/865853 : Disable graphics tests on devices without display 2. b/111620036: Make screenshot tool work on all models I'll work on (1), but I'm looking for someone who kindly volunteer to take (2). It's too graphics-heavy for me :(
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/c60cc2a58b9a6ff923bd713e8367465fd11cba5f commit c60cc2a58b9a6ff923bd713e8367465fd11cba5f Author: Shuhei Takahashi <nya@chromium.org> Date: Wed Aug 08 11:29:17 2018 graphics: Increase color difference threshold. On sumo, #cc8844 pixels are shown as #ba8b4a. Also improves logging to help diagnosing failures more easily. BUG= chromium:867345 TEST=None Change-Id: I31ac54e87a92ea6bb1a3bd8885c268aca498d7e9 Reviewed-on: https://chromium-review.googlesource.com/1166280 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/c60cc2a58b9a6ff923bd713e8367465fd11cba5f/src/chromiumos/tast/local/bundles/cros/graphics/screenshot.go
,
Sep 11
I'm adding screenshot tests for Crostini now and am also looking to understand why we have differences in pixels colors.
,
Sep 11
To answer #1, this difference is indeed expected. We implement proper color correction which means that the software is compensating for the panel's color characteristics. So depending on the panel in use, we don't necessarily output the same values. |
|||
►
Sign in to add a comment |
|||
Comment 1 by nya@chromium.org
, Jul 25