New issue
Advanced search Search tips

Issue 867334 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 801985



Sign in to add a comment

Move logic for recieving the oauth token to PerUserTopicregistrationManger

Project Member Reported by melandory@chromium.org, Jul 25

Issue description

Currently, the token is received in FcmInvalidationService and passed though FcnInvalidatorNotifier -> FcmSyncInvalidationListener to PerUserTopicregistrationManger.

Instead PerUserTopicRegistrationManager should handle the oauth token
 
Blockedon: -801985
Blocking: 801985
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745

commit 9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745
Author: Tanja Gornak <melandory@chromium.org>
Date: Mon Aug 20 09:24:54 2018

Move Oauth token routine to the registraion manager.

Bug:  867334 , 801985
Change-Id: I306bb35f1788acdfd83b772c428fd718ee13b61a
Reviewed-on: https://chromium-review.googlesource.com/1154983
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584387}
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/fcm_invalidation_service.cc
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/fcm_invalidation_service.h
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/fcm_invalidator.cc
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/fcm_invalidator.h
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/fcm_invalidator_unittest.cc
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/fcm_sync_invalidation_listener.cc
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/fcm_sync_invalidation_listener_unittest.cc
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/per_user_topic_registration_manager.cc
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/per_user_topic_registration_manager.h
[modify] https://crrev.com/9de4b0bec5e87d202e79a3cf8df4eaf7f1cae745/components/invalidation/impl/per_user_topic_registration_manager_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment