New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867314 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in SkOpAngle::lastMarked

Project Member Reported by ClusterFuzz, Jul 25

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6404916701298688

Fuzzer: libFuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkOpAngle::lastMarked
  SkOpSegment::findNextOp
  bridgeOp
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=577670:577675

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6404916701298688

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 25

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 25

Cc: carycl...@skia.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

handle failing pathop tests by caryclark@skia.org - https://skia.googlesource.com/skia/+/2587f41f2667b2add97f75583b71ebb74bc48af1

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Please assign to caryclark@google.com. As caryclark@skia.org, I cannot download the testcase or modify who this bug other than add this comment.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 25

Labels: M-69 Target-69
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 25

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 25

Labels: Pri-1
Owner: caryclark@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/b64db38b854bd8f6d564b7741ebf4795d130d168

commit b64db38b854bd8f6d564b7741ebf4795d130d168
Author: Cary Clark <caryclark@skia.org>
Date: Thu Jul 26 12:04:17 2018

avoid uninitialized under fuzzer

https://skia-review.googlesource.com/143112
introduced new logic to handle failures;
fuzzer found a way to exploit this.

FWIW, skia's fuzzer did not call pathops when
fed the test case.

TBR=kjlubick@google.com

Bug:867314
Change-Id: Id894962d3f32e206362faff332a1330db75da175
Reviewed-on: https://skia-review.googlesource.com/143318
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>

[modify] https://crrev.com/b64db38b854bd8f6d564b7741ebf4795d130d168/src/pathops/SkOpSegment.cpp

Project Member

Comment 9 by sheriffbot@chromium.org, Jul 26

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b709d48327c4af17ba3c31df66465f6f0f00b1d6

commit b709d48327c4af17ba3c31df66465f6f0f00b1d6
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jul 26 16:25:01 2018

Roll src/third_party/skia f3ac64df1741..b5093bc9ede3 (3 commits)

https://skia.googlesource.com/skia.git/+log/f3ac64df1741..b5093bc9ede3


git log f3ac64df1741..b5093bc9ede3 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 benjaminwagner@google.com [infra] Add Metal to no_upload.
2018-07-26 robertphillips@google.com Maybe fix numStencilBits TSAN crash
2018-07-26 caryclark@skia.org avoid uninitialized under fuzzer


Created with:
  gclient setdep -r src/third_party/skia@b5093bc9ede3

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:867314 
TBR=benjaminwagner@chromium.org

Change-Id: I8b846218bf68424526b235de8dc3e9c415b76257
Reviewed-on: https://chromium-review.googlesource.com/1151212
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578331}
[modify] https://crrev.com/b709d48327c4af17ba3c31df66465f6f0f00b1d6/DEPS

Status: Fixed (was: Assigned)
Project Member

Comment 12 by ClusterFuzz, Jul 27

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4561419270619136 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by ClusterFuzz, Jul 27

ClusterFuzz has detected this issue as fixed in range 578322:578337.

Detailed report: https://clusterfuzz.com/testcase?key=6404916701298688

Fuzzer: libFuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkOpAngle::lastMarked
  SkOpSegment::findNextOp
  bridgeOp
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=577670:577675
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=578322:578337

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6404916701298688

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 27

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, Nov 2

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment