Fullscreen exit UI should not be enabled when --kiosk is passed to chromium
Reported by
e...@mappedin.ca,
Jul 25
|
||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.75 Safari/537.36 Steps to reproduce the problem: 1. launch chromium with the --kiosk flag 2. visit any web page and hover the mouse over to the top of the page 3. and X is displayed to allow you to exit the fullscreen mode What is the expected behavior? in Kiosk mode, an end user should NOT be allowed to exit the fullscreen mode, meaning the exit UI should not be displayed if --kiosk flag is passed to chromium. What went wrong? Kiosk vendors such as ourselves rely on the --kiosk flag to put chrome in fullscreen mode. No end user should be allowed to break out of that mode. This change here got rolled out in chrome 68 and introduced this behavior: https://chromium.googlesource.com/chromium/src/+/1c11fb9422a010ad886651d012a23dba95cb2420 Did this work before? Yes 67 Chrome version: 68.0.3440.75 Channel: stable OS Version: 10.0 Flash Version:
,
Jul 25
yuweih@, can you please comment what's the impact on M68 stable?
,
Jul 25
TBH I'm not sure how much impact it has on M68 stable as I don't know how many users are using kiosk mode (could someone working on kiosk mode comment on this). The bug here will basically allow anyone exit fullscreen using the new UI. The fix is straightforward but it will not be rolled out until the next M68 respin. If we really need an urgent fix then we may just turn off the feature flag until the binary gets fixed..
,
Jul 25
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4f687119ad07acd730cc624cec0b603e04338b7 commit f4f687119ad07acd730cc624cec0b603e04338b7 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Jul 25 20:30:04 2018 Disable fullscreen exit UI when kiosk mode is on User should not be able to use the fullscreen exit UI to exit kiosk mode. This CL disables the UI when kiosk mode is on. Bug: 867309 Change-Id: Id823d7ec27d416495893170329e2d9c5776efd88 Reviewed-on: https://chromium-review.googlesource.com/1150607 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#578040} [modify] https://crrev.com/f4f687119ad07acd730cc624cec0b603e04338b7/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
,
Jul 26
Able to reproduce this issue on Windows 10 on the reported version 68.0.3440.75 and the issue is fixed on the latest Canary 70.0.3503.0 as per the original comment. The X is not displayed when Chrome is launched with the --kiosk flag. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Jul 26
How safe is this merge overall? Seems like this was tested in Canary. If it looks good and is safe, can you request a merge?
,
Jul 26
Request a merge to both M68 and M69 please.
,
Jul 26
,
Jul 26
This is just a simple change in the logic determining whether the fullscreen exit UI should be shown, so I think it's fairly safe.
,
Jul 26
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26
,
Jul 26
Merge approved for M69. Discuss merge with M68 w/ bhthompson@
,
Jul 26
CC'd bhthompson@
,
Jul 26
Issue 868051 has been merged into this issue.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef3cfeff0e81f9bb4c342e396a33f04bdd9b4f32 commit ef3cfeff0e81f9bb4c342e396a33f04bdd9b4f32 Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Jul 26 21:31:34 2018 Disable fullscreen exit UI when kiosk mode is on User should not be able to use the fullscreen exit UI to exit kiosk mode. This CL disables the UI when kiosk mode is on. Bug: 867309 Change-Id: Id823d7ec27d416495893170329e2d9c5776efd88 Reviewed-on: https://chromium-review.googlesource.com/1150607 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578040}(cherry picked from commit f4f687119ad07acd730cc624cec0b603e04338b7) Reviewed-on: https://chromium-review.googlesource.com/1151918 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#128} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/ef3cfeff0e81f9bb4c342e396a33f04bdd9b4f32/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
,
Jul 27
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79eb8cdf7867d4364bd2b1c579272b7a7d515765 commit 79eb8cdf7867d4364bd2b1c579272b7a7d515765 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Jul 27 00:09:05 2018 Disable fullscreen exit UI when kiosk mode is on User should not be able to use the fullscreen exit UI to exit kiosk mode. This CL disables the UI when kiosk mode is on. Bug: 867309 Change-Id: Id823d7ec27d416495893170329e2d9c5776efd88 Reviewed-on: https://chromium-review.googlesource.com/1150607 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578040}(cherry picked from commit f4f687119ad07acd730cc624cec0b603e04338b7) Reviewed-on: https://chromium-review.googlesource.com/1152310 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#757} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/79eb8cdf7867d4364bd2b1c579272b7a7d515765/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
,
Jul 27
,
Jul 27
bhthompson@ are you ok with the merge to M68 for this? I didn't see Merge-Approved-68.
,
Jul 27
Yes, it looks small enough and impactful enough we would want it, I marked it as approved in comment 17.
,
Jul 27
I think he put the Merge-Approved-68 label in comment#17, and bugdroid1 removed that label after the change got merged into 3440.
,
Jul 30
If this is merged, should we close this?
,
Jul 30
I think so.. There is nothing else I need to do to make sure the fix gets rolled out to the users, right?
,
Jul 31
Able to reproduce this issue on Windows 10 and Ubuntu 17.10 on the reported version 68.0.3440.75 and the issue is fixed on the latest M68 build - 68.0.3440.84 as per the original comment. The X is not displayed when Chrome is launched with the --kiosk flag. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Aug 1
Able to reproduce this issue on Windows 10 and Ubuntu 17.10 on the reported version 68.0.3440.75 and the issue is fixed on the latest M-69 build - 69.0.3497.23 as per the original comment. The X is not displayed when Chrome is launched with the --kiosk flag. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Aug 1
Thank you guys! Really appreciate the quick turnaround.
,
Aug 3
,
Aug 3
Issue 869322 has been merged into this issue.
,
Aug 8
,
Aug 8
Issue 871705 has been merged into this issue.
,
Aug 9
Issue 872232 has been merged into this issue. |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by swarnasree.mukkala@chromium.org
, Jul 25Labels: ReleaseBlock-Stable M-68 Target-70 FoundIn-70 FoundIn-68 Target-68 Target-69 FoundIn-69
Owner: yuweih@chromium.org
Status: Assigned (was: Unconfirmed)