compare_build_artifacts failing on chromium.linux/Deterministic Linux (dbg) |
||||||||
Issue descriptioncompare_build_artifacts failing on chromium.linux/Deterministic Linux (dbg) Builders failed on: - Deterministic Linux (dbg): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20%28dbg%29/2149 Unexpected files with diffs: cctest libv8_for_testing.so mksnapshot Unexpected files with no diffs: ppapi_nacl_tests_pnacl_newlib_x64.nexe Checking cctest difference: (1201 deps) obj/v8/torque_generated_initializers/builtins-array-from-dsl-gen.o : 13611 out of 548840 bytes are different (2.48%) obj/v8/torque_generated_initializers/builtins-typed-array-from-dsl-gen.o : different size: 579744 != 579776 obj/v8/torque_generated_initializers/builtins-data-view-from-dsl-gen.o : 28 out of 856488 bytes are different (0.00%) 0x1540 : ffff31d231c941b8010000004c89ef4889dee8000000004c89a520feffff488d '..1.1.A.....L..H.......L.. ...H.' ffff31d231c941b8010000004c89ef4889dee800000000488d8578feffff4889 '..1.1.A.....L..H.......H..x...H.' ^^^ ^^ ^ ^ ^ 0x1560 : 8578feffff48898528feffff4c89b530feffff488dbdd0fdffff488d8d20feff '.x...H..(...L..0...H......H.. ..' 8520feffff4c89b528feffff4c89a530feffff488dbdd0fdffff488d8d20feff '. ...L..(...L..0...H......H.. ..' ^^ ^ ^ ^ ^ ^ 0x39a0 : c941b8010000004c89ff4c89eee8000000004c89b558feffff488d85d8fdffff '.A.....L..L.......L..X...H......' c941b8010000004c89ff4c89eee800000000488d85d8fdffff48898558feffff '.A.....L..L.......H......H..X...' ++++++++++++++ +++++++ 0x39c0 : 48898560feffff4c8da588fdffff488d8d58feffffba0200000041b801000000 'H..`...L......H..X........A.....' 4c89b560feffff4c8da588fdffff488d8d58feffffba0200000041b801000000 'L..`...L......H..X........A.....' ^ ^ ^ 0x17980 : 00000801000000000000000000000000978fda25a318bf0e0000000000000000 '...................%............' 0000080100000000000000000000000021d8c94888a071310000000000000000 '................!..H..q1........' +++++ ++++++ ^ + ^ ^^ 0xbde20 : b84400000000000001000000000200005904000000000000c044000000000000 '.D..............Y........D......' b84400000000000001000000000200006004000000000000c044000000000000 '.D..............`........D......' ^^ ^ obj/v8/torque_generated_initializers/builtins-test-from-dsl-gen.o : 78 out of 515696 bytes are different (0.02%) Checking libv8_for_testing.so difference: (1018 deps) obj/v8/torque_generated_initializers/builtins-array-from-dsl-gen.o : 13611 out of 548840 bytes are different (2.48%) obj/v8/torque_generated_initializers/builtins-typed-array-from-dsl-gen.o: different size: 579744 != 579776 obj/v8/torque_generated_initializers/builtins-data-view-from-dsl-gen.o : 28 out of 856488 bytes are different (0.00%) 0x1540 : ffff31d231c941b8010000004c89ef4889dee8000000004c89a520feffff488d '..1.1.A.....L..H.......L.. ...H.' ffff31d231c941b8010000004c89ef4889dee800000000488d8578feffff4889 '..1.1.A.....L..H.......H..x...H.' ^^^ ^^ ^ ^ ^ 0x1560 : 8578feffff48898528feffff4c89b530feffff488dbdd0fdffff488d8d20feff '.x...H..(...L..0...H......H.. ..' 8520feffff4c89b528feffff4c89a530feffff488dbdd0fdffff488d8d20feff '. ...L..(...L..0...H......H.. ..' ^^ ^ ^ ^ ^ ^ 0x39a0 : c941b8010000004c89ff4c89eee8000000004c89b558feffff488d85d8fdffff '.A.....L..L.......L..X...H......' c941b8010000004c89ff4c89eee800000000488d85d8fdffff48898558feffff '.A.....L..L.......H......H..X...' ++++++++++++++ +++++++ 0x39c0 : 48898560feffff4c8da588fdffff488d8d58feffffba0200000041b801000000 'H..`...L......H..X........A.....' 4c89b560feffff4c8da588fdffff488d8d58feffffba0200000041b801000000 'L..`...L......H..X........A.....' ^ ^ ^ 0x17980 : 00000801000000000000000000000000978fda25a318bf0e0000000000000000 '...................%............' 0000080100000000000000000000000021d8c94888a071310000000000000000 '................!..H..q1........' +++++ ++++++ ^ + ^ ^^ 0xbde20 : b84400000000000001000000000200005904000000000000c044000000000000 '.D..............Y........D......' b84400000000000001000000000200006004000000000000c044000000000000 '.D..............`........D......' ^^ ^ obj/v8/torque_generated_initializers/builtins-test-from-dsl-gen.o : 78 out of 515696 bytes are different (0.02%) Checking mksnapshot difference: (1013 deps) obj/v8/torque_generated_initializers/builtins-array-from-dsl-gen.o : 13611 out of 548840 bytes are different (2.48%) obj/v8/torque_generated_initializers/builtins-typed-array-from-dsl-gen.o: different size: 579744 != 579776 obj/v8/torque_generated_initializers/builtins-data-view-from-dsl-gen.o : 28 out of 856488 bytes are different (0.00%) 0x1540 : ffff31d231c941b8010000004c89ef4889dee8000000004c89a520feffff488d '..1.1.A.....L..H.......L.. ...H.' ffff31d231c941b8010000004c89ef4889dee800000000488d8578feffff4889 '..1.1.A.....L..H.......H..x...H.' ^^^ ^^ ^ ^ ^ 0x1560 : 8578feffff48898528feffff4c89b530feffff488dbdd0fdffff488d8d20feff '.x...H..(...L..0...H......H.. ..' 8520feffff4c89b528feffff4c89a530feffff488dbdd0fdffff488d8d20feff '. ...L..(...L..0...H......H.. ..' ^^ ^ ^ ^ ^ ^ 0x39a0 : c941b8010000004c89ff4c89eee8000000004c89b558feffff488d85d8fdffff '.A.....L..L.......L..X...H......' c941b8010000004c89ff4c89eee800000000488d85d8fdffff48898558feffff '.A.....L..L.......H......H..X...' ++++++++++++++ +++++++ 0x39c0 : 48898560feffff4c8da588fdffff488d8d58feffffba0200000041b801000000 'H..`...L......H..X........A.....' 4c89b560feffff4c8da588fdffff488d8d58feffffba0200000041b801000000 'L..`...L......H..X........A.....' ^ ^ ^ 0x17980 : 00000801000000000000000000000000978fda25a318bf0e0000000000000000 '...................%............' 0000080100000000000000000000000021d8c94888a071310000000000000000 '................!..H..q1........' +++++ ++++++ ^ + ^ ^^ 0xbde20 : b84400000000000001000000000200005904000000000000c044000000000000 '.D..............Y........D......' b84400000000000001000000000200006004000000000000c044000000000000 '.D..............`........D......' ^^ ^ obj/v8/torque_generated_initializers/builtins-test-from-dsl-gen.o : 78 out of 515696 bytes are different (0.02%)
,
Jul 25
,
Jul 25
As hablich@ is ooo today, I assign jochen@ to this. Could you take a look? Thanks!
,
Jul 25
i'm no longer on v8, passing to machenbach@ for triage
,
Jul 25
,
Jul 25
Looks like this difference comes from torque. Tebbi, could you have a look?
,
Jul 25
Looks like from a V8 roll with these changes: https://chromium.googlesource.com/v8/v8/+log/d7b61abe..f0bf9a40
,
Jul 25
Issue 867021 has been merged into this issue.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2e2134254c162d7bce13cae0b8cf527de2c50334 commit 2e2134254c162d7bce13cae0b8cf527de2c50334 Author: Tobias Tebbi <tebbi@chromium.org> Date: Wed Jul 25 10:09:18 2018 [torque] make CPP generation deterministic by sorting changed variables I suspect that the non-deterministic order of changed variables in the generated Label constructor calls is what causes non-deterministic builds, since this is the only change I observed locally in the generated .cc files. Drive-by cleanup: follow style-guide by avoiding mutable ref parameter. Bug: chromium:867308 Change-Id: I137af359df570ee11b95cb620ace179bf93481c5 Reviewed-on: https://chromium-review.googlesource.com/1148729 Reviewed-by: Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54687} [modify] https://crrev.com/2e2134254c162d7bce13cae0b8cf527de2c50334/src/torque/implementation-visitor.cc [modify] https://crrev.com/2e2134254c162d7bce13cae0b8cf527de2c50334/src/torque/implementation-visitor.h
,
Jul 25
The builder is still red.
,
Jul 25
My commit has not rolled to Chromium yet. Our autoroller should roll it in the next ~3-4 hours.
,
Jul 26
It looks like this bug has been fixed by updating V8 to 7.0.52. Thank you very much! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hajimehoshi@chromium.org
, Jul 25