[LayoutNG]: Green triangle in Google SERP is misplaced |
||||
Issue descriptionChrome Version: 70.0.3501.2 canary with chrome://flags/#enable-layout-ng enabled OS: macOS 10.13, Windows 10 What steps will reproduce the problem? (1) Open https://www.google.com/search?hl=en&q=pythagoraswitch What is the expected result? For each of search results, Green triangle ▼ should be drawn next to the page URL. What happens instead? Green triangle ▼ is drawn inside a snippet. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 1
Looks like inline static position wrong for abspos?
,
Aug 6
Badly positioned triangle is not position:absolute. In Devtools, triangle element highlight is painted correctly. My guess is that this is an inline drawing problem.
,
Aug 6
> Badly positioned triangle is not position:absolute.
Isn't it:
<span class="mn-dwn-arw"></span>
? It has:
.mn-dwn-arw {
position: absolute;
}
,
Aug 6
You are correct. I've identified the root cause, and created a minimal reproducible case. This happens when abspos parent is block, but container is inline. We never set the correct inline_container for abspos descendant. I think it should get set in MoveOutOfFlowDescendantCandidatesToDescendants Hope to fix Tuesday.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b883f43214379b84ebcc01d911a2acd821634014 commit b883f43214379b84ebcc01d911a2acd821634014 Author: Aleks Totic <atotic@chromium.org> Date: Fri Aug 10 13:43:24 2018 [LayoutNG] Propagate abspos inline container OOF elements with inline container that were not direct descendants of container did not have their inline container set correctly. This caused Google SERP page to display a menu incorrectly. Test Bug: 867307 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iefc78785d296c87d7fc1f34abe3980c0783d6818 Reviewed-on: https://chromium-review.googlesource.com/1165953 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582139} [add] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/abspos-inline-007-ref.xht [add] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/abspos-inline-007.xht [modify] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc [modify] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.h [modify] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc [modify] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc [modify] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h [modify] https://crrev.com/b883f43214379b84ebcc01d911a2acd821634014/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_positioned_descendant.h
,
Aug 14
|
||||
►
Sign in to add a comment |
||||
Comment 1 by e...@chromium.org
, Jul 30Status: Assigned (was: Untriaged)