New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867299 link

Starred by 1 user
Status: Fixed
Owner:
wzang@chromium.org
Closed: Jul 25
Cc:
█ elizabethchiu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Wallpaper App] The wallpaper thumbnails should be center cropped instead of being stretched

Project Member Reported by wzang@chromium.org, Jul 25 
The thumbnails are square on the new wallpaper picker, but most of the original images are rectangular. Currently, the images are stretched in order to fit the square grid, however, they should be changed to center cropped in order to keep the original aspect ratio.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/179ec3df1e2ac38bd43039c24a4c7cced0c24cbe

commit 179ec3df1e2ac38bd43039c24a4c7cced0c24cbe
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Jul 25 23:35:29 2018

cros: Make sure the wallpaper thumbnails are center cropped

1) Change style.hidden to style.visibility = "hidden" so that
   offsetWidth/offsetHeight are non-zero.

2) In addition to the absolute positioning, need to use "clip-path" to
   clip the thumbnail, so that it remains square after being selected
   (transform: scale(0.8) is applied to the thumbnail).

Spec: https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug:  867299 
Change-Id: I6becad4fc0384c1e20c2069d4f1b89c8203ec01b
Reviewed-on: https://chromium-review.googlesource.com/1150454
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578126}
[modify] https://crrev.com/179ec3df1e2ac38bd43039c24a4c7cced0c24cbe/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js

Comment 2 by wzang@chromium.org, Jul 25

Status: Fixed (was: Started)

Comment 3 by wzang@chromium.org, Jul 26

Labels: -M-70 M-69

Comment 4 by wzang@chromium.org, Jul 26

Labels: Merge-Request-69
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 27

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/827e8544ff89bba53cc0f358ed8ba2ca98db7e4b

commit 827e8544ff89bba53cc0f358ed8ba2ca98db7e4b
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Jul 27 18:11:41 2018

[Merge to M69] cros: Make sure the wallpaper thumbnails are center cropped

1) Change style.hidden to style.visibility = "hidden" so that
   offsetWidth/offsetHeight are non-zero.

2) In addition to the absolute positioning, need to use "clip-path" to
   clip the thumbnail, so that it remains square after being selected
   (transform: scale(0.8) is applied to the thumbnail).

Spec: https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

TBR=wzang@chromium.org

(cherry picked from commit 179ec3df1e2ac38bd43039c24a4c7cced0c24cbe)

Bug:  867299 
Change-Id: I6becad4fc0384c1e20c2069d4f1b89c8203ec01b
Reviewed-on: https://chromium-review.googlesource.com/1150454
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578126}
Reviewed-on: https://chromium-review.googlesource.com/1153444
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#167}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/827e8544ff89bba53cc0f358ed8ba2ca98db7e4b/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
►

Sign in to add a comment