New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867268 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

basic support for modern USB Wifi

Project Member Reported by briannorris@chromium.org, Jul 25

Issue description

USB Wifi dongles can be useful in a pinch, if internal Wifi is acting up. A while back, we enabled support for some older Ralink chipsets (the rt2x00 / rt2800usb driver), but we only enabled a small subset of its driver support. Let's enable newer revisions.

A few low hanging fruit right now:

 CONFIG_RT2800USB_RT33XX=y
-# CONFIG_RT2800USB_RT3573 is not set
+CONFIG_RT2800USB_RT3573=y
 CONFIG_RT2800USB_RT35XX=y
-# CONFIG_RT2800USB_RT53XX is not set
-# CONFIG_RT2800USB_RT55XX is not set
-# CONFIG_RT2800USB_UNKNOWN is not set
+CONFIG_RT2800USB_RT53XX=y
+CONFIG_RT2800USB_RT55XX=y
+CONFIG_RT2800USB_UNKNOWN=y

The 33XX chipsets seem to be pretty old, while the 53XX and newer chipsets support some of the popular dongles on the market today (e.g., Panda PAU0x).

Also, the rt2870.bin firmware we install hasn't been updated in years. There's at least one newer update in linux-firmware.

With the above, I think there are at least a few 802.11ac dongles that should work.

Not in scope at the moment: how to handle the presence of more than 1 Wifi interface. At the moment, it depends on some arbitrary system factors as to which interface will get picked up first by shill -- and shill will only acknowledge a single Wifi interface at a time.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/dd7c30defd938fa579ee6878e786dd17588b8e1b

commit dd7c30defd938fa579ee6878e786dd17588b8e1b
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Jul 25 07:14:41 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149410
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/dd7c30defd938fa579ee6878e786dd17588b8e1b/chromeos/config/base.config

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/17596d6c8366d620669a87a5ad52e80cb7918c05

commit 17596d6c8366d620669a87a5ad52e80cb7918c05
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Jul 25 07:14:29 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149339
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/17596d6c8366d620669a87a5ad52e80cb7918c05/chromeos/config/base.config

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/886f3ae4bdf616292274c040f49e626b7854f1cb

commit 886f3ae4bdf616292274c040f49e626b7854f1cb
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Jul 25 23:35:16 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149450
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/886f3ae4bdf616292274c040f49e626b7854f1cb/chromeos/config/base.config

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/linux-firmware/+/d35939203a4dbbc8419eeaa90c2ff3bdb393a2e5

commit d35939203a4dbbc8419eeaa90c2ff3bdb393a2e5
Author: Xose Vazquez Perez <xose.vazquez@gmail.com>
Date: Wed Jul 25 23:35:14 2018

UPSTREAM: linux-firmware: update rt2870.bin, rt2800usb driver

rt2870.bin from 29 to 0.36

Cc: Shiang Tu <shiang_tu@ralinktech.com>
Cc: Hua Shao () <hua.shao@mediatek.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Cc: linux-firmware@kernel.org
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
Signed-off-by: Kyle McMartin <kyle@kernel.org>
(cherry picked from commit 9023bf7dc753c99ea29be742fe4f09d455f379ba)

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I167828910d9735275eedc6b54e7cf869fb6a560e
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149403
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/d35939203a4dbbc8419eeaa90c2ff3bdb393a2e5/WHENCE
[modify] https://crrev.com/d35939203a4dbbc8419eeaa90c2ff3bdb393a2e5/rt2870.bin

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/df604b49c1079dc0f8c9e63fb0e71a7b1acac4b1

commit df604b49c1079dc0f8c9e63fb0e71a7b1acac4b1
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Jul 25 23:35:13 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149413
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/df604b49c1079dc0f8c9e63fb0e71a7b1acac4b1/chromeos/config/base.config

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f0d7fe6363dd8f461eded83d987bacb1d86f2251

commit f0d7fe6363dd8f461eded83d987bacb1d86f2251
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Jul 25 23:35:09 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149446
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/f0d7fe6363dd8f461eded83d987bacb1d86f2251/chromeos/config/base.config

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6b695938f83cd7fe3baaa094e29205805fc35a75

commit 6b695938f83cd7fe3baaa094e29205805fc35a75
Author: Brian Norris <briannorris@chromium.org>
Date: Wed Jul 25 23:35:32 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149448
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/6b695938f83cd7fe3baaa094e29205805fc35a75/chromeos/config/base.config

Labels: M-70
Status: Fixed (was: Started)
Awesome, so this works now on Panda PAU07 (lsusb says: Ralink RT5572; driver says RT 5592 / RF chipset 000f) too, on both 2.4GHz and 5GHz. GoogleGuest gives me ~120Mbps downlink and >10Mbps uplink on Chell.

Test:

(1) Simulate dead Wifi
iw dev wlan0 del
(2) plug in USB Wifi dongle
(3) Profit

I'll call that Fixed, unless we can find some other easy USB Wifi chipsets that are worth enabling and testing.

I'm going to request merging for M-69, since we might have people who want to rescue their Wifi sooner rather than later.
Labels: Merge-Request-69
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 28

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 30

Labels: merge-merged-release-R69-10895.B-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/109087054ee66005fa9b75cb9bcaadeee5453497

commit 109087054ee66005fa9b75cb9bcaadeee5453497
Author: Brian Norris <briannorris@chromium.org>
Date: Mon Jul 30 22:51:30 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149410
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
(cherry picked from commit dd7c30defd938fa579ee6878e786dd17588b8e1b)
Reviewed-on: https://chromium-review.googlesource.com/1155844

[modify] https://crrev.com/109087054ee66005fa9b75cb9bcaadeee5453497/chromeos/config/base.config

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 30

Labels: merge-merged-release-R69-10895.B-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0cbf5e09eceed9bcd85ad884b5f7f5f9df1646cd

commit 0cbf5e09eceed9bcd85ad884b5f7f5f9df1646cd
Author: Brian Norris <briannorris@chromium.org>
Date: Mon Jul 30 22:55:43 2018

CHROMIUM: config: base: enable additional rt2x00 USB support

USB Wifi can sometimes be helpful as a backup, if the internal Wifi is
wonky. There are various popular USB Wifi dongles on the market that use
varieties of this Ralink chipset. Let's enable support for some newer
ones.

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I906773b3002218a9dbecd7ad9472d7d50c044ba9
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149339
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
(cherry picked from commit 17596d6c8366d620669a87a5ad52e80cb7918c05)
Reviewed-on: https://chromium-review.googlesource.com/1155845

[modify] https://crrev.com/0cbf5e09eceed9bcd85ad884b5f7f5f9df1646cd/chromeos/config/base.config

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 30

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/linux-firmware/+/b6a6476956504ca250c4d787b17b36570553b244

commit b6a6476956504ca250c4d787b17b36570553b244
Author: Xose Vazquez Perez <xose.vazquez@gmail.com>
Date: Mon Jul 30 22:55:43 2018

UPSTREAM: linux-firmware: update rt2870.bin, rt2800usb driver

rt2870.bin from 29 to 0.36

Cc: Shiang Tu <shiang_tu@ralinktech.com>
Cc: Hua Shao () <hua.shao@mediatek.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Cc: linux-firmware@kernel.org
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
Signed-off-by: Kyle McMartin <kyle@kernel.org>
(cherry picked from commit 9023bf7dc753c99ea29be742fe4f09d455f379ba)

BUG= chromium:867268 
TEST=try basic Wifi on Panda PAU05 (USB ID 148f:5372, RT chipset 5392)

Change-Id: I167828910d9735275eedc6b54e7cf869fb6a560e
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1149403
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
(cherry picked from commit d35939203a4dbbc8419eeaa90c2ff3bdb393a2e5)
Reviewed-on: https://chromium-review.googlesource.com/1155864

[modify] https://crrev.com/b6a6476956504ca250c4d787b17b36570553b244/WHENCE
[modify] https://crrev.com/b6a6476956504ca250c4d787b17b36570553b244/rt2870.bin

Labels: -Merge-Approved-69 Merge-Merged-69 M-69
Merged for 3.18 and 4.4 kernels, as those are the best tested and most likely to get used.

BTW, I tested 3.14 earlier, and some of the newer USB dongles do *not* work there, because the wireless-3.8 stack has too old of a rt2x00 driver. I'm not going to bother upgrading those, as we've made our bed there by pinning to ancient drivers. I expect the same applies to 3.8 and 3.10 kernels, where we have similarly ancient drivers.
> Merged for 3.18 and 4.4 kernels

By "merged", I mean merged to M69. (All kernels were "fixed" for M70, although "Fixed" means different things for some of the older kernels, as noted.)

Sign in to add a comment