Optimize SMB GetMetadata by removing roundtrip when only requesting thumbnail |
||||||||||
Issue descriptionSince we do not support thumbnails for SMB, we should not make a roundtrip to the daemon and over the network to fetch metadata for an entry when only the thumbnail is requested
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9235f61f764985868e14100c832fb84d0a27197 commit a9235f61f764985868e14100c832fb84d0a27197 Author: Zentaro Kavanagh <zentaro@chromium.org> Date: Tue Jul 31 19:10:14 2018 smb_client: Filter out redundant requests from FSP - Large numbers of redundant requests are degrading the performance of the SMB FSP - This CL short circuits those requests while separately we can try to eliminate their root cause - This filters out 2 types of requests 1) Empty requests. These requests should never even be made since they are requests that explicitly ask for no information. 2) Thumbnail only requests. We never have thumbnail data and always provide a hardcoded response. - By short circuiting them here we can prevent them being sent to the service and incuring any network operations. BUG= chromium:867200 , chromium:587231 TEST=build and test Change-Id: Ibb9eaaa175660106dd6a169781cc2ce4a83dafea Reviewed-on: https://chromium-review.googlesource.com/1156989 Reviewed-by: May Lippert <maybelle@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#579516} [modify] https://crrev.com/a9235f61f764985868e14100c832fb84d0a27197/chrome/browser/chromeos/smb_client/smb_file_system.cc [modify] https://crrev.com/a9235f61f764985868e14100c832fb84d0a27197/chrome/browser/chromeos/smb_client/smb_file_system.h
,
Aug 2
,
Aug 8
Change above is a workaround. There is still a fix needed in the File app
,
Aug 28
,
Aug 28
,
Sep 28
,
Sep 28
,
Oct 10
,
Oct 22
,
Dec 19
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by zentaro@chromium.org
, Jul 30Owner: zentaro@chromium.org