New issue
Advanced search Search tips

Issue 867200 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Optimize SMB GetMetadata by removing roundtrip when only requesting thumbnail

Project Member Reported by baileyberro@chromium.org, Jul 25

Issue description

Since we do not support thumbnails for SMB, we should not make a roundtrip to the daemon and over the network to fetch metadata for an entry when only the thumbnail is requested
 
Labels: -Pri-3 M-70 Pri-1
Owner: zentaro@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9235f61f764985868e14100c832fb84d0a27197

commit a9235f61f764985868e14100c832fb84d0a27197
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Jul 31 19:10:14 2018

smb_client: Filter out redundant requests from FSP

- Large numbers of redundant requests are degrading the performance
  of the SMB FSP
- This CL short circuits those requests while separately we can try
  to eliminate their root cause
- This filters out 2 types of requests
  1) Empty requests. These requests should never even be made since
     they are requests that explicitly ask for no information.
  2) Thumbnail only requests. We never have thumbnail data and always
     provide a hardcoded response.
- By short circuiting them here we can prevent them being sent to
  the service and incuring any network operations.

BUG= chromium:867200 , chromium:587231 
TEST=build and test

Change-Id: Ibb9eaaa175660106dd6a169781cc2ce4a83dafea
Reviewed-on: https://chromium-review.googlesource.com/1156989
Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579516}
[modify] https://crrev.com/a9235f61f764985868e14100c832fb84d0a27197/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/a9235f61f764985868e14100c832fb84d0a27197/chrome/browser/chromeos/smb_client/smb_file_system.h

Status: Assigned (was: Available)
Status: Started (was: Assigned)
Change above is a workaround. There is still a fix needed in the File app
Labels: -M-70 M-71
Labels: -Pri-1 Pri-2
Labels: -M-71 M-72 smb-filesapp
Components: Platform>Apps>FileManager
Labels: -M-72
Labels: CrOSFilesFeature-SMB
Status: WontFix (was: Started)

Sign in to add a comment