New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 867198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Update side-nav ordering to have external media/zip section at the bottom

Project Member Reported by weifangsun@chromium.org, Jul 25

Issue description

Per UI review feedback, we should move the external media section (including zip files) to the bottom after the cloud/3rd party file system section.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1319271933c15e80b6e43e13ddce7e8df009e28

commit a1319271933c15e80b6e43e13ddce7e8df009e28
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Jul 25 03:26:21 2018

Reorder zip and mounted volumes

Move zip, MTP, removable and archive volumes after Drive and 3rd-party
FSPs, as requested on the linked bug.

Bug:  867198 
Change-Id: I69a61b621e190ade9dd6d16d5655c57ea722cdff
Reviewed-on: https://chromium-review.googlesource.com/1149421
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577785}
[modify] https://crrev.com/a1319271933c15e80b6e43e13ddce7e8df009e28/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/a1319271933c15e80b6e43e13ddce7e8df009e28/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js

Cc: weifangsun@chromium.org
Labels: Merge-Request-69
Hi, 

I have tested this in my local dev environment on the branch (tag: 69.0.3494.0).

See screenshot for an example of a zip mounted.

Requesting merge to M69 branch, this change is only moving code around and fix test that checks for the ordering of this navigation tree.
Selection_048.png
46.3 KB View Download
Looks good, thanks Luciano! I see a few missing roots and views but assume that is not part of this bug :)
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 27

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e7e58ff73f8bac17b16b354bb82021e3a86005a

commit 2e7e58ff73f8bac17b16b354bb82021e3a86005a
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Jul 27 02:51:23 2018

Reorder zip and mounted volumes

Move zip, MTP, removable and archive volumes after Drive and 3rd-party
FSPs, as requested on the linked bug.

Bug:  867198 
Change-Id: I69a61b621e190ade9dd6d16d5655c57ea722cdff
Reviewed-on: https://chromium-review.googlesource.com/1149421
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577785}(cherry picked from commit a1319271933c15e80b6e43e13ddce7e8df009e28)
Reviewed-on: https://chromium-review.googlesource.com/1152587
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#137}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2e7e58ff73f8bac17b16b354bb82021e3a86005a/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/2e7e58ff73f8bac17b16b354bb82021e3a86005a/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js

Status: Fixed (was: Started)
Thanks for the approval. :-)

Merged on M69 branch.

mcirimele@ the missing  roots you mentioned it's just because on my dev environment I don't have all types of root available.

Closing the bug.

Sign in to add a comment