Settings: search engine row taller than other rows with large font settings |
|||
Issue descriptionI noticed with "very large" font, search engine row is taller than other rows. Its s"start" part has larger margins than other row's "start" parts, possibly due to the fact that it's using a <p> tag. see attached screenshot and code: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search_page/search_page.html?q=search_page.html&sq=package:chromium&dr&l=50
,
Jul 28
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95c73fc5717f7a1904981d3f08c4243b2a3030a9 commit 95c73fc5717f7a1904981d3f08c4243b2a3030a9 Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Jul 30 22:28:09 2018 Settings: change setting label from <p> to <div> to match other labels Bug: 867193 Change-Id: I140d9b979ba7f58a3ab8e62142797caddd148f44 Reviewed-on: https://chromium-review.googlesource.com/1154195 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#579201} [modify] https://crrev.com/95c73fc5717f7a1904981d3f08c4243b2a3030a9/chrome/browser/resources/settings/search_page/search_page.html
,
Jul 31
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Jul 24