MacViews: CATransactionCoordinator doesn't work on 10.10 Yosemite |
|||||||
Issue descriptionChrome Version : 70.0.3501.2 OS Version: OS X 10.10.5 What steps will reproduce the problem? 1. Resize the browser, or show the edit bookmark window modal sheet What is the expected result? No grey stuff What happens instead of that? Browser window shows grey gutters during resize. Content doesn't resize in-step. Edit bookmark window modal sheet animates in completely grey.
,
Jul 25
,
Jul 25
Unable to reproduce the issue on mac 10.13.3 using chrome reported version #70.0.3501.2. Attached a screen cast for reference. Following are the steps followed to reproduce the issue. ------------ 1. Resized the browser and showed the edit bookmark window modal sheet. 2. Observed that no grey stuff was observed. tapted@ - Could you please check the attached screen and please let us know if anything missed from our end. Thanks...!!
,
Jul 25
Re. #3, the issue is reported to only happen on 10.10. This is accurate… 10.10 is going to need extra work. +ellyjones@ for triage.
,
Jul 25
"Well, that sucks." What's our fix path?
,
Jul 25
Here's one idea:
@interface NSAnimationContext (PrivateAPI)
+ (void)addCommitHandler:(void (^)())handler;
@end
void CATransactionCoordinator::SynchronizeImpl() {
if (@available(macOS 10.11, *) {
// Existing behavior
} else {
[CATransaction begin];
dispatch_async(dispatch_get_main_queue(), ^{
PreCommitHandler();
NSDisableScreenUpdates();
PostCommitHandler();
NSEnableScreenUpdates();
[CATransaction commit];
});
}
}
…but I need to test it on real hardware when I'm back at the office. My question is how to prioritize it relative to other things.
,
Jul 25
(The order of those lines might be off FWIW. You might actually want |[CATransaction commit];| right after PreCommitHandler(), but it depends on what plays nicely with the window server on 10.10.)
,
Jul 26
This sounds like a Pri-3 to me.
,
Aug 14
I want to fix this, even if it only affects 10.10. It makes Chrome feel super janky.
,
Aug 14
Actually, let's target M70. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tapted@chromium.org
, Jul 24