Too much spacing between Classic and GTK theme buttons |
|||||||
Issue descriptionWhat steps will reproduce the problem? 1. Install a theme, for example https://chrome.google.com/webstore/detail/deadpool-full-screen-them/echjomhoplepodjjaaohelfnlnoelhgd 2. Go to chrome://settings, look in the appearance section. What is the expected result? Buttons should be properly spaced. What happens instead? Buttons have too much spacing. It seems that there was an assumption that those buttons can't be shown at the same time, which does not seem to hold.
,
Jul 24
,
Jul 24
,
Nov 28
,
Nov 28
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a97b4ca32bf8601fc40327ebdc0b13ff619694e commit 7a97b4ca32bf8601fc40327ebdc0b13ff619694e Author: John Lee <johntlee@chromium.org> Date: Sat Dec 01 02:04:50 2018 WebUI: Remove extra margin between multiple buttons on Appearance page Bug: 867169 Change-Id: Ib92bcc9a46653181fda1fd23ea6da63daf3b081d Reviewed-on: https://chromium-review.googlesource.com/c/1354485 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#612904} [modify] https://crrev.com/7a97b4ca32bf8601fc40327ebdc0b13ff619694e/chrome/browser/resources/settings/appearance_page/appearance_page.html
,
Dec 3
Able to reproduce the issue on chrome version #69.0.3497.12 using Ubuntu 17.10 by following steps comment#0. Tested the issue on latest chrome version #73.0.3629.0 using Ubuntu 17.10. Able to see the fix on Ubuntu 17.10. As Classic and GTK theme buttons are specific to Linux, please confirm the fix for Windows and Mac. Attached screenshot for reference. @John Lee: Please find the above information and attached screenshot and help us in verifying the fix. Thanks.!
,
Dec 4
Non-Linux Chrome only has one button so this bug does not apply. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dpa...@chromium.org
, Jul 24