New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 867167 link

Starred by 2 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jul 27
Cc:
█ krajshree@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Closing hovered tabs painted behind non-hovered tabs

Project Member Reported by pkasting@chromium.org, Jul 24 
The fix in https://chromium-review.googlesource.com/c/chromium/src/+/1140954 was incomplete.  If a hovered tab is closing, it's painted behind all non-closing tabs.

To repro, open several tabs, move to one in the midst of the group, and middle-click it near its left edge while watching its lower-left corner.

The issue is that Tab::Strip::PaintClosingTabs() paints immediately.  We probably want to process the tabs from the various close queues using the normal processing code, in the appropriate order within the strip.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a9d235d4d7f81ff67d0b35f7114442044641842

commit 3a9d235d4d7f81ff67d0b35f7114442044641842
Author: Allen Bauer <kylixrd@chromium.org>
Date: Fri Jul 27 14:36:09 2018

Reorder painting of hovered closing tabs with the other hovered tabs.

I moved the code from PaintClosingTabs() to a local lambda and refactored
the code that checks for the hovered states into a separate lambda. Now,
when closing a hovered tab (especially if you add --animation-duration-scale=4.0)
you can clearly see the closing and hovered tab paint with the lower tails
visible until it's gone. While less likley to happen, the code will also
ensure that if there are multiple tabs being closed with an active hover
in progress, they will paint along with the non-closing hovered tabs in
the correct order.

Bug:  867167 
Change-Id: Id5d28ef51857390b3f7ec641a8a0c071ce562859
Reviewed-on: https://chromium-review.googlesource.com/1150218
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578635}
[modify] https://crrev.com/3a9d235d4d7f81ff67d0b35f7114442044641842/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/3a9d235d4d7f81ff67d0b35f7114442044641842/chrome/browser/ui/views/tabs/tab_strip.h

Comment 2 by kylixrd@chromium.org, Jul 27

Status: Fixed (was: Assigned)
ClosingHoveredTabs.mp4
281 KB View Download

Comment 3 by krajshree@chromium.org, Jul 30

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Win-10 using chrome build without fix.
Attached a screen cast for reference of chrome build without fix.

Opened several tabs, moved to one in the midst of the group, and middle-clicked it near its left edge while watching its lower-left corner. Observed that on closing a hovered tab by adding --animation-duration-scale=4.0, the closing and hovered tab painted with the lower tails visible until it's gone as expected. This is the behaviour observed on chrome build without fix i.e #70.0.3500.0.

kylixrd@ - Could you please check the attached screen cast and please let us know if anything missed from our end in reproducing the issue.

Thanks...!!
867167@build_without_fix.mp4
427 KB View Download
►

Sign in to add a comment