New issue
Advanced search Search tips

Issue 867155 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on: View detail
issue 885912
issue 891929
issue 872521



Sign in to add a comment

Add a python script for measuring browser power consumptions on Windows/Intel

Project Member Reported by zmo@chromium.org, Jul 24

Issue description

What are needed in this script:

1) launch a version of Chrome
2) launch Intel PowerGadget, measure and log data
3) analyze the data and print out results
4) setup Windows machine so certain services will be disabled if they may affect power consumption
5) ability to write a bunch of test scenarios into a json file, and let the script automatically run one test after another and record the results
6) (maybe) support other browsers, so we can easily measure and compare
 
jbauman@ left behind a rough script, doing the basic measuring. I plan to evolve that into something more useful.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/715a0ec9c0a5229478bc1a456c7db268be0fe43e

commit 715a0ec9c0a5229478bc1a456c7db268be0fe43e
Author: Zhenyao Mo <zmo@chromium.org>
Date: Mon Jul 30 22:11:49 2018

Add a script to make power measurement on Win/Intel easier.

BUG=867155
TEST=manual
R=crouleau@chromium.org,sunnyps@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id5bc22f7e8452e46397dd1a47fe7b1c8d50ff915
Reviewed-on: https://chromium-review.googlesource.com/1112771
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579192}
[add] https://crrev.com/715a0ec9c0a5229478bc1a456c7db268be0fe43e/content/test/gpu/ipg_utils.py
[add] https://crrev.com/715a0ec9c0a5229478bc1a456c7db268be0fe43e/content/test/gpu/measure_power_win_intel.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73294c6ca75e15ca6f23d8e640b4576ba73f6411

commit 73294c6ca75e15ca6f23d8e640b4576ba73f6411
Author: Zhenyao Mo <zmo@chromium.org>
Date: Wed Aug 01 16:54:58 2018

Add a script only telemetry_gpu_integration_test target

So we can zip all the scripts from chrome src tree and run on a target machine
without checking out the chrome src tree using the following command:

python tools/mb/mb.py zip out/Release telemetry_gpu_integration_test_scripts_only out/my_scripts.zip

BUG=867155
TEST=perf
R=kbr@chromium.org,nednguyen@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi


Change-Id: Ia3706abad6aadb4904fc7584837a511b72be71e8
Reviewed-on: https://chromium-review.googlesource.com/1157251
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579839}
[modify] https://crrev.com/73294c6ca75e15ca6f23d8e640b4576ba73f6411/chrome/test/BUILD.gn
[modify] https://crrev.com/73294c6ca75e15ca6f23d8e640b4576ba73f6411/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/73294c6ca75e15ca6f23d8e640b4576ba73f6411/testing/buildbot/manage.py
[modify] https://crrev.com/73294c6ca75e15ca6f23d8e640b4576ba73f6411/tools/perf/chrome_telemetry_build/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/44277bd90b09c6469b6e38b6271b67a70ec1b703

commit 44277bd90b09c6469b6e38b6271b67a70ec1b703
Author: Zhenyao Mo <zmo@chromium.org>
Date: Thu Aug 02 22:10:21 2018

Hookup finder_options.browser_options.wpr_mode for gpu integration tests.

BUG=chromium:867155
TEST=manual
R=kbr@chromium.org

Change-Id: I307b8a5a62133208f8e92ee63c5c62814f9fa26c
Reviewed-on: https://chromium-review.googlesource.com/1161212
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>

[modify] https://crrev.com/44277bd90b09c6469b6e38b6271b67a70ec1b703/telemetry/telemetry/testing/serially_executed_browser_test_case.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c942eaaa913713e49506b3f961e0bc754648143

commit 2c942eaaa913713e49506b3f961e0bc754648143
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 03 03:18:03 2018

Roll src/third_party/catapult eae13a4b34cc..e16a2e80be66 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/eae13a4b34cc..e16a2e80be66


git log eae13a4b34cc..e16a2e80be66 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 vovoy@chromium.org Look up wpr archives by story name only
2018-08-02 zmo@chromium.org Hookup finder_options.browser_options.wpr_mode for gpu integration tests.


Created with:
  gclient setdep -r src/third_party/catapult@e16a2e80be66

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:810616 ,chromium:867155
TBR=sullivan@chromium.org

Change-Id: I18bcbd9dffcaadf0d66ca2ccc92ee7be45238e82
Reviewed-on: https://chromium-review.googlesource.com/1161146
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580433}
[modify] https://crrev.com/2c942eaaa913713e49506b3f961e0bc754648143/DEPS

Blockedon: 872521
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf4e4c4f8aa56895b4ab52a20998307dfe7de716

commit cf4e4c4f8aa56895b4ab52a20998307dfe7de716
Author: Zhenyao Mo <zmo@chromium.org>
Date: Mon Sep 10 17:30:02 2018

Integrate power measurement test with gpu_integration_test harness.

So we can easily take advantage of devtools integration in tests. For example,
the ability to automatically turn into fullscreen video playing mode.

BUG=867155
TEST=manual
R=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2ed4d91ea82c3fc1308663c5d70e0f37bd50cd78
Reviewed-on: https://chromium-review.googlesource.com/1159690
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589965}
[rename] https://crrev.com/cf4e4c4f8aa56895b4ab52a20998307dfe7de716/content/test/gpu/gpu_tests/ipg_utils.py
[rename] https://crrev.com/cf4e4c4f8aa56895b4ab52a20998307dfe7de716/content/test/gpu/gpu_tests/measure_power_win_intel.py
[add] https://crrev.com/cf4e4c4f8aa56895b4ab52a20998307dfe7de716/content/test/gpu/gpu_tests/power_measurement_integration_test.py
[modify] https://crrev.com/cf4e4c4f8aa56895b4ab52a20998307dfe7de716/content/test/gpu/gpu_tests/verify_all_expectations_unittest.py

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2c413c61036424fa66a8e27c6517ad10fb2d3f

commit 0b2c413c61036424fa66a8e27c6517ad10fb2d3f
Author: Zhenyao Mo <zmo@chromium.org>
Date: Mon Sep 24 18:59:11 2018

Implement fullscreen mode for power gpu integration test

BUG=867155
TEST=manual
R=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idafc99cf9a486cc23751eff36084d63115b5d87f
Reviewed-on: https://chromium-review.googlesource.com/1239733
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593618}
[modify] https://crrev.com/0b2c413c61036424fa66a8e27c6517ad10fb2d3f/content/test/gpu/gpu_tests/power_measurement_integration_test.py

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6ebc8e485fba8d8334c294a739b9003a2e52975

commit a6ebc8e485fba8d8334c294a739b9003a2e52975
Author: Zhenyao Mo <zmo@chromium.org>
Date: Tue Oct 02 00:13:30 2018

Make video power test more generic in going fullscreen mode

The previous code is hardwired to youtube site. Now it's more
generic, although it still doesn't work anywhere.

BUG=867155
TEST=manual
R=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ief21731f484bbe2d0b2500483d304abdd27511de
Reviewed-on: https://chromium-review.googlesource.com/1242453
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595661}
[modify] https://crrev.com/a6ebc8e485fba8d8334c294a739b9003a2e52975/content/test/gpu/gpu_tests/power_measurement_integration_test.py

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444e40d835950f16bca8cd39d0303b012bc6ba52

commit 444e40d835950f16bca8cd39d0303b012bc6ba52
Author: Zhenyao Mo <zmo@chromium.org>
Date: Wed Oct 03 02:08:18 2018

Add --underlay option for video power measurement test

With --underlay, we add a div on top of video to make sure video
layer is an underlay.

Note that without --underlay, the video could still be an underlay
due to controls, ads, logo, etc. At the moment we don't have a way
to force overlay mode.

BUG=867155
TEST=manual
R=kainino@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If86f759b7f8bc13022b5f24a1031d7e0be3aef3a
Reviewed-on: https://chromium-review.googlesource.com/c/1258315
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596096}
[modify] https://crrev.com/444e40d835950f16bca8cd39d0303b012bc6ba52/content/test/gpu/gpu_tests/power_measurement_integration_test.py

Blockedon: 891929
Blockedon: 885912
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/528c9645a940b33b2e6a9912fd99214b5173699c

commit 528c9645a940b33b2e6a9912fd99214b5173699c
Author: Zhenyao Mo <zmo@chromium.org>
Date: Sat Oct 13 01:01:56 2018

Use Click instead of Tap in video power testing

BUG=867155
TEST=run_gpu_integration_tests power --fullscreen
R=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I600b6ef17eb30bccd60293b07ebf8877369c3e58
Reviewed-on: https://chromium-review.googlesource.com/c/1279349
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599455}
[modify] https://crrev.com/528c9645a940b33b2e6a9912fd99214b5173699c/content/test/gpu/gpu_tests/power_measurement_integration_test.py

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8b6ec63577e1822d95055df55cea23441a1ae4

commit 2e8b6ec63577e1822d95055df55cea23441a1ae4
Author: Zhenyao Mo <zmo@chromium.org>
Date: Mon Nov 05 23:18:59 2018

Add Edge support in measure_power_win_intel.py

BUG=867155
TEST=manual
R=sunnyps@chromium.org, kbr@chromium.org

Change-Id: I1abd150568f1693c6470dfb40ea3c7121c168c4f
Reviewed-on: https://chromium-review.googlesource.com/c/1318543
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605512}
[modify] https://crrev.com/2e8b6ec63577e1822d95055df55cea23441a1ae4/content/test/gpu/measure_power_win_intel.py

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e34ed88cb9c018bdcf700f4d1700dbe7be26eba7

commit e34ed88cb9c018bdcf700f4d1700dbe7be26eba7
Author: Zhenyao Mo <zmo@chromium.org>
Date: Sat Nov 17 01:02:54 2018

A few minor improvement for power measurement script

1) Need to change the way python launched Edge. This is the only way an URL
can be passed to Edge that contains "&".

2) Add an option to pass command line switches in a file

BUG=867155
R=sunnyps@chromium.org
TEST=manual

Change-Id: If5457a82661414c2a3453bff094d6a2ffadeeab0
Reviewed-on: https://chromium-review.googlesource.com/c/1332930
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609054}
[modify] https://crrev.com/e34ed88cb9c018bdcf700f4d1700dbe7be26eba7/content/test/gpu/measure_power_win_intel.py

Sign in to add a comment