New issue
Advanced search Search tips

Issue 867147 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 878028



Sign in to add a comment

Add native implementation for Lottie via Skia

Project Member Reported by malaykeshav@chromium.org, Jul 24

Issue description

We want to provide native support for lottie animations via its Skia implementation, Skottie.

More info on Skottie:
https://g3doc.corp.google.com/chrome/skia/g3doc/user/animation.md

We want to read the Lottie animation files directly either in their default JSON format, or ideally in a binary format(Generated at build time) for better performance. Send this via the PaintOpBuffer to be rasterized with the Skottie library.

 
(Un-cc-ing myself since I'm not sure about my involvement in this, but feel free to re-add me if I'm confused. :-P)
Cc: robliao@chromium.org
Blocking: 878028
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b7e8547498ccb8cf22490e5b2387c142216cfc9

commit 9b7e8547498ccb8cf22490e5b2387c142216cfc9
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Fri Sep 28 04:20:59 2018

Implements the wrapper for skottie animation class

Adds the skottie animation class that is a wrapper around the Skia's
implementation of lottie player. The class manages its own timeline with
the help of a timer object.

This is the phase 1 implementation of native skottie which rasterizes
the animation on the UI thread. Subsequent changes will move this
rasterization to worker threads(phase 2) and then to GPU (phase 3).

Adds unittests as well.

Design Doc: go/cros-skottie

Bug:  867147 
Change-Id: I2501710a38874f247ab3ab56a743675e3d07edfb
Component: gfx, skottie, vector animation
Reviewed-on: https://chromium-review.googlesource.com/1189056
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594981}
[modify] https://crrev.com/9b7e8547498ccb8cf22490e5b2387c142216cfc9/ui/gfx/BUILD.gn
[add] https://crrev.com/9b7e8547498ccb8cf22490e5b2387c142216cfc9/ui/gfx/skia_vector_animation.cc
[add] https://crrev.com/9b7e8547498ccb8cf22490e5b2387c142216cfc9/ui/gfx/skia_vector_animation.h
[add] https://crrev.com/9b7e8547498ccb8cf22490e5b2387c142216cfc9/ui/gfx/skia_vector_animation_observer.h
[add] https://crrev.com/9b7e8547498ccb8cf22490e5b2387c142216cfc9/ui/gfx/skia_vector_animation_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment