New issue
Advanced search Search tips

Issue 867146 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove kEnableMediaSuspend switch

Project Member Reported by halliwell@chromium.org, Jul 24

Issue description

As discussed on https://chromium-review.googlesource.com/c/chromium/src/+/1133975

We should remove kEnableMediaSuspend (and maybe kDisableMediaSuspend also?)
After landing this CL, they will only be used in media_session_impl_visibility_browsertest.cc
 

Comment 1 by dbbrooks@chromium.org, Jan 17 (5 days ago)

Owner: sande...@chromium.org
sandersd@, could you confirm the following as best you can: "Is this something we want to do?," "How important is it?," "Who should do it?" and change the status accordingly. Trying to get it past the Untriaged state. Thanks.

Comment 2 by sande...@chromium.org, Jan 17 (5 days ago)

Labels: Hotlist-CodeHealth
Status: Available (was: Untriaged)
--enable-media-suspend isn't useful. --disable-media-suspend is used by tests but shouldn't be used by users because it doesn't really do what it says it does (it only disables one of the kinds of media suspend).

What we should do is create a better path for tests that need to configure this and remove the flags entirely, but the priority is very low.

There is no obvious owner for this work, probably someone form the media team would do it.

Sign in to add a comment