New issue
Advanced search Search tips

Issue 867131 link

Starred by 1 user
Status: Fixed
Owner:
vmp...@chromium.org
Closed: Jul 25
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Ignore non-highresolutiontime for blink updatetime metrics

Project Member Reported by vmp...@chromium.org, Jul 24 
If a user does not have high resolution time, then the resolution of the clock can be as bad as ~15ms. Ignore these for the purposes of blink updatetime metrics.

This drops ~30% of windows users from these metrics. Unfortunately, there doesn't seem to be a better way to ensure high quality metrics.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1db2b3a1989d8e728e07c8c4a1e2c8e917dd0cb9

commit 1db2b3a1989d8e728e07c8c4a1e2c8e917dd0cb9
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Wed Jul 25 22:11:40 2018

Ignore reports from low resolution clocks for Blink.UpdateTime metrics.

This patch ignores reports from machines where
TimeTicks::IsHighResolution returns false, since they mostly add
noise.

Bug:  867131 

Change-Id: I8f341e3db978af82b30d68a43c984875fede7435
Reviewed-on: https://chromium-review.googlesource.com/1148778
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578093}
[modify] https://crrev.com/1db2b3a1989d8e728e07c8c4a1e2c8e917dd0cb9/third_party/blink/renderer/platform/ukm_time_aggregator.cc
[modify] https://crrev.com/1db2b3a1989d8e728e07c8c4a1e2c8e917dd0cb9/third_party/blink/renderer/platform/ukm_time_aggregator_test.cc
[modify] https://crrev.com/1db2b3a1989d8e728e07c8c4a1e2c8e917dd0cb9/tools/metrics/histograms/histograms.xml

Comment 2 by vmp...@chromium.org, Jul 25

Status: Fixed (was: Assigned)
►

Sign in to add a comment