New issue
Advanced search Search tips

Issue 867106 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Add EarlGrey tests for saving data after form submission

Project Member Reported by mahmadi@chromium.org, Jul 24

Issue description

These tests should verify Autofill addresses and credit cards get saved after form submission. (In the case of credit cards it's enough to verify the save card infobar shows). 
 
Components: UI>Browser>Autofill
Labels: -Pri-3 M-70 OS-iOS Pri-2
Status: Assigned (was: Untriaged)
Cc: rogerm@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c21e382a9c36f5278c9430f7168944f9ca8f13d4

commit c21e382a9c36f5278c9430f7168944f9ca8f13d4
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Aug 21 16:47:00 2018

[AF][IOS] Adds EarlGrey tests for the credit card save infobar (part 1)

Adds test to ensure the upstreaming infobar and the local save infobar
appear as expected after form submission.

Bug: 867106
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3fe6355385b8737c23e0ff51e500d4ca98c196df
Reviewed-on: https://chromium-review.googlesource.com/1179962
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584785}
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/core/browser/form_data_importer.h
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/ios/browser/BUILD.gn
[add] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[add] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[add] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/components/autofill/ios/browser/ios_test_event_waiter.h
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/ios/chrome/browser/ui/autofill/save_card_infobar_controller.h
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm
[add] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
[modify] https://crrev.com/c21e382a9c36f5278c9430f7168944f9ca8f13d4/ios/chrome/test/earl_grey/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b86224b68a7e6cba334a35db5cf2eebaa3aabdc

commit 9b86224b68a7e6cba334a35db5cf2eebaa3aabdc
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 18 16:40:54 2018

[AF][IOS] Adds EarlGrey tests for the credit card save infobar (part 2)

Adds tests to ensure UMA metrics are correctly logged and user data is
saved as expected after user interaction with the credit card save infobar.

Bug: 867106
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4966f694cfb02878f98af2fed324cda7a6f10058
Reviewed-on: https://chromium-review.googlesource.com/1228979
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592074}
[modify] https://crrev.com/9b86224b68a7e6cba334a35db5cf2eebaa3aabdc/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/9b86224b68a7e6cba334a35db5cf2eebaa3aabdc/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28daf3ae46c6b86aebb17190fb6b92db2acc245e

commit 28daf3ae46c6b86aebb17190fb6b92db2acc245e
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Mon Sep 24 16:47:19 2018

[AF][IOS] Adds EarlGrey tests for saving profiles after form submission

Bug: 867106
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I931d15446e55a2f68b673d71525a805914bad422
Reviewed-on: https://chromium-review.googlesource.com/1239369
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593568}
[modify] https://crrev.com/28daf3ae46c6b86aebb17190fb6b92db2acc245e/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/28daf3ae46c6b86aebb17190fb6b92db2acc245e/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
[add] https://crrev.com/28daf3ae46c6b86aebb17190fb6b92db2acc245e/ios/chrome/browser/ui/autofill/save_profile_egtest.mm

Sign in to add a comment