New issue
Advanced search Search tips

Issue 867094 link

Starred by 1 user
Status: Fixed
Owner:
la...@chromium.org
Closed: Sep 20
Cc:
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Improve messaging for partial CommitQueueHandleChanges failures

Project Member Reported by la...@chromium.org, Jul 24 
It isn't always clear that the e.g. "Could not submit <CL>" message indicates only a partial failure and that most CLs were still merged. Maybe just an additional annotation like "31/32 CLs submitted"
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0d2df807c94fce22a013c1ad3b0e8333caa9a2dc

commit 0d2df807c94fce22a013c1ad3b0e8333caa9a2dc
Author: Lann Martin <lannm@chromium.org>
Date: Wed Jul 25 07:14:39 2018

Annotate failed CommitQueueHandleChanges with CL counts

BUG= chromium:867094 
TEST=validation_pool_unittest

Change-Id: I452d0132998bd418979a9e7bdfca2c9148aeea60
Reviewed-on: https://chromium-review.googlesource.com/1148995
Commit-Ready: Lann Martin <lannm@chromium.org>
Tested-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/0d2df807c94fce22a013c1ad3b0e8333caa9a2dc/cbuildbot/validation_pool.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e8b6729e65105ffc804e6d8c59136a9dd4d062ad

commit e8b6729e65105ffc804e6d8c59136a9dd4d062ad
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Jul 28 02:11:20 2018

validation_pool: fix lint error in previous commit

BUG= chromium:867094 
TEST=precq passes

Change-Id: If84cc4486de4d570014cd24348a3db4af087a0ff
Reviewed-on: https://chromium-review.googlesource.com/1152467
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/e8b6729e65105ffc804e6d8c59136a9dd4d062ad/cbuildbot/validation_pool.py

Comment 3 by la...@chromium.org, Sep 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment