New issue
Advanced search Search tips

Issue 867086 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Record a metric for casting to a manually entered sink

Project Member Reported by taku...@chromium.org, Jul 24

Issue description

Add a metric for the usage of the feature to manually enter sink IDs to cast to, which is used by Hangouts.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d81353f54fc2a4cc20332f655ffe1c952e585669

commit d81353f54fc2a4cc20332f655ffe1c952e585669
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Jul 27 18:33:36 2018

[Media Router WebUI] Add a UMA metric to record sink search outcome

Add a boolean metric MediaRouter.Sink.SearchOutcome, which records
whether or not a sink was found for the ID that the user entered and
attempted to cast to.

Bug:  867086 
Change-Id: Ie1bf8072b7700298b8a783480b05a2e845666946
Reviewed-on: https://chromium-review.googlesource.com/1148956
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578721}
[modify] https://crrev.com/d81353f54fc2a4cc20332f655ffe1c952e585669/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/d81353f54fc2a4cc20332f655ffe1c952e585669/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/d81353f54fc2a4cc20332f655ffe1c952e585669/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/d81353f54fc2a4cc20332f655ffe1c952e585669/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/d81353f54fc2a4cc20332f655ffe1c952e585669/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Merge-Request-69
Status: Started (was: Fixed)
I'd like to request a merge of c#1 into M69. This CL adds code to record a metric.
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Updated OS labels.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 31

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/663e4ac4eb82ee6d4b4f9823a45df87d5315bace

commit 663e4ac4eb82ee6d4b4f9823a45df87d5315bace
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Jul 31 20:45:59 2018

[Media Router WebUI] Add a UMA metric to record sink search outcome

Add a boolean metric MediaRouter.Sink.SearchOutcome, which records
whether or not a sink was found for the ID that the user entered and
attempted to cast to.

Bug:  867086 
Change-Id: Ie1bf8072b7700298b8a783480b05a2e845666946
Reviewed-on: https://chromium-review.googlesource.com/1148956
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578721}(cherry picked from commit d81353f54fc2a4cc20332f655ffe1c952e585669)
Reviewed-on: https://chromium-review.googlesource.com/1156934
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#294}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/663e4ac4eb82ee6d4b4f9823a45df87d5315bace/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/663e4ac4eb82ee6d4b4f9823a45df87d5315bace/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/663e4ac4eb82ee6d4b4f9823a45df87d5315bace/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/663e4ac4eb82ee6d4b4f9823a45df87d5315bace/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/663e4ac4eb82ee6d4b4f9823a45df87d5315bace/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment