New issue
Advanced search Search tips

Issue 867078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Combine all chromeos related window_finder classes into a single class

Project Member Reported by sky@chromium.org, Jul 24

Issue description

window_finder_ash, window_finder_chromeos and window_finder_mus are all ChromeOS specific and should be combined into a single file.
 
Owner: mukai@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709d7c0b6f12de1624c57b4e5acdbb082723ed64

commit 709d7c0b6f12de1624c57b4e5acdbb082723ed64
Author: Jun Mukai <mukai@chromium.org>
Date: Wed Jul 25 18:21:13 2018

consolidate window_finder_{ash,chromeos,mus}

Those files are said to be ChromeOS only, putting all of them
into _chromeos.cc files and removing others. _ozone, _win, and
_x11 are actually referring to _mus, but they won't be used since
the feature isn't enabled on those platforms.

Bug:  867078 
Test: build passes
Change-Id: I76e7285fce7aac7c229a7cbe8668c5f654276178
Reviewed-on: https://chromium-review.googlesource.com/1149186
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577980}
[modify] https://crrev.com/709d7c0b6f12de1624c57b4e5acdbb082723ed64/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/709d7c0b6f12de1624c57b4e5acdbb082723ed64/chrome/browser/ui/views/tabs/DEPS
[delete] https://crrev.com/4c3ad9d6a49eb88d36aeecd7dad7e912c80f04bd/chrome/browser/ui/views/tabs/window_finder_ash.cc
[modify] https://crrev.com/709d7c0b6f12de1624c57b4e5acdbb082723ed64/chrome/browser/ui/views/tabs/window_finder_chromeos.cc
[delete] https://crrev.com/4c3ad9d6a49eb88d36aeecd7dad7e912c80f04bd/chrome/browser/ui/views/tabs/window_finder_mus.cc
[delete] https://crrev.com/4c3ad9d6a49eb88d36aeecd7dad7e912c80f04bd/chrome/browser/ui/views/tabs/window_finder_mus.h
[modify] https://crrev.com/709d7c0b6f12de1624c57b4e5acdbb082723ed64/chrome/browser/ui/views/tabs/window_finder_ozone.cc
[modify] https://crrev.com/709d7c0b6f12de1624c57b4e5acdbb082723ed64/chrome/browser/ui/views/tabs/window_finder_win.cc
[modify] https://crrev.com/709d7c0b6f12de1624c57b4e5acdbb082723ed64/chrome/browser/ui/views/tabs/window_finder_x11.cc

Status: Fixed (was: Assigned)

Sign in to add a comment