DCHECK goes off at drm_device_connector.cc(47) |
|||
Issue descriptionWhen building chrome for ChromeOS with dchecks_always_on = true, as soon as the ui starts, without any additional flag in /etc/chrome_dev.conf, we hit a DCHECK: [6035:6035:0723/213438.861326:FATAL:drm_device_connector.cc(47)] Check failed: (ws_runner_ && !features::IsAshInBrowserProcess()) || (!ws_runner_ && features::IsAshInBrowserProcess()). Commenting out the DCHECK seems to result in a working chrome.
,
Jul 25
,
Jul 25
,
Jul 25
+1, I also just ran into this.
,
Jul 26
,
Jul 26
https://chromium-review.googlesource.com/c/chromium/src/+/1150939 should prevent this type of regression again
,
Jul 26
Re 6: dcastagna, does the code in question runs when chromeos runs in a VM?
,
Jul 27
I never tried running chromeos in a VM, but if we use ozone/drm there, that code should run there too AFAIU.
,
Jul 27
Re comment #7: If you're asking if there are ChromeOS VM bots running Ozone/DRM, yes there are. Don't know if they are running with DCHECKs enabled, but the code is exercised on ChromeOS VMs too.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcd9cb5b0c74e66cc056adfd7bc2b94ad057c1a0 commit fcd9cb5b0c74e66cc056adfd7bc2b94ad057c1a0 Author: Robert Kroeger <rjkroege@chromium.org> Date: Fri Jul 27 16:01:07 2018 [ozone/drm] Correctly (dis)enable ozone/drm/mojo Fix a typo in https://chromium-review.googlesource.com/c/chromium/src/+/1142449,that resulted in over-eager execution of ozone/drm/mojo and hence the firing of DCHECKs on CrOS in certain configurations. BUG= 867077 TEST=Run with DCHECKs always on. Change-Id: I239f7927894a9d766d9057f3145e458a0fb2aa6b Reviewed-on: https://chromium-review.googlesource.com/1152900 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#578658} [modify] https://crrev.com/fcd9cb5b0c74e66cc056adfd7bc2b94ad057c1a0/ui/base/ui_base_features.cc
,
Jul 27
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dd5af999e56da3b75b067cd27948f0605bb47c9 commit 4dd5af999e56da3b75b067cd27948f0605bb47c9 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Jul 30 19:29:31 2018 Enable DCHECKs on amd64-generic simplechrome CQ bot. Bug: 867077 Change-Id: Icad4a62735d3be6579b3c6476bbbb65ad1843ec8 Reviewed-on: https://chromium-review.googlesource.com/1150939 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#579118} [modify] https://crrev.com/4dd5af999e56da3b75b067cd27948f0605bb47c9/tools/mb/mb_config.pyl
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f77466c6ce4fcbf076ac0e7b689f61442c27ef29 commit f77466c6ce4fcbf076ac0e7b689f61442c27ef29 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Jul 30 23:30:09 2018 Revert "Enable DCHECKs on amd64-generic simplechrome CQ bot." This reverts commit 4dd5af999e56da3b75b067cd27948f0605bb47c9. Reason for revert: Browser crashes flakily with DCHECKs on See https://chromium-swarm.appspot.com/task?id=3f063cbec4a26e10 https://chromium-swarm.appspot.com/task?id=3f063760c6162910 https://chromium-swarm.appspot.com/task?id=3f063164005d9710 Example crashes https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=e4fef843d0fef24b39d59d06bfddbe1569402f2b&as=chrome.PREVIOUS https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=4d98a300e399d97b4b02cf89f01134050e2f985e&as=chrome_20180730-160158 https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=a4068c05476b786213ab26a80cf35e426fd54f44&as=chrome_20180730-155114 Original change's description: > Enable DCHECKs on amd64-generic simplechrome CQ bot. > > Bug: 867077 > Change-Id: Icad4a62735d3be6579b3c6476bbbb65ad1843ec8 > Reviewed-on: https://chromium-review.googlesource.com/1150939 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579118} TBR=dpranke@chromium.org,dcastagna@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I42e28d289cd2c6604b829b9971abb0783fa5ee76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867077 Reviewed-on: https://chromium-review.googlesource.com/1155500 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#579231} [modify] https://crrev.com/f77466c6ce4fcbf076ac0e7b689f61442c27ef29/tools/mb/mb_config.pyl
,
Aug 1
This bug is morphing into "let's get DCHECKs turned on for CrOS". I made a new bug http://crbug.com/869904 to track that separately. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rjkroege@chromium.org
, Jul 24