New issue
Advanced search Search tips

Issue 867074 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 769507
issue 876509
issue 880635

Blocking:
issue 847992



Sign in to add a comment

Get tab dragging working with --mash

Project Member Reported by sky@chromium.org, Jul 24

Issue description

Tab dragging is likely broke in different ways for mash. Here's a list of things that need to be investigated:

. TabDragController needs to figure out what browser window is under the mouse at a given point. Code for this is window_finder_*, and is overly simplistic. I suspect the right thing to do for this is on every move have ash tell chrome what browser window is under the mouse (ash needs to tell chrome as in --mash chrome doesn't see all the windows, nor know z-order).

. When a tab is dragged into a new touch points and capture is transferred. I suspect this needs work.
 
Blockedon: 769507
Owner: mukai@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Regarding the touch / capture; I've noticed that both ash and browser-process have their own GestureRecognizer, and some internal states can be out of sync -- especially information like TransferEventsTo() aren't known to ash, which confuses WindowEventDispatcher. Those gestures and touch events need to be handled properly on ash.
Cc: msw@chromium.org sadrul@chromium.org
Mike it working on a bug with gestures in remote apps that may impact this: 867559.

You are indeed correct Mukai, that both ash and the browser have their own gesture recognizers, and the two may not be in sync. I think we'll need an api (likely on WindowTree) that clients can call that transfers the touch target from one window to another. The ash side would blindly reset state on the GestureRecognizer when asked to do so.
Just for a reminder for future me, the WindowEventDispatcher I mentioned in #3 is the dispatcher in ash; after the tab is detached through dragging, ash still receives touch events, calls PreDispatchTouchEvent, invokes GestureRecognizer (https://cs.chromium.org/chromium/src/ui/aura/window_event_dispatcher.cc?l=1052), and then gets failed there (because GestureRecognizer in ash doesn't know the previous touch events).
The transfer-gesture request needs to reach ash from browser, I think.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/904ad03c84dc25c39a0b4e875f7c5d03f7ee7292

commit 904ad03c84dc25c39a0b4e875f7c5d03f7ee7292
Author: Jun Mukai <mukai@chromium.org>
Date: Thu Aug 09 21:32:34 2018

Mash: propagate kAnimationsDisabled window property

Some windows, including tab-dragging window, want to suppress
the window animations. This property needs to be propagated
to Ash to take an effect.

BUG= 867074 
TEST=manually

Change-Id: I80847702e26cd04981cac71b02114389312d83e1
Reviewed-on: https://chromium-review.googlesource.com/1166331
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581896}
[modify] https://crrev.com/904ad03c84dc25c39a0b4e875f7c5d03f7ee7292/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/904ad03c84dc25c39a0b4e875f7c5d03f7ee7292/ui/aura/mus/property_converter.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c0f9aa861fdb9bc534829d3f764e2100cfff71c

commit 6c0f9aa861fdb9bc534829d3f764e2100cfff71c
Author: Jun Mukai <mukai@chromium.org>
Date: Sat Aug 11 01:09:55 2018

refine window finder for mash

Previously window_finder_chromeos (for mash) looks through the
list of the toplevel browser windows, but it is too simple and
doesn't work well on several cases.

This CL moves the window finding code to ash, and let WindowTree
notify the list of windows at the cursor to the client upon
window moving.

BUG= 867074 
TEST=ash_unittests

Change-Id: Ib44ad1a927a31c50cc108eee92ddba4d9bd918ee
Reviewed-on: https://chromium-review.googlesource.com/1159346
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582410}
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ash/BUILD.gn
[add] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ash/wm/window_finder.cc
[add] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ash/wm/window_finder.h
[add] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ash/wm/window_finder_unittest.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ash/ws/window_service_delegate_impl.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ash/ws/window_service_delegate_impl.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ash/ws/window_service_delegate_impl_unittest.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/chrome/browser/ui/views/tabs/DEPS
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/chrome/browser/ui/views/tabs/window_finder.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/chrome/browser/ui/views/tabs/window_finder.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/chrome/browser/ui/views/tabs/window_finder_chromeos.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/content/renderer/mus/renderer_window_tree_client.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/BUILD.gn
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/test_change_tracker.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/test_change_tracker.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/test_window_tree_client.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/test_window_tree_client.h
[add] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/topmost_window_observer.cc
[add] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/topmost_window_observer.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/window_service_delegate.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/window_service_delegate.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/window_tree.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/services/ui/ws2/window_tree.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ui/aura/BUILD.gn
[add] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ui/aura/mus/topmost_window_tracker.cc
[add] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ui/aura/mus/topmost_window_tracker.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/6c0f9aa861fdb9bc534829d3f764e2100cfff71c/ui/aura/test/mus/test_window_tree.h

Cc: mukai@chromium.org
 Issue 580704  has been merged into this issue.
Labels: Proj-Mash-SingleProcess
 Issue 769507  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f39058373ebf92009abf00228b77feefbf064ff1

commit f39058373ebf92009abf00228b77feefbf064ff1
Author: Jun Mukai <mukai@chromium.org>
Date: Fri Aug 17 20:10:32 2018

synchronize three props for tab-dragging for Mash

Those three boolean window properties are used both in ash (split
screens, overview mode, and tablet mode) and browser / tab-dragging.
They need to be synchronized.

ash::kTabDraggingSourceWindowKey also needs to be addressed for
the same reason, though the aura::Window* type requires some
additional complications. Another CL should deal with it.

Bug:  867074 
Test: none
Change-Id: I3f71b13322724cf20fbe103826532074c21c3c38
Reviewed-on: https://chromium-review.googlesource.com/1180094
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584167}
[modify] https://crrev.com/f39058373ebf92009abf00228b77feefbf064ff1/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/f39058373ebf92009abf00228b77feefbf064ff1/ash/public/interfaces/window_properties.mojom

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7ff1f35fc86e7cbd9171f07a1185bad9db28861

commit a7ff1f35fc86e7cbd9171f07a1185bad9db28861
Author: Jun Mukai <mukai@chromium.org>
Date: Tue Aug 21 18:24:36 2018

use root window for properties on tab-drag controller

Some properties are used to share the status between ash and
TabDragController; they are synchronized by crrev.com/584167,
but actually it isn't enough. Since ash expects these properties
are set on windows backed by Widget -- which is corresponded with
the root window in browser, TabDragController needs to set, clear,
and get the properties on root-window too instead of the widget.

Bug:  867074 
Test: manually
Change-Id: I501db87283c66a6d5c80f92aa4b333d93d0ae415
Reviewed-on: https://chromium-review.googlesource.com/1182409
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584843}
[modify] https://crrev.com/a7ff1f35fc86e7cbd9171f07a1185bad9db28861/chrome/browser/ui/views/tabs/tab_drag_controller.cc

Blockedon: 876509
The touch support is very complicated and hard to explain why some things are happening within my CL; for that purpose I noted a document https://docs.google.com/document/d/1AKeK8IuF-j2TJ-2sPsewORXdjnr6oAzy5nnR1zwrsfc/edit#

Please have a look and leave comments if things are unclear or wrong.
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54d7e70212cd3013a17c2f442374b0db06829c8

commit d54d7e70212cd3013a17c2f442374b0db06829c8
Author: Jun Mukai <mukai@chromium.org>
Date: Wed Aug 29 22:14:20 2018

check |current_move_loop_change_| earlier

I've seen DCHECK failures for on_current_move_finished_.is_null().
After debugging some, I've noticed that sometimes the window
is destroyed (thus in_flight_map_ clears its change_id) before
the callback is called. This means the ongoing window move never
finishes and the next attempt of window move causes DCHECK failures.

Bug:  867074 
Test: the new unit test
Change-Id: I9ed2d2b9aa79546c7175024a722c00924eba890d
Reviewed-on: https://chromium-review.googlesource.com/1195659
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587318}
[modify] https://crrev.com/d54d7e70212cd3013a17c2f442374b0db06829c8/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/d54d7e70212cd3013a17c2f442374b0db06829c8/ui/aura/mus/window_tree_client_unittest.cc

Blockedon: 880635
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff2c8260982fec358eb918169d847bd3e592173

commit 6ff2c8260982fec358eb918169d847bd3e592173
Author: Jun Mukai <mukai@chromium.org>
Date: Tue Sep 04 22:56:00 2018

synchronize ash::kTabDraggingSourceWindowKey

This is a aura::Window pointer property, which can't be transported
as other properties. This CL allows registering such properties to
PropertyConverter, and WindowTreeClient/WindowTree takes care of
converting between the transport data and aura::Window pointer.

Bug:  867074 
Test: manually
Change-Id: I3f3726264174b9291d2a779473ca5fae2d68266f
Reviewed-on: https://chromium-review.googlesource.com/1194789
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588682}
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ash/public/cpp/window_properties.h
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ash/public/interfaces/window_properties.mojom
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/BUILD.gn
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/public/cpp/property_type_converters.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/public/cpp/property_type_converters.h
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/public/mojom/window_manager.mojom
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/public/mojom/window_tree.mojom
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/window_tree.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/window_tree.h
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/services/ws/window_tree_unittest.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ui/aura/mus/property_converter.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ui/aura/mus/property_converter.h
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ui/aura/mus/property_converter_unittest.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ui/aura/mus/window_tree_client_unittest.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/6ff2c8260982fec358eb918169d847bd3e592173/ui/aura/test/mus/test_window_tree.h

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da

commit 35421cb5ddd7aa5d05b2ef4d46b75ee949c590da
Author: Jun Mukai <mukai@chromium.org>
Date: Wed Oct 03 19:51:49 2018

Introduce ui::GestureRecognizerObserver

This is phase-1 of tab-dragging with touch on Mash. This CL
adds GestureRecognizerObserver class, which will be used in
upcoming CLs.

BUG= 867074 
TEST=events_unittests

Change-Id: I7a8c50ac16b58e1c3e31c7f0d8df097489ee49c3
Reviewed-on: https://chromium-review.googlesource.com/c/1247101
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596333}
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ash/drag_drop/drag_drop_controller.cc
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/aura/gestures/gesture_recognizer_unittest.cc
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/BUILD.gn
[add] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer.cc
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer.h
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer_impl.cc
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer_impl.h
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer_impl_mac.cc
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer_impl_mac.h
[add] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer_impl_unittest.cc
[add] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer_observer.cc
[add] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_recognizer_observer.h
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/events/gestures/gesture_types.h
[modify] https://crrev.com/35421cb5ddd7aa5d05b2ef4d46b75ee949c590da/ui/views/controls/menu/menu_host.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db968f98da27ab616cda65681cf416764c78a159

commit db968f98da27ab616cda65681cf416764c78a159
Author: Jun Mukai <mukai@chromium.org>
Date: Thu Oct 04 18:53:52 2018

Reset gesture handling state on TransferEvents

This is phase-2 of tab-dragging with touch on Mash. Gesture
recognition keeps a flag to suppress emitting gesture events
once one of its touch event in the current event stream is
handled by someone else.

Without this change, some gesture events during tab-dragging
could be prevented on Mash, as described in
https://docs.google.com/document/d/1AKeK8IuF-j2TJ-2sPsewORXdjnr6oAzy5nnR1zwrsfc/edit#

BUG= 867074 
TEST=manually

Change-Id: I0186e58be2c3c42cc1070acb7a46e878b2b75981
Reviewed-on: https://chromium-review.googlesource.com/c/1247032
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596787}
[modify] https://crrev.com/db968f98da27ab616cda65681cf416764c78a159/ui/events/gesture_detection/filtered_gesture_provider.cc
[modify] https://crrev.com/db968f98da27ab616cda65681cf416764c78a159/ui/events/gesture_detection/filtered_gesture_provider.h
[modify] https://crrev.com/db968f98da27ab616cda65681cf416764c78a159/ui/events/gesture_detection/touch_disposition_gesture_filter.cc
[modify] https://crrev.com/db968f98da27ab616cda65681cf416764c78a159/ui/events/gesture_detection/touch_disposition_gesture_filter.h
[modify] https://crrev.com/db968f98da27ab616cda65681cf416764c78a159/ui/events/gestures/gesture_provider_aura.cc
[modify] https://crrev.com/db968f98da27ab616cda65681cf416764c78a159/ui/events/gestures/gesture_provider_aura.h
[modify] https://crrev.com/db968f98da27ab616cda65681cf416764c78a159/ui/events/gestures/gesture_recognizer_impl.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1892eaeba5c31f3bb7ffb4b6d5569689a30df410

commit 1892eaeba5c31f3bb7ffb4b6d5569689a30df410
Author: Jun Mukai <mukai@chromium.org>
Date: Tue Oct 09 23:23:58 2018

Synchronize GestureRecognizer status between Ash and browser

This is phase-3 of tab-dragging with touch on Mash. This adds
GestureSynchronizer in ui/aura/mus, which observes GestureRecognizer
and sends several mojo methods so that the GestureRecognizer
instance in Ash can be synchronized.

BUG= 867074 
TEST=aura_unittests

Change-Id: I9993897e3da6c282ebfbc1aa599162255b5944d6
Reviewed-on: https://chromium-review.googlesource.com/c/1247033
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598130}
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/services/ws/public/mojom/window_tree.mojom
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/services/ws/window_tree.cc
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/services/ws/window_tree.h
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/BUILD.gn
[add] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/mus/gesture_synchronizer.cc
[add] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/mus/gesture_synchronizer.h
[add] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/mus/gesture_synchronizer_unittest.cc
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/1892eaeba5c31f3bb7ffb4b6d5569689a30df410/ui/aura/test/mus/test_window_tree.h

Project Member

Comment 22 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/467bd6d15f367219aa0023cfae0964382a377212

commit 467bd6d15f367219aa0023cfae0964382a377212
Author: Jun Mukai <mukai@chromium.org>
Date: Tue Oct 16 01:58:08 2018

Enable tab-dragging with touch on Mash

This is the final phase of tab-dragging with touch on Mash.
This makes several changes to use the result of the previous
phases and achieve tab-dragging with touch on Mash.

BUG= 867074 
TEST=manually

Change-Id: I53239efbdf567754d3e9322b334d0a4e6751fa52
Reviewed-on: https://chromium-review.googlesource.com/c/1247034
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599820}
[modify] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/aura/BUILD.gn
[modify] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/aura/env.cc
[modify] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/aura/env.h
[add] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/aura/mus/gesture_recognizer_impl_mus.cc
[add] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/aura/mus/gesture_recognizer_impl_mus.h
[modify] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/aura/mus/window_tree_client_observer.h
[modify] https://crrev.com/467bd6d15f367219aa0023cfae0964382a377212/ui/views/mus/desktop_window_tree_host_mus.cc

Status: Fixed (was: Started)

Sign in to add a comment