The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/569f791a3e829132c9195df2716e746551d1bc29

commit 569f791a3e829132c9195df2716e746551d1bc29
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Nov 08 04:10:54 2018

History WebUI: add title for actions menu

Bug:  867065 
Change-Id: I05f3b8c4c1f313fa203302a0a27da5b002cedfe0
Reviewed-on: https://chromium-review.googlesource.com/c/1309219
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606334}
[modify] https://crrev.com/569f791a3e829132c9195df2716e746551d1bc29/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/569f791a3e829132c9195df2716e746551d1bc29/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/569f791a3e829132c9195df2716e746551d1bc29/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/569f791a3e829132c9195df2716e746551d1bc29/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/569f791a3e829132c9195df2716e746551d1bc29/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
[modify] https://crrev.com/569f791a3e829132c9195df2716e746551d1bc29/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Tried checking the issue on reported chrome version  69.0.3493.3 and on the latest chrome version 72.0.3606.0 using windows 10 with the below mentioned steps.
1. Enabled NVDA, navigated to chrome://history
2. Clicked on 'actions' for a random entry
3. Pressed Insert+t
We observed the screen reader read "History Google Chrome" in both the reported and latest mentioned versions.

@Esmael El-Moslimany: As we couldn't see any change in behaviour, could you please let us know if anything is being missed while checking. And requesting you to help us in verifying the fix.

Adding a title to the action menu introduces another issue where a tooltip can appear anywhere on the page.

After discussing offline with hcarmona@, moving the menu role up and adding an aria-label to the action menu will have the effect that screen readers will read "Actions menu" or "menu Actions" when the menu opens. This may be sufficient in that it will provide enough context for a screen reader user.

If it is necessary to add support for insert+t, I would need to investigate what can be done to accomplish that without introducing other issues.

Deleted: tooltip1.png 45.6 KB

	tooltip1.png 45.6 KB View Download

Deleted: tooltip2.png 44.7 KB

	tooltip2.png 44.7 KB View Download

Version 72.0.3611.0 (Official Build) canary (64-bit)
Version 72.0.3610.2 (Official Build) dev (64-bit)
NVDA version 2018.3.2
I am still able to repro this. the 'report title' command' only announces the title of the window instead of the menu.

In order to get the report title command to announce the title, it seems like a title would need to be added to the action menu which is implemented using a dialog that essentially spans the entire screen. This would introduce a tooltip with the action menu title anywhere the cursor hovers on the page (see the screenshots in comment 12).

If having the tooltip is show up like that is okay, then I can add the title. Otherwise, we can either not support the report title command or redesign the action menu in a way that would not span the entire screen (find another approach to detecting a click outside the menu in order to dismiss it).

Who is the key stakeholder of this issue? What direction is preferred here?

Also we have other action menus. This issue pertains only to the action menu in history. Do we plan to provide titles or labels to action menus on other pages?

This isn't really a dialog, it's a menu. That's pretty confusing right on its own. My recommendation is to fix that, and call it a menu so that the user knows what it really is. A menu doesn't necessarily need a title.

I'm a little confused about the markup. There is a <dialog id="dialog" tabindex="0"> and a child <div class="item-wrapper" tabindex="-1" role="menu">.
Do either of these get focus sometimes? 

From the a11y point of view, you only need one, and it doesn't need to be a dialog. One fix would be to remove the <dialog>, but I suspect that's doing something and it's a lot of work. The easier way probably is to put role="menu" on the dialog, and remove the role="menu" from the .item-wrapper element. You probably don't need tabindex on both.

@aleventhal: All action menus are implemented under the cover as <dialog> elements (via <cr-action-menu>). "Dialog" is just a native modal construct that the browser provides, which is very useful (simulating modal UIs in JS has been known to be very error prone in the past).

There should be a way to add the appropriate aria fields or other fields to make the cr-action-menu be properly accessible, without changing its implementation.

@aleventhal: This seems to be in line with your suggestion in comment 17 (moving the role="menu" to the dialog).

https://chromium-review.googlesource.com/c/chromium/src/+/1309219/9/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

When opening the menu, the screen reader reads the aria label and role. However insert+t does not read out "Actions", "Actions menu" or "Menu Actions".

I can look into why item-wrapper is there and the tabindex. How do they change how the role and aria attributes are interpreted?

As mentioned before, I can also add a title attribute on cr-action-menu which should be read out when insert+t is pressed. The drawback is the tooltip.

@aleventhal: if your suggestion is sufficient, and insert+t does not need to read Actions or Actions Menu, can I mark this issue fixed?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e22795e24979352c9f4a2920b95b8d40385ac53

commit 9e22795e24979352c9f4a2920b95b8d40385ac53
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Dec 05 22:56:03 2018

History WebUI: add aria-haspopup to history item menu button

Bug:  867065 
Change-Id: Ic41e3b2cea700b4dbac65728f6cd4e69be88f76c
Reviewed-on: https://chromium-review.googlesource.com/c/1363800
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614153}
[modify] https://crrev.com/9e22795e24979352c9f4a2920b95b8d40385ac53/chrome/browser/resources/md_history/history_item.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb8409caeec3639632463ae8087c239db3c8e943

commit cb8409caeec3639632463ae8087c239db3c8e943
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Dec 07 21:54:59 2018

WebUI: cr-action-menu, handle enter when no item has focus

In windows and mac, pressing enter closes the context menu. For linux,
pressing enter selects the first enabled menu item. This CL changes how
enter is handled for cr-action-menu to match the context menu behavior.

Bug:  867065 
Change-Id: Ie2f716526c50e7bd88476bd846de587f94fb58f8
Reviewed-on: https://chromium-review.googlesource.com/c/1363853
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614829}
[modify] https://crrev.com/cb8409caeec3639632463ae8087c239db3c8e943/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/cb8409caeec3639632463ae8087c239db3c8e943/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

@aleventhal: aria-haspopup was added to the three dot menu button. Also the cr-action-menu acts more like a native context menu when pressing enter after the menu is shown.