The swarming_dimensions fields are used to set builder-level defaults (e.g., "Win10" sets Windows-10-SP1).

These should really be set client-side in the //testing/buildbot/ files, but we don't do so consistently and would need to fix that before we can remove the build-side fields.

IIRC, `add_tests_as_compile_targets` exists because thakis wanted some bot to be sure that `ninja` by itself (with no targets) wouldn't break without us noticing.

However, given that the purpose of the chromium build system is not to unit-test ninja, I'm not sure I really feel the need to keep this use case in mind.

Even if I did, what I'd probably do instead would be to modify the call out to ninja to look to see if "all" was in the list of compile targets and, if so, just pass an empty list instead.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/99bde13c1012262f9d4faf798816344c6ed2259a

commit 99bde13c1012262f9d4faf798816344c6ed2259a
Author: Stephen Martinis <martiniss@chromium.org>
Date: Tue Jul 24 21:44:37 2018

chromium_tests: Remove use_swarming and use_isolate

These are always true now I think, so these flags can be removed.

Bug: 867054
Change-Id: I49188a11a31632cac38c616b4fb785180f1b0165
Reviewed-on: https://chromium-review.googlesource.com/1148932
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/99bde13c1012262f9d4faf798816344c6ed2259a/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/99bde13c1012262f9d4faf798816344c6ed2259a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/99bde13c1012262f9d4faf798816344c6ed2259a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/99bde13c1012262f9d4faf798816344c6ed2259a/scripts/slave/recipe_modules/chromium_tests/steps.py

That wasn't for ninja, it was to make sure the clang tot bots build everything. The "if targets is all then pass nothing" approach sounds fine to me.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/23690286d80db5b738a1554804d6bc33033f32fb

commit 23690286d80db5b738a1554804d6bc33033f32fb
Author: Stephen Martinis <martiniss@chromium.org>
Date: Tue Jul 24 23:31:11 2018

chromium_tests: Remove GYP_DEFINES config option

It seems to have no effect anymore.

Bug: 867054
Change-Id: Iee808047b19e34ed6b516526a18b42b5a3df2f64
Reviewed-on: https://chromium-review.googlesource.com/1148898
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/23690286d80db5b738a1554804d6bc33033f32fb/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py
[modify] https://crrev.com/23690286d80db5b738a1554804d6bc33033f32fb/scripts/slave/README.recipes.md
[modify] https://crrev.com/23690286d80db5b738a1554804d6bc33033f32fb/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py
[modify] https://crrev.com/23690286d80db5b738a1554804d6bc33033f32fb/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/update_clang.json
[modify] https://crrev.com/23690286d80db5b738a1554804d6bc33033f32fb/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/23690286d80db5b738a1554804d6bc33033f32fb/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/23690286d80db5b738a1554804d6bc33033f32fb/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py

An update!

swarming_dimensions seems to be used by webrtc. I don't know if there's an alternative for them to use this. We can remove the uses of it from the actual chromium_tests module, but I'm not sure if we can remove the setting entirely.

I'm also tentatively adding 'src_side_runtest_py' to the list to be removed. I think this isn't really being used anywhere, and everything should probably be using the source side script anyways. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1ccebdedb51b80c6471ba14b88466c1a8b62939c

commit 1ccebdedb51b80c6471ba14b88466c1a8b62939c
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Aug 10 00:03:55 2018

Remove 'internal_gles2_conform_tests' setting

Led-Recipes-Tester-Builder: luci.chromium.try:win_angle_rel_ng
Bug: 867054
Change-Id: Ibf6692426779a3e3aae17f369cc3613b227d70fb
Reviewed-on: https://chromium-review.googlesource.com/1161457
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/1ccebdedb51b80c6471ba14b88466c1a8b62939c/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/1ccebdedb51b80c6471ba14b88466c1a8b62939c/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/1ccebdedb51b80c6471ba14b88466c1a8b62939c/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/1ccebdedb51b80c6471ba14b88466c1a8b62939c/scripts/slave/recipe_modules/chromium/tests/configs.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84f3159911aa310c24a59a6b1184c9569b2bea9d

commit 84f3159911aa310c24a59a6b1184c9569b2bea9d
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon Aug 27 21:37:08 2018

Force tests to use source side runtest.py

Nothing seems to use non source side runtest.py (it passed CQ dry run,
and nothing seems to set this variable to false in recipes), so this
should be safe to do.

Bug: 867054
Change-Id: I95e1423c520509357b58e5178ea929b576d315ba
Reviewed-on: https://chromium-review.googlesource.com/1166287
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586423}
[modify] https://crrev.com/84f3159911aa310c24a59a6b1184c9569b2bea9d/testing/scripts/common.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d2dba82b10996ee352e96e7213d60f35cbb8516e

commit d2dba82b10996ee352e96e7213d60f35cbb8516e
Author: Stephen Martinis <martiniss@chromium.org>
Date: Thu Aug 30 00:52:08 2018

Remove 'src_side_runtest_py' setting

This is now useless, https://crrev.com/c/1166287 forced chromium tests to use
the source side script always.

Bug: 867054
Change-Id: I11affcf5632a9341fee082236720e8d20657950c
Reviewed-on: https://chromium-review.googlesource.com/1195905
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_bad_output.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_no_json.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/tests/runtest.expected/python_mode.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_not_bisect.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/update_components.expected/script_error.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/compile_skipped.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux_new.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_script_test_with_args.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/flake.expected/record_infra_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/examples/full.expected/mac_basic.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_non-swarming_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.expected/basic.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_goma_module_ping_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_recipes.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/isolated_script_test_invalid_results_handler.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/tests/runtest.expected/annotate.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_unknown_json_results.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_bisect.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/tests/runtest.expected/tsan.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/webkit_layout_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_second_sub_range.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_error_code.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/first_revision_of_entire_range_failed_but_is_not_culprit.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/android.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/examples/full.expected/mac_toolchain.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_ninja_no_op_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_isolate_only.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/nonexistent_test_step_skipped.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/compile_default_targets.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_setup_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/test_without_targets_not_skipped.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/mac.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/update_components.expected/addition.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_goma_module_build_failure.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets_from_parameter.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/chromium_android.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_without_compile_py.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/gtest_bad_custom_merge_script.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_directory_does_not_exist.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/tests/runtest.expected/lsan.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/examples/full.expected/chromeos_simplechrome.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_using_bisect.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/tests/runtest.py
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium/tests/runtest.expected/android.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_disabled.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/no_compile_no_source.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/update_components.expected/no_change.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic_luci.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_android.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_valid.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/d2dba82b10996ee352e96e7213d60f35cbb8516e/script

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b

commit cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Nov 02 23:42:20 2018

Remove swarming tags from triggered tasks

These are only being to add memory sanitization information (tsan, asan)
right now, and that team seems to think this isn't used anywhere. Should
be safe to delete.

Bug: 867054
Change-Id: Ie31c7beb3163e4ab30c95a7bdce06f16cff90195
Reviewed-on: https://chromium-review.googlesource.com/c/1316507
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/README.recipes.md
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/cb9af9ef2bd06fb4fcf45573324708ea3ee35a6b/scripts/slave/recipe_modules/chromium_tests/tests/api/swarming_details.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f0f98fff071ed8e8cddf2e32c79c934eddbbb8ee

commit f0f98fff071ed8e8cddf2e32c79c934eddbbb8ee
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon Nov 05 18:40:38 2018

Remove android_apply_config values

These builders have been converted to swarming, so these config settings
do nothing in these builds.

Bug: 867054
Change-Id: I901d01ae3008479a678a029db92eb1f8f66a60ce
Reviewed-on: https://chromium-review.googlesource.com/c/1318289
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/f0f98fff071ed8e8cddf2e32c79c934eddbbb8ee/scripts/slave/recipe_modules/chromium_tests/chromium_android.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/23e6b94efe164a6de619dbc3ccf98e6b9d6e9b0f

commit 23e6b94efe164a6de619dbc3ccf98e6b9d6e9b0f
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Nov 15 21:16:14 2018

Remove 'extra_got_revision_properties'

It seems to not be doing anything; I don't see the property which should
be doing something in
https://ci.chromium.org/p/chromium/builders/luci.chromium.webrtc.fyi/WebRTC%20Chromium%20FYI%20Android%20Builder/1084
so I assume this silently broke and no one noticed.

Bug: 867054
Change-Id: I11ed3a23d14b24d5c96e6d8fcc38fb175ebad0b5
Reviewed-on: https://chromium-review.googlesource.com/c/1313776
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/23e6b94efe164a6de619dbc3ccf98e6b9d6e9b0f/scripts/slave/README.recipes.md
[modify] https://crrev.com/23e6b94efe164a6de619dbc3ccf98e6b9d6e9b0f/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
[modify] https://crrev.com/23e6b94efe164a6de619dbc3ccf98e6b9d6e9b0f/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/23e6b94efe164a6de619dbc3ccf98e6b9d6e9b0f/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_tester.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/403d7815db80ef21b52f198db3848f72a772eb29

commit 403d7815db80ef21b52f198db3848f72a772eb29
Author: Stephen Martinis <martiniss@chromium.org>
Date: Sat Dec 15 00:35:49 2018

Switch to using test_api function for test spec

Needed in preparation for https://crrev.com/c/1377670, but also useful on
its own.

Bug: 867054
Change-Id: Ib048145393f7ca957c87a64b528a7af53e0d7fd8
Reviewed-on: https://chromium-review.googlesource.com/c/1378875
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/findit/chromium/flake.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/findit/chromium/compile_isolate.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/pinpoint/builder.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/swarming/staging.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/findit/chromium/test.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/findit/chromium/compile.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipe_modules/chromium_tests/test_api.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipes/chromium_trybot.py
[modify] https://crrev.com/403d7815db80ef21b52f198db3848f72a772eb29/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.py