New issue
Advanced search Search tips

Issue 867029 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue webrtc:9522



Sign in to add a comment

Transfer WebRTC color space information to chromium color space

Project Member Reported by emir...@chromium.org, Jul 24

Issue description

WebRTC now extracts color space from bitstream for SW decoded video. Once these changes roll into Chromium, we should transfer this info to media::VideoFrame.
https://cs.chromium.org/chromium/src/third_party/webrtc/api/video/color_space.h?q=api/video/color_space.h&sq=package:chromium&dr
 
Summary: Transfer WebRTC color space information to chromium color space (was: Transfer WebRTC color space information to Chrome)
I remember we couldn't get any repro of that issue. I don't think it would be related because we again would use the default color space for these frames as we dont have color space specified within bitsream, resulting in the same behavior.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2069a897512f576454763b85a5a4dc4ed83ed43

commit e2069a897512f576454763b85a5a4dc4ed83ed43
Author: Emircan Uysaler <emircan@chromium.org>
Date: Mon Jul 30 22:29:26 2018

Transfer WebRTC color space information to chromium color space

This CL adds functionality to convert webrtc::ColorSpace info into chromium's
media::VideoColorSpace and sets it in remote video receiver.

Bug:  867029 
Change-Id: I175fcb6eb0f7918c510b7ff4f355aa300a89473c
Reviewed-on: https://chromium-review.googlesource.com/1154030
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579202}
[modify] https://crrev.com/e2069a897512f576454763b85a5a4dc4ed83ed43/content/renderer/BUILD.gn
[modify] https://crrev.com/e2069a897512f576454763b85a5a4dc4ed83ed43/content/renderer/media/stream/media_stream_video_track.h
[modify] https://crrev.com/e2069a897512f576454763b85a5a4dc4ed83ed43/content/renderer/media/webrtc/media_stream_remote_video_source.cc
[modify] https://crrev.com/e2069a897512f576454763b85a5a4dc4ed83ed43/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[add] https://crrev.com/e2069a897512f576454763b85a5a4dc4ed83ed43/content/renderer/media/webrtc/webrtc_video_utils.cc
[add] https://crrev.com/e2069a897512f576454763b85a5a4dc4ed83ed43/content/renderer/media/webrtc/webrtc_video_utils.h

Status: Fixed (was: Assigned)
Labels: M-70

Sign in to add a comment