New issue
Advanced search Search tips

Issue 867027 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Expire all the observations in the local Site Characteristics Database.

Project Member Reported by sebmarchand@chromium.org, Jul 24

Issue description

There's been some changes on how some of the heuristics tracked in the Local Site Characteristics database are recorded. These changes require that we clear the current instances of this database, a version number will also be added to the database.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7

commit ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Wed Jul 25 15:58:05 2018

RC: Upgrade the DB version to 1

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug:  773382 , 866540,  867027 
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577912}
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc

Labels: -Pri-3 M-69 Merge-Request-69 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Requesting to merge this into M69.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 26

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week last M69 Dev release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2574bbe7aae1c9fde4043276bf94f5229a5add02

commit 2574bbe7aae1c9fde4043276bf94f5229a5add02
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jul 27 04:00:26 2018

RC: Upgrade the DB version to 1

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug:  773382 , 866540,  867027 
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577912}(cherry picked from commit ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7)
Reviewed-on: https://chromium-review.googlesource.com/1152667
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#139}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment