New issue
Advanced search Search tips

Issue 867023 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Jul 25
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Settings: a11y, make Allow and Block site lists navigable with arrows

Project Member Reported by aee@chromium.org, Jul 24 
Some lists in settings pages make use of a combination of iron-list and the FocusRowBehavior which provides a better a11y experience.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc566d1c1a2d8da82ccce610b153f3b54524eab4

commit fc566d1c1a2d8da82ccce610b153f3b54524eab4
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Jul 25 00:26:02 2018

Settings: site-list, use iron-list for a11y

Bug:  867023 
Change-Id: Iacb0e3a1a5083d6f35564f4b0e3c6c9590c576d1
Reviewed-on: https://chromium-review.googlesource.com/1145775
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577743}
[modify] https://crrev.com/fc566d1c1a2d8da82ccce610b153f3b54524eab4/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/fc566d1c1a2d8da82ccce610b153f3b54524eab4/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/fc566d1c1a2d8da82ccce610b153f3b54524eab4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/fc566d1c1a2d8da82ccce610b153f3b54524eab4/chrome/browser/resources/settings/site_settings/site_list.js
[add] https://crrev.com/fc566d1c1a2d8da82ccce610b153f3b54524eab4/chrome/browser/resources/settings/site_settings/site_list_entry.html
[add] https://crrev.com/fc566d1c1a2d8da82ccce610b153f3b54524eab4/chrome/browser/resources/settings/site_settings/site_list_entry.js
[modify] https://crrev.com/fc566d1c1a2d8da82ccce610b153f3b54524eab4/chrome/test/data/webui/settings/site_list_tests.js

Comment 2 by aee@chromium.org, Jul 25

Status: Fixed (was: Started)
►

Sign in to add a comment