Simple Chrome flow: Building all available build targets is broken |
||
Issue description
N.B: This issue sidesteps the NaCl target being broken using enable_nacl=false.
$ cros chrome-sdk --board=eve --gn-extra-args="enable_nacl=false"
<now inside cros shell>
$ autoninja -C out_${SDK_BOARD}/Release
This build command should succeed, but several targets are currently broken. I'll list the broken targets in this bug and add more if I find any.
* remoting/host/linux:x11
* remoting/client/display:unit_tests
* remoting/host/linux:unit_tests
* remoting/test:ar_sample_test_driver
* ui/base:ui_base_unittests
* chrome/installer/linux:calculate_deb_dependencies
I have tentative fixes for each of these targets, but they may not be the correct fixes.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e65bd550ef79839757096bbb5e68054e889a15e1 commit e65bd550ef79839757096bbb5e68054e889a15e1 Author: James Hawkins <jhawkins@chromium.org> Date: Wed Jul 25 20:52:35 2018 remoting/host: Fix the cros chrome-sdk build. Guard the x11 source_set behind the use_x11 option. R=yuweih@chromium.org Bug: 867013 Test: none Change-Id: I378652631f42609843b5a7f32d26bacccd63b5a6 Reviewed-on: https://chromium-review.googlesource.com/1150637 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578054} [modify] https://crrev.com/e65bd550ef79839757096bbb5e68054e889a15e1/remoting/host/linux/BUILD.gn
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d9776b560ad9a51f9b244d125096b755bf82fe8 commit 5d9776b560ad9a51f9b244d125096b755bf82fe8 Author: James Hawkins <jhawkins@chromium.org> Date: Thu Jul 26 14:14:35 2018 ui/base/ime: Fix the cros chrome-sdk build. This change removes unused X11 includes, which fixes the ui/base:ui_base_unittests target on the cros chrome-sdk shell build. R=yhanada@chromium.org Bug: 867013 Test: none Change-Id: I42f1d1e72f9cbe35ca585764db19353e8721bfbc Reviewed-on: https://chromium-review.googlesource.com/1150507 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578290} [modify] https://crrev.com/5d9776b560ad9a51f9b244d125096b755bf82fe8/ui/base/ime/input_method_chromeos_unittest.cc
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c614c6ab9c9549d0856930875cbc78f14d4c5497 commit c614c6ab9c9549d0856930875cbc78f14d4c5497 Author: James Hawkins <jhawkins@chromium.org> Date: Thu Jul 26 16:38:08 2018 chrome/installer: Fix the cros chrome-sdk build. The target chrome/installer/linux:calculate_deb_dependencies is broken in the cros chrome-sdk shell build because is_linux is true in addition to is_chromeos. This change prevents the linux installer from being enabled when is_chromeos is true. R=gab@chromium.org Bug: 867013 Test: none Change-Id: I1596177528c35a4670fad52e62d56ad0ba104a16 Reviewed-on: https://chromium-review.googlesource.com/1150443 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578336} [modify] https://crrev.com/c614c6ab9c9549d0856930875cbc78f14d4c5497/chrome/installer/BUILD.gn
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/477e8db3fc55789f03927029010cdd4113988e93 commit 477e8db3fc55789f03927029010cdd4113988e93 Author: James Hawkins <jhawkins@chromium.org> Date: Wed Aug 01 20:51:06 2018 remoting/client: Fix the cros chrome-sdk build. The target remoting/test:ar_sample_test_driver is broken because the //ui/gl dependency is missing (for GL headers) and the GL lib was being added for the is_chromeos build (the cros chrome-sdk build does not have libGL). R=yuweih@chromium.org Bug: 867013 Test: none Change-Id: I409d9540ff3cb2ce6cb2c2d570e3441d1f80c7ee Reviewed-on: https://chromium-review.googlesource.com/1150510 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#579929} [modify] https://crrev.com/477e8db3fc55789f03927029010cdd4113988e93/remoting/BUILD.gn [modify] https://crrev.com/477e8db3fc55789f03927029010cdd4113988e93/remoting/client/BUILD.gn [modify] https://crrev.com/477e8db3fc55789f03927029010cdd4113988e93/remoting/client/display/BUILD.gn [modify] https://crrev.com/477e8db3fc55789f03927029010cdd4113988e93/remoting/client/ui/BUILD.gn
,
Aug 1
With enable_nacl=false, the cros chrome-sdk now successfully builds all targets. The enable_nacl issue is tracked at crbug.com/826067. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 25