New issue
Advanced search Search tips

Issue 867008 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Support querying the list of network interfaces and listening for changes

Project Member Reported by xunji...@chromium.org, Jul 24

Issue description

We need a mojo version of net::GetNetworkList() in network service,
and convert the following embedders:
- extensions/browser/api/socket/socket_api.cc
- content/browser/renderer_host/pepper/pepper_network_monitor_host.cc
- chrome/browser/printing/cloud_print/privet_traffic_detector.cc
- chrome/browser/media/webrtc/webrtc_text_log_handler.cc
- chrome/browser/media/router/discovery/dial/dial_service.cc




https://cs.chromium.org/chromium/src/net/base/network_interfaces_linux.cc?l=213&gs=kythe%253A%252F%252Fchromium%253Flang%253Dc%25252B%25252B%253Fpath%253Dsrc%252Fnet%252Fbase%252Fnetwork_interfaces_linux.cc%2523wUnN30iU39MPs3u3TtRPZSQcCLs7dZAyIsYcmGFIKO0%25253D&gsn=GetNetworkList&ct=xref_usages

 
Labels: -Pri-1 Pri-2
Status: Available (was: Untriaged)
Owner: dougt@chromium.org
Status: Assigned (was: Available)
Owner: cmumford@chromium.org
Punting all P2s. we will fix this post canary.
Labels: -Proj-Servicification-Canary Proj
Labels: -Proj Proj-Servicification
Labels: hotlist-knon
Labels: Hotlist-KnownIssue
Labels: -Hotlist-KnownIssue
Labels: -hotlist-knon Proj-Servicification-Stable Hotlist-KnownIssue
Owner: ----
Status: Available (was: Assigned)
Owner: ayui@chromium.org
Status: Started (was: Available)
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/958a568243e1a1313e72651e6e6dfa1f9a7cd938

commit 958a568243e1a1313e72651e6e6dfa1f9a7cd938
Author: Ayu Ishii <ayui@chromium.org>
Date: Mon Jan 14 19:12:44 2019

Convert NetworkInterface struct from legacy [Native] definition.

Moved out of p2p.mojom so it can be used for another interface,
as a part of creating a mojo version of net::GetNetworkList()

Bug: 867008
Change-Id: Idee2006b3307903312251e2524ab6648be382118
Reviewed-on: https://chromium-review.googlesource.com/c/1403931
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622544}
[add] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/cpp/network_interface.typemap
[add] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/cpp/network_interface_mojom_traits.cc
[add] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/cpp/network_interface_mojom_traits.h
[modify] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/cpp/p2p.typemap
[modify] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/cpp/p2p_param_traits.h
[modify] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/cpp/typemaps.gni
[modify] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/mojom/BUILD.gn
[add] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/mojom/network_interface.mojom
[modify] https://crrev.com/958a568243e1a1313e72651e6e6dfa1f9a7cd938/services/network/public/mojom/p2p.mojom

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Sign in to add a comment