New issue
Advanced search Search tips

Issue 867003 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add braveyao as OWNERS in desktopCapture related logic in Chromium

Project Member Reported by braveyao@chromium.org, Jul 24

Issue description

OWNERS files in various folders need to be updated to add braveyao@chromium.org
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/631d819226c792891095155d8f8c670c6b8aa443

commit 631d819226c792891095155d8f8c670c6b8aa443
Author: Weiyong Yao <braveyao@chromium.org>
Date: Fri Jul 27 23:45:12 2018

Add braveyao as OWNERS in desktopCapture related logic in Chromium

Bug:  867003 
Change-Id: I2ef56eeafcee60f23fbd2d67fb3193eb9cd360d4
Reviewed-on: https://chromium-review.googlesource.com/1148694
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578863}
[modify] https://crrev.com/631d819226c792891095155d8f8c670c6b8aa443/chrome/browser/extensions/api/desktop_capture/OWNERS
[modify] https://crrev.com/631d819226c792891095155d8f8c670c6b8aa443/chrome/browser/media/webrtc/OWNERS
[modify] https://crrev.com/631d819226c792891095155d8f8c670c6b8aa443/content/browser/media/capture/OWNERS

Comment 2 Deleted

Comment 3 Deleted

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/61c8bd456012100727440e63b77fbf3f9982127c

commit 61c8bd456012100727440e63b77fbf3f9982127c
Author: braveyao <braveyao@webrtc.org>
Date: Wed Sep 05 17:42:26 2018

desktopCapture: add braveyao@webrtc.org as OWNER

Add braveyao@webrtc.org as OWNER of desktop_capture/

Bug:  chromium:867003 
Change-Id: Iea171adca2e2c75c241b4aeb332def36be181bf8
Reviewed-on: https://webrtc-review.googlesource.com/98221
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Brave Yao <braveyao@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24588}
[modify] https://crrev.com/61c8bd456012100727440e63b77fbf3f9982127c/modules/desktop_capture/OWNERS

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68a35fc7ca051d1b12187cb405d688c864d9d4b7

commit 68a35fc7ca051d1b12187cb405d688c864d9d4b7
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Sep 05 23:59:19 2018

Roll src/third_party/webrtc 62228c41ea17..b9bb9e3f6683 (10 commits)

https://webrtc.googlesource.com/src.git/+log/62228c41ea17..b9bb9e3f6683


git log 62228c41ea17..b9bb9e3f6683 --date=short --no-merges --format='%ad %ae %s'
2018-09-05 buildbot@webrtc.org Roll chromium_revision 4d01f290d4..87a4e8f8a7 (588344:588971)
2018-09-05 julien.isorce@chromium.org ScreenCapturerMac: make sure the desktop frame is zero initiaziled
2018-09-05 braveyao@webrtc.org desktopCapture: add braveyao@webrtc.org as OWNER
2018-09-05 danilchap@webrtc.org Add RtcpTransceiver::Stop to allow non-blocking destruction
2018-09-05 sakal@webrtc.org Add support for platform software video decoder implementations.
2018-09-05 mbonadei@webrtc.org Introduce GN arg rtc_exclude_metrics_default.
2018-09-05 danilchap@webrtc.org in RtpPacketizer add support for first packet reduction length
2018-09-05 magjed@webrtc.org Reland "Reland "Update video_quality_analysis to align videos instead of using barcodes""
2018-09-05 brandtr@webrtc.org Remove deprecated VideoEncoder.Settings constructor.
2018-09-05 sprang@webrtc.org Clean away WebRTC-Vp8DontDropKeyFrames switch


Created with:
  gclient setdep -r src/third_party/webrtc@b9bb9e3f6683

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:867003
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If34680549d9e4ac36e11fc8a86f192c208d636ea
Reviewed-on: https://chromium-review.googlesource.com/1208296
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589067}
[modify] https://crrev.com/68a35fc7ca051d1b12187cb405d688c864d9d4b7/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a6c07ef2c6fcf75845b34fbe237a106e9565273

commit 6a6c07ef2c6fcf75845b34fbe237a106e9565273
Author: braveyao <braveyao@chromium.org>
Date: Fri Sep 07 16:22:20 2018

Take more ownership of desktop capture realted files

Make braveyao own more desktop capture related files under
chrome/browser/media/webrtc, majorly including the new files added for
the getDisplayMedia() API.

Bug:  867003 
Change-Id: Id1e310dc42ff8473c79d0f41de388fcb64597a56
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1212097
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589540}
[modify] https://crrev.com/6a6c07ef2c6fcf75845b34fbe237a106e9565273/chrome/browser/media/webrtc/OWNERS

Status: Fixed (was: Started)

Sign in to add a comment