New issue
Advanced search Search tips

Issue 866988 link

Starred by 1 user
Status: Fixed
Owner:
sdy@chromium.org
Closed: Jul 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

"Not implemented reached in ui::EventType ui::EventTypeFromNative" appears frequently in dev builds

Project Member Reported by sdy@chromium.org, Jul 24 
Chrome Version: 70.0.3501.0
OS: macOS 10.13.6

What steps will reproduce the problem?
(1) Run a local copy of Chrome on a machine with a trackpad (or, possibly a Magic Mouse).
(2) Use the trackpad to interact with Chrome for a bit.

What is the expected result?
No log output.

What happens instead?
Lots of lines like:

    [53596:775:0724/135746.993576:ERROR:events_mac.mm(66)] Not implemented reached in ui::EventType ui::EventTypeFromNative(const ui::PlatformEvent &)29
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19d339e6db10af4e46d2f956fb7877eba0e9c4b7

commit 19d339e6db10af4e46d2f956fb7877eba0e9c4b7
Author: Sidney San Martín <sdy@chromium.org>
Date: Wed Jul 25 18:06:46 2018

Only call NOTIMPLEMENTED() for unknown event types, not ignored ones.

Bug:  866988 
Change-Id: I91084c1f34049d1b4aafdc2f1095ac30efe45fea
Reviewed-on: https://chromium-review.googlesource.com/1148702
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577973}
[modify] https://crrev.com/19d339e6db10af4e46d2f956fb7877eba0e9c4b7/ui/events/cocoa/events_mac.mm

Comment 2 by sdy@chromium.org, Jul 25

Status: Fixed (was: Assigned)
►

Sign in to add a comment