Issue metadata
Sign in to add a comment
|
1.7%-66.7% regression in system_health.common_desktop at 576859:576986 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 24
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11e3ab4da40000
,
Jul 24
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11e3ab4da40000 Add a universal wait-for-page-ready heuristic to the Autofill Captured Sites Interactive Uitest. by uwyiming@google.com https://chromium.googlesource.com/chromium/src/+/dd60b0b2896699f093771630d10c184e50279b94 0.06925 → 0.1003 (+0.03102) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jul 27
This turned out to be a bad bug because it causes two blink updates per frame. The issue is that DidCommitAndDrawFrame is causing SendCommitRequestToImplThreadIfNeeded to be called: cc::ProxyMain::SendCommitRequestToImplThreadIfNeeded(cc::ProxyMain::CommitPipelineStage) + 64 cc::ProxyMain::SetNeedsAnimate() + 336 cc::LayerTreeHost::SetNeedsAnimate() + 63 cc::LayerTreeHost::QueueSwapPromise(std::__1::unique_ptr<cc::SwapPromise, std::__1::default_delete< content::LayerTreeView::QueueSwapPromise(std::__1::unique_ptr<cc::SwapPromise, std::__1::default_delete content::RenderWidget::QueueMessage(IPC::Message*, content::MessageDeliveryPolicy) + 851 content::RenderWidget::DidCommitAndDrawCompositorFrame() + 499 content::LayerTreeView::DidCommitAndDrawFrame() + 26 cc::LayerTreeHost::DidCommitAndDrawFrame() + 26 cc::ProxyMain::DidCommitAndDrawFrame() + 203 Yiming is going to remove the queue'd message for now and investigate a different approach.
,
Jul 27
@sullivan, can I remove Restrict-View-Google?
,
Jul 27
Removed. It was on there because one of the new bots was accidentally marked internal-only (all this data should be public)
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0d7951f253c73c2678c83af541481bb34276a40 commit f0d7951f253c73c2678c83af541481bb34276a40 Author: Yiming Zhou <uwyiming@google.com> Date: Fri Jul 27 21:18:55 2018 Remove queuing the DidCommitAndDrawCompositorFrame message. This change removes queuing the DidCommitAndDrawCompositorFrame message when Chrome commits a paint update. Queuing the message causes an additional blink update, resulting in a serious performance regression. The original intent of queuing the DidCommitAndDrawCompositorFrame message is to notify the WebContents when Chrome performs a paint, which in turn helps Chrome's experimental capture sites automation test framework. Since this performance regression is particularly large, and the absence of this event only impacts the test framework, we decide to remove queuing the message for now. Bug: 866981 Change-Id: I20e6fa6dbe1fd30f1529d6dda20e6208ae719bd1 Reviewed-on: https://chromium-review.googlesource.com/1153594 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578800} [modify] https://crrev.com/f0d7951f253c73c2678c83af541481bb34276a40/content/renderer/render_widget.cc
,
Jul 28
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 24