Toolbar transparency with custom theme |
|||||||||
Issue descriptionToolbar layout issue - overlapping icons and "about:blank" Encountered on Chrome OS 68.0.3440.70 beta; see attached image. I imagine this has already been fixed, but hope someone can verify.
,
Jul 25
,
Aug 8
fyi I couldn't repro -- on Windows 67 or Mac 68 though, don't have a Cros 68 device. Tentatively to estade@ but please unaccept if you can't repro there.
,
Aug 9
Okay, I'm going to reopen this, it looks like the toolbar is transparent. Google Chrome 68.0.3440.76 (Official Build) beta (64-bit) Peter, perhaps you know a better owner related to themeing and transparency?
,
Aug 9
,
Aug 9
I'm sheriff right now + heavily bandwidth-constrained due to the impending M69 release, and I don't have a CrOS environment to test in. Any chance you can bisect this? If we can get a relevant CL I'm sure we can fix :)
,
Aug 9
I'll have a look soon
,
Aug 9
I tried to bisect, but all my renderers are crashing; I filed Issue 872783 .
,
Aug 9
Mike, are you sure this a regression? I have a fix here[1] but I sort of doubt this ever worked properly. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1169807
,
Aug 9
I'm pretty sure the user only noticed this issue recently, but perhaps they changed themes recently?
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2 commit eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2 Author: Evan Stade <estade@chromium.org> Date: Fri Aug 10 21:51:10 2018 Browser Themes: always paint an opaque BG color behind toolbar images for both the active tab and the toolbar. This matches the bookmarks bar, i.e. PaintBackgroundAttachedMode. Bug: 866974 Change-Id: I3a86d2330bf09903f74359e433a4165e3e4d3e8e Reviewed-on: https://chromium-review.googlesource.com/1171216 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582350} [modify] https://crrev.com/eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2/chrome/browser/ui/views/toolbar/toolbar_view.cc
,
Aug 13
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by est...@chromium.org
, Jul 24