New issue
Advanced search Search tips

Issue 866974 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Toolbar transparency with custom theme

Project Member Reported by msw@chromium.org, Jul 24

Issue description

Toolbar layout issue - overlapping icons and "about:blank"

Encountered on Chrome OS 68.0.3440.70 beta; see attached image.
I imagine this has already been fixed, but hope someone can verify.
 
Screenshot 2018-07-23 at 9.24.54 PM.png
343 KB View Download
not sure; what theme is that? My recent frame related work shouldn't have made it into 68.
Components: UI>Browser>Omnibox
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
fyi I couldn't repro -- on Windows 67 or Mac 68 though, don't have a Cros 68 device.

Tentatively to estade@ but please unaccept if you can't repro there.

Comment 5 Deleted

Labels: M-68
Owner: pkasting@chromium.org
Status: Assigned (was: WontFix)
Okay, I'm going to reopen this, it looks like the toolbar is transparent.
Google Chrome 68.0.3440.76 (Official Build) beta (64-bit)
Peter, perhaps you know a better owner related to themeing and transparency?
theme_transparency.png
457 KB View Download
Components: UI>Browser>Themes
Summary: Toolbar transparency with custom theme (was: Toolbar layout issue - overlapping icons and "about:blank")
Labels: Needs-Bisect
I'm sheriff right now + heavily bandwidth-constrained due to the impending M69 release, and I don't have a CrOS environment to test in.  Any chance you can bisect this?  If we can get a relevant CL I'm sure we can fix :)
Owner: est...@chromium.org
I'll have a look soon
I tried to bisect, but all my renderers are crashing; I filed  Issue 872783 .
Status: Started (was: Assigned)
Mike, are you sure this a regression? I have a fix here[1] but I sort of doubt this ever worked properly.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1169807
I'm pretty sure the user only noticed this issue recently, but perhaps they changed themes recently?
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2

commit eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2
Author: Evan Stade <estade@chromium.org>
Date: Fri Aug 10 21:51:10 2018

Browser Themes: always paint an opaque BG color behind toolbar images

for both the active tab and the toolbar. This matches the bookmarks
bar, i.e. PaintBackgroundAttachedMode.

Bug:  866974 
Change-Id: I3a86d2330bf09903f74359e433a4165e3e4d3e8e
Reviewed-on: https://chromium-review.googlesource.com/1171216
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582350}
[modify] https://crrev.com/eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2/chrome/browser/ui/views/toolbar/toolbar_view.cc

Status: Fixed (was: Started)

Sign in to add a comment