New issue
Advanced search Search tips

Issue 866965 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 678905
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

external/wpt/service-workers/service-worker/interfaces-sw.https.html tests failing on WebKit Linux Trusty MSAN

Project Member Reported by imch...@chromium.org, Jul 24

Issue description

The following tests started failing on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9060:

* virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/interfaces-sw.https.html
* virtual/outofblink-cors/external/wpt/service-workers/service-worker/interfaces-sw.https.html
* virtual/service-worker-servicification/external/wpt/service-workers/service-worker/interfaces-sw.https.html

Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1148224. Going to update TestExpectations for now. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d2c5baa0918dd97166b30339849b624e2fd74b

commit 92d2c5baa0918dd97166b30339849b624e2fd74b
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Jul 24 18:51:16 2018

[Sheriff] Mark 3 service-worker layout tests as Timeout on Linux.

TBR=foolip@chromium.org

Bug:  866965 
Change-Id: If4b3f8c350b4677490f2ad72d47d12437d82c77d
Reviewed-on: https://chromium-review.googlesource.com/1148659
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577627}
[modify] https://crrev.com/92d2c5baa0918dd97166b30339849b624e2fd74b/third_party/WebKit/LayoutTests/TestExpectations

Cc: worker-dev@chromium.org
Components: Blink>ServiceWorker
Labels: -Pri-3 -Sheriff-Chromium Pri-2
Owner: nhiroki@chromium.org
Status: Assigned (was: Untriaged)
Picked random person from content/browser/service_worker/OWNERS to assign to. PTAL, test was disabled due to Timeout on Linux.
Labels: -Pri-2 OS-Mac Pri-1
Bumping to a P1. Please update test expectations if no one is going to work on these soon.
Labels: -OS-Mac OS-Linux
Owner: bashi@chromium.org
I'll take a look.
I think this is issue 856601.
Labels: -Pri-1 Pri-3
Yeah, looks similar but I noticed that external/wpt/service-workers/service-worker/interfaces-sw.https.html didn't time out on my msan build when I disable ServiceWorkerServicification.

$ ./third_party/blink/tools/run_blink_wptserve.py&
$ out/msan/content_shell --disable-features=ServiceWorkerServicification --run-web-tests --ignore-certificate-errors https://web-platform.test:8444/service-workers/service-worker/interfaces-sw.https.html

The above printed outputs but when I enable servicification it never finished. 

De-prioritizing as the cause could be the same as issue 856601.
That's interesting. Could be a bug in s13nsw or just it happens to trigger the timeout behavior seen on issue 856601?

We should at least move the expectations to MSANExpectations so they aren't disabled for all of Linux, and probably update the bug number to point there.
Not sure there is a bug in s13nsw or not. When servicification is enabled, content_shell just didn't say anything.

Moving entries to MSANExpectations.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6a03569dea7b9baeb4ea58895ca57e7e7811aa4

commit a6a03569dea7b9baeb4ea58895ca57e7e7811aa4
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Mon Jul 30 02:14:59 2018

Move some S13nServiceWorker related test expectations to MSANExpectations

These tests are timing out only on msan bots. Move these entries
to MSANExpectations so that we can make sure these tests pass
on linux bots.

Bug:  866965 , 856601
Change-Id: I48d15a00a508c989865ebba2fa88987ddcd46c80
Reviewed-on: https://chromium-review.googlesource.com/1154609
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578964}
[modify] https://crrev.com/a6a03569dea7b9baeb4ea58895ca57e7e7811aa4/third_party/WebKit/LayoutTests/MSANExpectations
[modify] https://crrev.com/a6a03569dea7b9baeb4ea58895ca57e7e7811aa4/third_party/WebKit/LayoutTests/TestExpectations

Mergedinto: 678905
Status: Duplicate (was: Assigned)
The root cause is most likely issue 678905 and servicification somehow triggered the bug.

Sign in to add a comment