Issue metadata
Sign in to add a comment
|
Text Color of Background Tabs can blend in with the tabstrip background
Reported by
isan...@gmail.com,
Jul 24
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3493.3 Safari/537.36 Steps to reproduce the problem: 1. Select a GTK+ theme with a dark-colored titlebar 2. Disable System Titlebars and Borders 3. Open Chrome Dev Version 69 4. Open several other tabs What is the expected behavior? Background tab names can be read against the background What went wrong? Background tabs use a dark text color, which can blend in poorly if the theme uses dark-colored titlebars. Did this work before? Yes Before the new Material Design tabs. Chrome version: 69.0.3493.3 Channel: dev OS Version: Pop!_OS 18.04 (Ubuntu) Flash Version: Probably should try and use the titlebar text color for the background tab text color, possibly semi-transparent to help distinguish them from the foreground tab.
,
Jul 24
Which GTK theme is this?
,
Jul 24
Never mind, I'm seeing this issue now. It's a fairly recent regression
,
Jul 24
,
Jul 24
Yeah, seems to happen on any -dark variant that I come across. The theme in the screenshots is Pop, but I can replicate it in Materia and Adapta as well.
,
Jul 24
Bisected the issue to https://chromium.googlesource.com/chromium/src/+/767b6ae40b6c85897595dd2a579e0f4e400cc04a Alan ptal
,
Aug 3
The default theme on Ubuntu (Ambiance) is affected by this bug. I wouldn't want to ship GM2 without a fix, so I'm going to try investigating
,
Aug 3
,
Aug 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d090b4033e4b8ca7a2641e254ab6727a8a6749cf commit d090b4033e4b8ca7a2641e254ab6727a8a6749cf Author: Tom Anderson <thomasanderson@chromium.org> Date: Sat Aug 04 04:44:51 2018 GTK: Fix background tab color in refresh Because of the code in [1], themes are now expected to provide the background tab color themselves. This change restores the old computation of the background colors for the GTK theme. [1] https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_service.cc?rcl=306871de3e87f2d1844952ee730112e1fdabbae4&l=473 BUG= 866953 Change-Id: I16c4577a78f25e95d1a602ed7f795d2b032f2e0a Reviewed-on: https://chromium-review.googlesource.com/1162671 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#580741} [modify] https://crrev.com/d090b4033e4b8ca7a2641e254ab6727a8a6749cf/chrome/browser/ui/libgtkui/gtk_ui.cc [modify] https://crrev.com/d090b4033e4b8ca7a2641e254ab6727a8a6749cf/chrome/browser/ui/libgtkui/gtk_util.cc [modify] https://crrev.com/d090b4033e4b8ca7a2641e254ab6727a8a6749cf/chrome/browser/ui/libgtkui/gtk_util.h
,
Aug 4
,
Aug 5
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 5
Is the change fully safe to merge to M69?
,
Aug 6
Able to reproduce the issue on Ubuntu 17.10 on reported version 69.0.3493.3. Verified the fix on Ubuntu 17.10, as per comment#0 on latest chrome version #70.0.3514.0. Attaching screen shot for reference. Observed that themes are able provide tab background color themselves on applying GTK theme. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Aug 6
> Is the change fully safe to merge to M69? Yes, it should be safe.
,
Aug 6
Approving merge to M69 branch 3497 based on comment #13 and #14. Please merge ASAP. Pls mark bug as fixed if nothing else is pending after the merge. Thank you.
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bf7cf2939db59e923e4371863d63be4216da184 commit 6bf7cf2939db59e923e4371863d63be4216da184 Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Aug 06 18:30:53 2018 [Merge to M69] GTK: Fix background tab color in refresh > Because of the code in [1], themes are now expected to provide the > background tab color themselves. This change restores the old > computation of the background colors for the GTK theme. > > [1] https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_service.cc?rcl=306871de3e87f2d1844952ee730112e1fdabbae4&l=473 > > BUG= 866953 > > Change-Id: I16c4577a78f25e95d1a602ed7f795d2b032f2e0a > Reviewed-on: https://chromium-review.googlesource.com/1162671 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580741} BUG= 866953 TBR=thestig NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I3cc91bb85ba1f1d0b1f1d53f0ccb90e8c5d053db Reviewed-on: https://chromium-review.googlesource.com/1163919 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#423} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/6bf7cf2939db59e923e4371863d63be4216da184/chrome/browser/ui/libgtkui/gtk_ui.cc [modify] https://crrev.com/6bf7cf2939db59e923e4371863d63be4216da184/chrome/browser/ui/libgtkui/gtk_util.cc [modify] https://crrev.com/6bf7cf2939db59e923e4371863d63be4216da184/chrome/browser/ui/libgtkui/gtk_util.h
,
Aug 6
,
Aug 9
Verified the fix on Ubuntu 17.10, as per comment#0 on latest chrome version #69.0.3497.32 Attaching screen shot for reference. Observed that themes are able provide tab background color themselves on applying GTK theme. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on build without fix. Thanks...!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by thomasanderson@chromium.org
, Jul 24